- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: engine: no documentation message
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: no documentation message ...................................................................... engine: no documentation message - Fixed issue where the locale in the links would have an underscore, while the documentation would contain a dash. This caused the message to popup even though the documentation was installed. Fixed it so it no longer matters if the link has an underscore or dash in it, both will correctly determine if the language is available. Change-Id: Ic70eb10eb0264857568028f8307df4408dd36922 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011430 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/DocsServlet.java 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic70eb10eb0264857568028f8307df4408dd36922 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Defer item selection 'til after items are set
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Defer item selection 'til after items are set ...................................................................... webadmin: Defer item selection 'til after items are set So far the selection was performed before the list of items was refreshed in the view, and (presumably because of GWT implementation) this caused the list of items to not be refreshed immediately. Change-Id: I9ab512bc315a5f01e9ddb3fe7321b596b83e7cf3 Bug-Url: https://bugzilla.redhat.com/999882 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ab512bc315a5f01e9ddb3fe7321b596b83e7cf3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: block editing migraion fields while VM !Down
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: block editing migraion fields while VM !Down ...................................................................... engine: block editing migraion fields while VM !Down While the VM isn't down block editing migration and pinToHost fields in engine, and add a tooltip in UI to explain that. Change-Id: If9fb2fc0755317a8d4be7628b56966d82e9adc3a Bug-Url: https://bugzilla.redhat.com/735260 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 4 files changed, 12 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9fb2fc0755317a8d4be7628b56966d82e9adc3a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: select a host even if scheduling scoring failed
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: select a host even if scheduling scoring failed ...................................................................... engine: select a host even if scheduling scoring failed If no internal scoring function is selected it can result In no host selected at all, even if some hosts did pass the filtering stage. Select the first host if none has returned from the scoring functions. Change-Id: I96082ccdfd8759619e98bc437fdb468b3b583992 Bug-Url: https://bugzilla.redhat.com/1001986 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96082ccdfd8759619e98bc437fdb468b3b583992 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: external scheduler dont pass empty guid
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: external scheduler dont pass empty guid ...................................................................... engine: external scheduler dont pass empty guid When using external balance an empty string may return resulting in a 0000-00... guid, causing unnecessary logging of missing guid Change-Id: I4887100e99810d3d09af90a19f116f34ede3f99e Bug-Url: https://bugzilla.redhat.com/1017718 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4887100e99810d3d09af90a19f116f34ede3f99e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Add vm name to quota message
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Add vm name to quota message ...................................................................... webadmin: Add vm name to quota message When a VM was created with no quota in an audit/enforcing DC (using REST for instance), the error message did not include the name of the offending vm Change-Id: I5a55b549f0127fde8b0afd6daae2ac06e0218e3d Bug-Url: https://bugzilla.redhat.com/949576 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a55b549f0127fde8b0afd6daae2ac06e0218e3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin - Fix report error msg on selecting entities across...
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin - Fix report error msg on selecting entities across DCs ...................................................................... webadmin - Fix report error msg on selecting entities across DCs When selecting multiple Hosts/VMs from different DCs and opening a report Via Webadmin. An incorrect error message is displayed "Please select reports from the same data center" The message has been rephrased "Please select entities from the same data center" Change-Id: Ied2cbfd83aca1add35d7575fb117ed255385a0dc Bug-Url: https://bugzilla.redhat.com/885983 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/ReportPresenterWidget.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied2cbfd83aca1add35d7575fb117ed255385a0dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: check for stale VM before creation
by sbonazzo＠redhat.com 25 Oct '13

25 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: check for stale VM before creation ...................................................................... packaging: setup: check for stale VM before creation Added a check for stale Hosted Engine VM before creating it. In normal execution flow, this should never happen. However, it is possible that the user starts again the VM manually after having installed the OS and forget to poweroff (destroy) the VM. Now the user will be warned to properly poweroff the VM started manually in order to continue the setup process. The poweroff is not issued automatically because the VM can be in a stale state after a failure and the user must be aware that the VM is still around in order to debug the issue. Bug-Url: https://bugzilla.redhat.com/1010980 Change-Id: I8d5dfc17e10e677959e903f03515a124d5e97611 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5dfc17e10e677959e903f03515a124d5e97611 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: backend: remove vm check from LiveMigrateDiskCommand
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: backend: remove vm check from LiveMigrateDiskCommand ...................................................................... backend: remove vm check from LiveMigrateDiskCommand This patch shifts the VM status check from the LiveMigrateDiskCommand to VmReplicateDiskStartTaskHandler. This will: * prevent CreateImagePlaceholderTaskHandler from failing if the VM crashes during its execution * shift the failure to the appropriate handler (VmReplicateDiskStart) * allow the CreateImagePlaceholderTaskHandler compensation to take place and remove the destination image when necessary Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=957703 Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: fix AIO stage definition
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: fix AIO stage definition ...................................................................... packaging: setup: fix AIO stage definition This fixes breakage introduced by commit 1fca5dd1160f8 Change-Id: I358674153a116991a9bb3e181e69e64366cfe709 Bug-Url: https://bugzilla.redhat.com/1010691 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I358674153a116991a9bb3e181e69e64366cfe709 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0