- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Added scrolling to vNIC profiles
by lvernia＠redhat.com 27 Oct '13

27 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added scrolling to vNIC profiles ...................................................................... webadmin: Added scrolling to vNIC profiles In add/edit network, added a vertical scroll bar to the vNIC profile section. Change-Id: I2fedc75dfcd534775fdb80b3364b81d99aab74eb Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml 2 files changed, 7 insertions(+), 8 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fedc75dfcd534775fdb80b3364b81d99aab74eb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: image cell - show tooltip only when needed
by derez＠redhat.com 27 Oct '13

27 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: image cell - show tooltip only when needed ...................................................................... webadmin: image cell - show tooltip only when needed StyledImageResourceCell -> title panel should be visible only when a title is available (i.e. != empty string). Example screenshot: http://i.imgur.com/oem3uNH.png Change-Id: If3ea9edf883dfffe59996ef31efe96a6d60f6ccf Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3ea9edf883dfffe59996ef31efe96a6d60f6ccf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix the trimElements method of the OsRepo
by rgolan＠redhat.com 27 Oct '13

27 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: core: Fix the trimElements method of the OsRepo ...................................................................... core: Fix the trimElements method of the OsRepo Modifies the trimElements method of the OsRepositoryImpl class to filter out empty elements and correctly handle properties with empty lists as values. Change-Id: I16f6e387c231c78b43c76055748735ae456ab0fe Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16f6e387c231c78b43c76055748735ae456ab0fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: support nested plugins
by Alon Bar-Lev 26 Oct '13

26 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support nested plugins ...................................................................... core: support nested plugins Change-Id: I99c7eb33a258372e8fb8068a5d8271a999138c1d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/context.py 2 files changed, 14 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c7eb33a258372e8fb8068a5d8271a999138c1d Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: cleanup plugin load
by Alon Bar-Lev 26 Oct '13

26 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: cleanup plugin load ...................................................................... core: cleanup plugin load Change-Id: I8d0c7ae371f853b581a33a68718358e62c6c763c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 30 insertions(+), 35 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d0c7ae371f853b581a33a68718358e62c6c763c Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[master]: monitor: recognize additional vm states
by gpadgett＠redhat.com 25 Oct '13

25 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: monitor: recognize additional vm states ...................................................................... monitor: recognize additional vm states The 'waitforlaunch' state was seen on a vm, causing incorrect reporting that the vm was down. Upon further investigation, there were several unhandled vm states. These will be considered 'vm-up bad-health-status' by the engine health monitor, giving the host/vm a window of time to pass through the transient state before any action is taken by the agent. Change-Id: I1b73870306a559505d3441e9a2e57dfb0d191bae Bug-Url: https://bugzilla.redhat.com/1019468 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alex Lourie: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b73870306a559505d3441e9a2e57dfb0d191bae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: replace TBD string
by dougsland＠redhat.com 25 Oct '13

25 Oct '13

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: replace TBD string ...................................................................... engine_page: replace TBD string We must replace the TBD (To be defined) title when showing to users the Engine cert fingerprint. Change-Id: Idedcc24be983711f5b4a9372296fb4533badb480 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1022711 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified; Looks good to me, approved Alon Bar-Lev: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idedcc24be983711f5b4a9372296fb4533badb480 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: check for stale VM before creation
by sbonazzo＠redhat.com 25 Oct '13

25 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: check for stale VM before creation ...................................................................... packaging: setup: check for stale VM before creation Added a check for stale Hosted Engine VM before creating it. In normal execution flow, this should never happen. However, it is possible that the user starts again the VM manually after having installed the OS and forget to poweroff (destroy) the VM. Now the user will be warned to properly poweroff the VM started manually in order to continue the setup process. The poweroff is not issued automatically because the VM can be in a stale state after a failure and the user must be aware that the VM is still around in order to debug the issue. Bug-Url: https://bugzilla.redhat.com/1010980 Change-Id: I8d5dfc17e10e677959e903f03515a124d5e97611 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5dfc17e10e677959e903f03515a124d5e97611 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Clarifying CDA message of adding vnic profile
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Clarifying CDA message of adding vnic profile ...................................................................... engine: Clarifying CDA message of adding vnic profile The patch clarifies the can-do-action of adding a vnic profile to a non-vm network. Change-Id: I4e829ffb118ce066a266196286b9b7ea8e578ecc Bug-Url: https://bugzilla.redhat.com/1012009 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e829ffb118ce066a266196286b9b7ea8e578ecc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Prevent vnic live update for if network not on host
by iheim＠redhat.com 25 Oct '13

25 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Prevent vnic live update for if network not on host ...................................................................... engine: Prevent vnic live update for if network not on host The patch blocks updating a plugged vnic on a running vm to a network which doesn't exist on the host. It also fixes a bug of setting an empty vnic profile while updating a plugged vnic. Change-Id: I0c9d8f2202efa2e45a2144bbdb70d374bdb9ff6f Bug-Url: https://bugzilla.redhat.com/1017602 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 1 file changed, 23 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c9d8f2202efa2e45a2144bbdb70d374bdb9ff6f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0