- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: add constants list to the engine
by iheim＠redhat.com 24 Oct '13

24 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: add constants list to the engine ...................................................................... packaging: setup: add constants list to the engine The current implementation saves to answerfile and postinstall file only values appearing in constants.py and matching certain criteria, ignoring any additional constants files existing. The new implementation brings a new structure that holds all constants objects, and updates the answerfile/postinstallfile implementations to work on all elements of this structure. To use the new method, a 3rd party plugin bringing its own constants file should add its object to environment variable osetupcons.CoreEnv.SETUP_ATTRS_MODULES dict. For example, for additional constants_add.py, we do: import constants_add as constadd self.environment[ osetupcons.CoreEnv.SETUP_ATTRS_MODULES ].append(constadd) Change-Id: I6c919ed564003ed93300a84fc9072443eb865cf0 Bug-Url: https://bugzilla.redhat.com/1013790 Signed-off-by: Alex Lourie <alourie(a)redhat.com> (cherry picked from commit 63558007f1955f48912a73c7758e90c2cc4fec03) (cherry picked from commit d636638fe16bc68fc149ff4d43d44f78ba1c9bf0) --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/core/answerfile.py M packaging/setup/plugins/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-common/core/postinstall.py 4 files changed, 18 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c919ed564003ed93300a84fc9072443eb865cf0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: disable AIO on CPUs without VT
by iheim＠redhat.com 24 Oct '13

24 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: disable AIO on CPUs without VT ...................................................................... packaging: setup: disable AIO on CPUs without VT Change-Id: I6f5d1edf045fdfb878e6cf2d2cfa8a2e74b10db8 Bug-Url: https://bugzilla.redhat.com/1010691 Signed-off-by: Alex Lourie <alourie(a)redhat.com> (cherry picked from commit e9023e7f92fc33c331db30dd2ce13217fb6d14ba) --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/core.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/cpu.py 3 files changed, 51 insertions(+), 13 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f5d1edf045fdfb878e6cf2d2cfa8a2e74b10db8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: in PM only selecting apc or ipmilan...
by iheim＠redhat.com 24 Oct '13

24 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: in PM only selecting apc or ipmilan... ...................................................................... core: in PM only selecting apc or ipmilan... in PM only selecting apc or ipmilan changes the options, choosing other types is static The reason for that was that fence options mapping were called with 'general' version and since this key is versioned, the static value for this key in ConfigValues.java was returned. This value misses some of the recent agents added in 3.2 and 3.3 and cause this BZ. This patch fix this issue by getting 6the fence options mapping from the database for the given cluster version. Change-Id: I2f815e90d95e8cd21aca51a803dccde8079dee5d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014513 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptionsQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAgentFenceOptionsQueryParameters.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 6 files changed, 43 insertions(+), 14 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f815e90d95e8cd21aca51a803dccde8079dee5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: add README file to configuration drop dirs
by iheim＠redhat.com 24 Oct '13

24 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: add README file to configuration drop dirs ...................................................................... packaging: setup: add README file to configuration drop dirs Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020675 Change-Id: I17797e329be28ba938fbc4c57703aa2d3517ec15 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in A packaging/etc/engine.conf.d/README.in A packaging/etc/notifier/notifier.conf.d/README.in A packaging/etc/ovirt-websocket-proxy.conf.d/README.in 6 files changed, 36 insertions(+), 6 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17797e329be28ba938fbc4c57703aa2d3517ec15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: turn engine.conf to ghost
by iheim＠redhat.com 24 Oct '13

24 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: turn engine.conf to ghost ...................................................................... packaging: setup: turn engine.conf to ghost this file should not be used as drop dir resolves the rpmnew/rpmsave hell. it must remain as ghost for backward compatibility. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1020675 Change-Id: I68ada5e69ec8fc255013b29ad47134f30bacd758 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in D packaging/etc/engine.conf 2 files changed, 2 insertions(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68ada5e69ec8fc255013b29ad47134f30bacd758 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: cleanup: sort generated files
by iheim＠redhat.com 24 Oct '13

24 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: cleanup: sort generated files ...................................................................... packaging: setup: cleanup: sort generated files Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1020675 Change-Id: I69e8e030e8619282804cf1990af199941211b3d4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile 2 files changed, 15 insertions(+), 15 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69e8e030e8619282804cf1990af199941211b3d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: [db]Upgrade from ovirt-engine-3.3 to master fails
by emesika＠redhat.com 24 Oct '13

24 Oct '13

Eli Mesika has submitted this change and it was merged. Change subject: [db]Upgrade from ovirt-engine-3.3 to master fails ...................................................................... [db]Upgrade from ovirt-engine-3.3 to master fails This patch renames a script that should be prefixed with 03_04 and had wrong 03_03 prefix which cause to version duplication on upgrade from 3.3 stable branch Change-Id: I5f79c47e8122bc5a7ae96f508996f6b318a54e45 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023048 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- R packaging/dbscripts/upgrade/03_04_0060_add_snapshot_id_column_to_vm_device.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f79c47e8122bc5a7ae96f508996f6b318a54e45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removal of unused method
by mlipchuk＠redhat.com 24 Oct '13

24 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: removal of unused method ...................................................................... core: removal of unused method ImagesHandler.getActiveVolume isn't used anymore, therefore it can be removed. Change-Id: I33debd24aab205e8fd31f7ad7ed6c2a2b1ea2117 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33debd24aab205e8fd31f7ad7ed6c2a2b1ea2117 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: conf: use ovirt-engine-lib configfile
by sbonazzo＠redhat.com 24 Oct '13

24 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: conf: use ovirt-engine-lib configfile ...................................................................... conf: use ovirt-engine-lib configfile Use ovirt-engine-lib configfile module for reading configuration files. The previous implementation had an issue if a variable was defined recursively in more than one config file. Change-Id: I1f47875a279953bae783407dca41102904a70061 Bug-Url: http://bugzilla.redhat.com/1022557 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-log-collector.spec.in M src/Makefile.am M src/__main__.py D src/util.py 4 files changed, 6 insertions(+), 110 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f47875a279953bae783407dca41102904a70061 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin - Fix report error msg on selecting entities across...
by derez＠redhat.com 24 Oct '13

24 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin - Fix report error msg on selecting entities across DCs ...................................................................... webadmin - Fix report error msg on selecting entities across DCs When selecting multiple Hosts/VMs from different DCs and opening a report Via Webadmin. An incorrect error message is displayed "Please select reports from the same data center" The message has been rephrased "Please select entities from the same data center" Change-Id: Ied2cbfd83aca1add35d7575fb117ed255385a0dc Bug-Url: https://bugzilla.redhat.com/885983 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/ReportPresenterWidget.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied2cbfd83aca1add35d7575fb117ed255385a0dc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0