- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Custom properties code cleanup
by emesika＠redhat.com 24 Oct '13

24 Oct '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Custom properties code cleanup ...................................................................... core: Custom properties code cleanup Removes member initialization. Renames attributes to match Java Code conventions. Adds missing Javadoc. Change-Id: I045a6ae15cd3bb840ae1fa2561f90e35b2c00fa6 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java 3 files changed, 69 insertions(+), 27 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I045a6ae15cd3bb840ae1fa2561f90e35b2c00fa6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: Add a controlling TTY for ausearch
by sbonazzo＠redhat.com 24 Oct '13

24 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add a controlling TTY for ausearch ...................................................................... Add a controlling TTY for ausearch The ausearch command required a controlling TTY in order to finish execution propely. This fix adds the '-t' flag to the ssh command used in the log-collector Signed-off-by: James W. Mills <jamills(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1022505 Change-Id: I5b7b04c037d44c6d699db670d1d98b0db678fccf --- M src/__main__.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b7b04c037d44c6d699db670d1d98b0db678fccf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: James W. Mills <jamills(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Clarifying CDA message of adding vnic profile
by masayag＠redhat.com 24 Oct '13

24 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Clarifying CDA message of adding vnic profile ...................................................................... engine: Clarifying CDA message of adding vnic profile The patch clarifies the can-do-action of adding a vnic profile to a non-vm network. Change-Id: I4e829ffb118ce066a266196286b9b7ea8e578ecc Bug-Url: https://bugzilla.redhat.com/1012009 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e829ffb118ce066a266196286b9b7ea8e578ecc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Update VM pool fail with NPE
by iheim＠redhat.com 24 Oct '13

24 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Update VM pool fail with NPE ...................................................................... restapi: Update VM pool fail with NPE Need to set the SingleQxlPci when editing pool from Rest. Bug-Url: https://bugzilla.redhat.com/1006884 Change-Id: I989fdf6816095c4d607c94331f54f4effb10f03e Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I989fdf6816095c4d607c94331f54f4effb10f03e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Refuse restoring to non-empty db
by sbonazzo＠redhat.com 24 Oct '13

24 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Refuse restoring to non-empty db ...................................................................... packaging: engine-backup: Refuse restoring to non-empty db Revert I8bdd8c01349b3cb2a4b1ab79a048c09479c23f27 . Refuse to restore to a non-empty database. Bug-Url: https://bugzilla.redhat.com/1020277 Change-Id: I83d500e2a59e30d40c15cbde82b84d12206028dd Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/20455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83d500e2a59e30d40c15cbde82b84d12206028dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: clean '&' in jdbcTlsOptions
by iheim＠redhat.com 23 Oct '13

23 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: clean '&' in jdbcTlsOptions ...................................................................... packaging: setup: clean '&' in jdbcTlsOptions Without this change, we might get an '&' immediately after the '?' in ENGINE_DB_URL. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1002401 Change-Id: If8bb485e03c9d9d4c967f763a157151b11cbb84d Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/database.py 1 file changed, 15 insertions(+), 12 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8bb485e03c9d9d4c967f763a157151b11cbb84d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: quote database variables
by iheim＠redhat.com 23 Oct '13

23 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: quote database variables ...................................................................... packaging: setup: quote database variables best to quote anything, especially if it contains special characters such as '&'. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1002401 Change-Id: I8c05822580656e9b98d029fa39e8b37caf5b5736 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/database.py 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c05822580656e9b98d029fa39e8b37caf5b5736 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: remove quota comsumer is broken
by iheim＠redhat.com 23 Oct '13

23 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: remove quota comsumer is broken ...................................................................... webadmin: remove quota comsumer is broken Although we use MLA dialogs, there is another treatment for consume_quota role (i.e. hiding it). generalizing it with other remove permission dialog creates an error. Bug-Url: https://bugzilla.redhat.com/1017740 Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/QuotaModule.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Einav Cohen: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/20440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Engine: Remove OS that have illegal parent from osinfo
by shavivi＠redhat.com 23 Oct '13

23 Oct '13

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: Remove OS that have illegal parent from osinfo ...................................................................... Engine: Remove OS that have illegal parent from osinfo Change-Id: If3fe1d802b4e01f5d29f146d55fbcc906e3629e2 Bug-Url: https://bugzilla.redhat.com/980879 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/MapBackedPreferences.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java 4 files changed, 35 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3fe1d802b4e01f5d29f146d55fbcc906e3629e2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Quote values in /etc/sysconfig/nfs
by sbonazzo＠redhat.com 23 Oct '13

23 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Quote values in /etc/sysconfig/nfs ...................................................................... packaging: setup: Quote values in /etc/sysconfig/nfs Quote values in variable assignments in /etc/sysconfig/nfs. Unquoted values might break sysvinit-based nfs init sh scripts. Bug-Url: https://bugzilla.redhat.com/1013347 Change-Id: Ie62b0f47b0244434967e9af13fcde7614280825b Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie62b0f47b0244434967e9af13fcde7614280825b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0