- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: remove disabled external scheduler plugin
by gchaplik＠redhat.com 07 Oct '13

07 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: remove disabled external scheduler plugin ...................................................................... engine: remove disabled external scheduler plugin Added a new command to remove disabled external policy units Added a new dialog to show all policy units, in this dialog, disabled external policy units can be removed. Change-Id: Ia03da19368b75b125aa3ea144b36016feddcb08c Bug-Url: https://bugzilla.redhat.com/1014700 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveExternalPolicyUnitCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/parameters/RemoveExternalPolicyUnitParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/ClusterPolicyListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/ManagePolicyUnitModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/scheduling/ManagePolicyUnitPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ManagePolicyUnitPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ManagePolicyUnitPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ClusterPolicyModelProvider.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/icn_external_policy.png M packaging/dbscripts/policy_unit_sp.sql 24 files changed, 508 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia03da19368b75b125aa3ea144b36016feddcb08c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: disable when external scheduler is down
by gchaplik＠redhat.com 07 Oct '13

07 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: disable when external scheduler is down ...................................................................... core: disable when external scheduler is down - When we are unable perform discovery on the external scheduler, mark all external policy units as disabled. Change-Id: I2cd7aa42f85f261f9e55e057b52d7dc4c5738252 Bug-Url: https://bugzilla.redhat.com/1014700 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cd7aa42f85f261f9e55e057b52d7dc4c5738252 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Disable + sign in custom properties
by gchaplik＠redhat.com 07 Oct '13

07 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Disable + sign in custom properties ...................................................................... webadmin: Disable + sign in custom properties When there are no more possible values disable the + sign in custom properties Change-Id: I40e391566dd3bcced2a345ce6a56e2244ac94294 Bug-Url: https://bugzilla.redhat.com/1001159 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 3 files changed, 27 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40e391566dd3bcced2a345ce6a56e2244ac94294 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: clearing snapshot_id on disk detach
by derez＠redhat.com 07 Oct '13

07 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: core: clearing snapshot_id on disk detach ...................................................................... core: clearing snapshot_id on disk detach When detaching a DiskImage, the snapshot [1] ID should be cleared. Otherwise, 'DiskImageDAO -> getAllSnapshotsForVmSnapshot' returns floating DiskImages (which shouldn't be taken into account in any flow since they're not relevant with regards to snapshots). Note: when attaching a DiskImage, the snapshot ID is already updated properly according to the VM. [1] only an active snapshot since detaching a disk with snapshots is blocked at canDo phase. Change-Id: Iad60d2a6500f4bd738095949c7e36a4ec34122c3 Bug-Url: https://bugzilla.redhat.com/1015170 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad60d2a6500f4bd738095949c7e36a4ec34122c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: adding no-arg constructor to RemoveVdsParameters
by yzaslavs＠redhat.com 07 Oct '13

07 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: adding no-arg constructor to RemoveVdsParameters ...................................................................... engine: adding no-arg constructor to RemoveVdsParameters According to GWT serialization policy the classes used in serialization should have a no-arg constructor. Added a no-arg constructor to RemoveVdsParameters class Change-Id: Ice662caf5e6a96858cf9d1f788cbf4b4744dcf7a Bug-Url: https://bugzilla.redhat.com/1012826 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice662caf5e6a96858cf9d1f788cbf4b4744dcf7a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: packaging: spec: requires openssh-clients
by sbonazzo＠redhat.com 07 Oct '13

07 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: requires openssh-clients ...................................................................... packaging: spec: requires openssh-clients Added dependency on openssh-clients, needed for having ssh command. Bug-Url: https://bugzilla.redhat.com/1015757 Change-Id: Ic73c38e16a25acef5aefccb52cbf7cd6fa09a101 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M ovirt-log-collector.spec.in 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic73c38e16a25acef5aefccb52cbf7cd6fa09a101 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Volume transport-type column moved to general tab
by kmayilsa＠redhat.com 07 Oct '13

07 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Volume transport-type column moved to general tab ...................................................................... webadmin: Volume transport-type column moved to general tab Moved transport Type Column of Volume to the General Sub Tab under Volumes Change-Id: I47ee14b203448debf0ea13615c0c8834ff915555 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/VolumeTransportTypeLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java 5 files changed, 75 insertions(+), 30 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47ee14b203448debf0ea13615c0c8834ff915555 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : fixed rebalance status dialog close button issue
by kmayilsa＠redhat.com 07 Oct '13

07 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : fixed rebalance status dialog close button issue ...................................................................... webadmin : fixed rebalance status dialog close button issue Fixed Clicking on the 'x' button does not close the status dialog. Now,Clicking on the 'x' button closes the status dialog. Change-Id: Ic0363784b13b26603f1f6279423adcac5e592045 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1012329 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0363784b13b26603f1f6279423adcac5e592045 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Rebalance status pop up title changed
by kmayilsa＠redhat.com 07 Oct '13

07 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Rebalance status pop up title changed ...................................................................... webadmin : Rebalance status pop up title changed Popup title changed to "Rebalance Status". With multiple paragraphs if necessary. Change-Id: Icac1781f5e256d4ad6c76d80c10af79bdf6a926d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014980 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icac1781f5e256d4ad6c76d80c10af79bdf6a926d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: clean CpuFlagsManager from unused methods
by rgolan＠redhat.com 07 Oct '13

07 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: core: clean CpuFlagsManager from unused methods ...................................................................... core: clean CpuFlagsManager from unused methods Change-Id: I43e65dc76232d60d8beb0675c2bff1e902c0dfdb Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java 1 file changed, 0 insertions(+), 97 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43e65dc76232d60d8beb0675c2bff1e902c0dfdb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0