- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: engine: Block multicast MAC addresses for vNICs
by iheim＠redhat.com 07 Oct '13

07 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Block multicast MAC addresses for vNICs ...................................................................... engine: Block multicast MAC addresses for vNICs The patch blocks the possibility to provide a non- unicast mac address to the vnic: neither broadcast or multicast mac addresses aren't allowed for a vnic. Change-Id: Ida4082be249391494053b56540d5458fecec65da Bug-Url: https://bugzilla.redhat.com/1011912 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterfaceValidationTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MacAddressValidation.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 15 files changed, 45 insertions(+), 43 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida4082be249391494053b56540d5458fecec65da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix broken backward compatibility of os ids
by rgolan＠redhat.com 07 Oct '13

07 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: core: Fix broken backward compatibility of os ids ...................................................................... core: Fix broken backward compatibility of os ids This fix is about maintaining oss backward compatibility mappings of old os names to the current IDs. Vm Import/Export is using the os unique name instead of the os ID in the OVF and since all unique names streamlined with the REST API representation they all are not identified and fallback ID 0 - "other" pre-osinfo exports would write the OS Windows8 while the new name is windows_8 and so on Solution: Added a backward compatibility section to osinfo-default.properties # Since Unassigned is removed we translate is to other so backwardCompatibility.Unasigned = 0 backwardCompatibility.Other = 0 # represents the current id of old Windows8 os backwardCompatibilty.Windows8 = 20 Bug-Url: https://bugzilla.redhat.com/1006340 Change-Id: I77c51a3bd0f4f0c264e8f895f40fd4d2bf4d689c Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImplTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M packaging/conf/osinfo-defaults.properties 5 files changed, 61 insertions(+), 11 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77c51a3bd0f4f0c264e8f895f40fd4d2bf4d689c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: Preferences loader - support non-versioned keys
by rgolan＠redhat.com 07 Oct '13

07 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: utils: Preferences loader - support non-versioned keys ...................................................................... utils: Preferences loader - support non-versioned keys Till today the preference loader treats keys and a node with multi-version values on it nodeA.nodeB.value.x = 1 nodeA.nodeB.value.y = 2 so "value" is also a node and x and y are keys on the node. this is specifig behaviour for paths in the form of a.b.c.value.x.y.z This design is not straight forward with non-versioned keys such as: nodeC.key = value so we can: Preferences nodeC = getNodeC(); nodeC.keys() # ["key"] nodeC.get("key") # "value" Bug-Url: https://bugzilla.redhat.com/1006340 Change-Id: I4b3bf67fbd892c37763428ae79204b59632d025d Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b3bf67fbd892c37763428ae79204b59632d025d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removing unsed IDs from ConfigValues
by rgolan＠redhat.com 07 Oct '13

07 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: core: removing unsed IDs from ConfigValues ...................................................................... core: removing unsed IDs from ConfigValues Change-Id: I4b7835f32339c2fd6323361a5c9188f5e147dd4d Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 350 insertions(+), 373 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b7835f32339c2fd6323361a5c9188f5e147dd4d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Display size of ISO and floppy files in human read...
by derez＠redhat.com 07 Oct '13

07 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Display size of ISO and floppy files in human readable format ...................................................................... webadmin: Display size of ISO and floppy files in human readable format Up until now DiskSizeRenderer which is used to render image/disk/file sizes had 2 limitations: 1. Size appeared only in GB. 2. Size smaller than 1GB appeared as '<1GB' >From now on, it also supports widely adopted Human Readable Format. This patch uses new capability when rendering size of ISO files and floppies under Storage ->ISO Storage Domain -> Images. Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a Bug-Url: https://bugzilla.redhat.com/1005889 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskSizeColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java 3 files changed, 48 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Set correct size of iso files and floppies
by derez＠redhat.com 07 Oct '13

07 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: engine: Set correct size of iso files and floppies ...................................................................... engine: Set correct size of iso files and floppies Previously all iso and floppy files appeared in UI with bogus size of '< 1 GB' although some of them are larger than that. Furthermore it would be nice to display file size in human readable way. The root cause of that problem is 'getIsoList' API between Engine and VDSM which returned only a list of file names until now, so Engine set their size to 0. It's worth mentioning before explaining API changes that this list contained only permitted files. Now this API returns a map with file stats including a size for all files including not permitted files. Meantime Engine filtering out files with wrong permissions, but they can be displayed in the future so user would be able to know why these files are not usable. Engine uses -1 when size is not available because old versions of VDSM don't send it. Change-Id: I77bd99beb8138524b25f0afdcce0815ad8664f0f Bug-Url: https://bugzilla.redhat.com/1005889 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetFloppyListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IsoListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HsmGetIsoListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 6 files changed, 108 insertions(+), 48 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77bd99beb8138524b25f0afdcce0815ad8664f0f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Correct default time-zone rendering
by tjelinek＠redhat.com 07 Oct '13

07 Oct '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Correct default time-zone rendering ...................................................................... frontend: Correct default time-zone rendering TimeZoneModel was returning incorrect display value in case the configured default was invalid. Now it returns display value corresponding to ultimate fallback for given TimeZoneType. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988259 Change-Id: Ic7be050a48c78ffdf2028ea5acfd0123bf4502a7 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TimeZoneModel.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7be050a48c78ffdf2028ea5acfd0123bf4502a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: move dialog - modified warnings and styling
by derez＠redhat.com 07 Oct '13

07 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: move dialog - modified warnings and styling ...................................................................... webadmin: move dialog - modified warnings and styling In order to provide a better indication to which of the selected disks cannot be moved/copied: * Added a list of problematic disks [1] into the dialog's warning. * Added an alert icon next to the warning. * Altered warnings position and style. [1] Disks that cannot be moved/copied (e.g. since the source/target domain is not available). Change-Id: Ib327915336dfbbdd6e71665b5d3ca603a8843698 Bug-Url: https://bugzilla.redhat.com/975096 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/CopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml 9 files changed, 53 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib327915336dfbbdd6e71665b5d3ca603a8843698 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: [core] rename VdsStatic hostname to hostName.
by yzaslavs＠redhat.com 07 Oct '13

07 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: [core] rename VdsStatic hostname to hostName. ...................................................................... [core] rename VdsStatic hostname to hostName. Change field name to match setters and getters. in UpdateVdsCommand changed attribute names are derived from getters/setters while the list of changeable fields are derived from the field name (see vdsHandler.Init()) Change-Id: Ie6461e1ed17506f7ea2a8897ad2a3847d466268f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003282 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6461e1ed17506f7ea2a8897ad2a3847d466268f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: detect display port at runtime
by sbonazzo＠redhat.com 07 Oct '13

07 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: detect display port at runtime ...................................................................... packaging: setup: detect display port at runtime previously the tool wrongly assumed that the SPICE and the VNC port was always 5900. It may happen however that secureDisplayPort is set to 5901 instead of 5900. Now displayPort and secureDisplayPort are detected at runtime querying the status of the VM. Firewall ports 5900 and 5901 are now both open. Change-Id: I8ae46b061b2a3ad0190f798cb141a41431120839 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py M templates/hosted-console.xml.in 2 files changed, 29 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ae46b061b2a3ad0190f798cb141a41431120839 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0