- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Open correct bond dialog from Network/Hosts subtab
by iheim＠redhat.com 07 Oct '13

07 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Open correct bond dialog from Network/Hosts subtab ...................................................................... webadmin: Open correct bond dialog from Network/Hosts subtab Apparently the old (pre 3.1) bond dialog would open, when the newer one should. Also removed code that checked if the open dialog is the Setup Networks dialog, which as far as I know is the only possible case in this subtab (whereas in Host/Networks it could have been the pre-3.1 Host Interfaces dialog). Change-Id: Ia5cc40bda079513bfce7b08d6f279aaebe554817 Bug-Url: https://bugzilla.redhat.com/1012821 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java 1 file changed, 9 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/19896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5cc40bda079513bfce7b08d6f279aaebe554817 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: save configuration immediately as available
by ydary＠redhat.com 06 Oct '13

06 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: save configuration immediately as available ...................................................................... packaging: setup: save configuration immediately as available Change-Id: Iaf40ddc7885f7d59a779601fb57d9556c30062be Bug-Url: https://bugzilla.redhat.com/1006950 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 37 insertions(+), 19 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf40ddc7885f7d59a779601fb57d9556c30062be Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Align javadocs with methods' signatures
by amureini＠redhat.com 06 Oct '13

06 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Align javadocs with methods' signatures ...................................................................... engine: Align javadocs with methods' signatures Change-Id: Ib8007f3e800c99cf5cc18a96bce9b8ed372cbf6a Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java 2 files changed, 14 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8007f3e800c99cf5cc18a96bce9b8ed372cbf6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix NPE in UpdateVmDiskCommand
by amureini＠redhat.com 06 Oct '13

06 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Fix NPE in UpdateVmDiskCommand ...................................................................... engine: Fix NPE in UpdateVmDiskCommand The patch http://gerrit.ovirt.org/#/c/19446/ introduces a change which set quota_id as NULL instead of Guid.Empty. It causes NullPointerException in UpdateVmDiskCommand. Change-Id: If689b77cfe4b4a466b70cd9194e99f0eeafcca09 Bug-Url: https://bugzilla.redhat.com/1015872 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If689b77cfe4b4a466b70cd9194e99f0eeafcca09 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Open correct bond dialog from Network/Hosts subtab
by lvernia＠redhat.com 06 Oct '13

06 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Open correct bond dialog from Network/Hosts subtab ...................................................................... webadmin: Open correct bond dialog from Network/Hosts subtab Apparently the old (pre 3.1) bond dialog would open, when the newer one should. Also removed code that checked if the open dialog is the Setup Networks dialog, which as far as I know is the only possible case in this subtab (whereas in Host/Networks it could have been the pre-3.1 Host Interfaces dialog). Change-Id: Ia5cc40bda079513bfce7b08d6f279aaebe554817 Bug-Url: https://bugzilla.redhat.com/1012821 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java 1 file changed, 9 insertions(+), 13 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5cc40bda079513bfce7b08d6f279aaebe554817 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: InitVdsOnUp - flow fixes
by amureini＠redhat.com 06 Oct '13

06 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: InitVdsOnUp - flow fixes ...................................................................... core: InitVdsOnUp - flow fixes 1. If the master domain is inactive/unknown - a host shouldn't fail this phase of the flow if it respondes to getVdsStats. 2. If the master domain is inactive/unknown - the host shouldn't fail the flow according to it's domain report. Examples for relevant scenarios: 1. When there are no active hosts, all the domains are marked as "unknown", if we will attempt to activate a host and it won't be able to connect to the pool because of VDS_NETWORK_ERROR, the host won't move to UP because of the check of it's domain report. 2. When there are no active hosts and a host is being activated, successfully connects to the pool and it can't see any of the domains it won't move to UP because of it's domain report. Change-Id: I61fcc58be133efdecf264c22015609f6ee3ed942 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 19 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61fcc58be133efdecf264c22015609f6ee3ed942 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi, engine: Support network name in update nic
by masayag＠redhat.com 06 Oct '13

06 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi,engine: Support network name in update nic ...................................................................... restapi,engine: Support network name in update nic The network name and the port mirroring flag provided by the restapi for updating a vnic name should be respected. In this case the vnic profile id will be ignored. In addition, the patch allows to set 'null' value for the vnic profile id, which is treated as unlinking the nic from the network: <nic> <vnic_profile/> </nic> This patch designed for backward compatibility only of the add/update vm nic. Change-Id: I1f5c96daf64f6e14cc76bfb12daf89618f656b3d Bug-Url: https://bugzilla.redhat.com/1011116 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmInterfaceParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateInterfaceParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java 8 files changed, 112 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f5c96daf64f6e14cc76bfb12daf89618f656b3d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add test for mac address format
by masayag＠redhat.com 06 Oct '13

06 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Add test for mac address format ...................................................................... core: Add test for mac address format The patch adds a unit test to cover the used patterns list for verifying the correct format of a mac address. Change-Id: I74c6c310be787a1bea81f9d344d91e80f48cdc2b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MacAddressPatternTest.java 2 files changed, 70 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74c6c310be787a1bea81f9d344d91e80f48cdc2b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: stop and warn if setup is not run as root ...
by ydary＠redhat.com 06 Oct '13

06 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: stop and warn if setup is not run as root user. ...................................................................... packaging: setup: stop and warn if setup is not run as root user. Change-Id: I4aeb4cc80d4ddab8bfdd0c3717ba3c3763ab3b41 Bug-Url: https://bugzilla.redhat.com/853957 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aeb4cc80d4ddab8bfdd0c3717ba3c3763ab3b41 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fall-through in PolicyUnitImpl
by amureini＠redhat.com 06 Oct '13

06 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fall-through in PolicyUnitImpl ...................................................................... core: Fall-through in PolicyUnitImpl Fixed the faulty (unintended) fall-through in PolicyUnitImpl.getPolicyUnitImpl(PolicyUnit). Change-Id: I404f40a1ec2478ae2ef843ce5454cf717dfbb25c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/19894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I404f40a1ec2478ae2ef843ce5454cf717dfbb25c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0