- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add check for iqn in addStorageServerConn
by amureini＠redhat.com 19 Jun '13

19 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add check for iqn in addStorageServerConn ...................................................................... core: add check for iqn in addStorageServerConn Add a new validation in canDoAction that iqn (the adress field) properties is not empty in AddStorageServerConnection in case of iSCSI storage domains. Also added relevant unitests and error messages. Change-Id: Ide54ab2ec4a864dadd01cbe746df6592e32eab2f Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 41 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide54ab2ec4a864dadd01cbe746df6592e32eab2f Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: build: remove unused directories
by oschreib＠redhat.com 18 Jun '13

18 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: remove unused directories ...................................................................... packaging: build: remove unused directories Change-Id: Icf8fb62b30d1d74cc9d1d375f95dfda2ea762dba Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in 2 files changed, 0 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf8fb62b30d1d74cc9d1d375f95dfda2ea762dba Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: fix pep8 issues
by oschreib＠redhat.com 18 Jun '13

18 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: fix pep8 issues ...................................................................... packaging: fix pep8 issues Change-Id: Iddd48d9656750ecbe3bb6c4ee062f31e17e880f6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine-notifier.py M packaging/services/ovirt-engine.py M packaging/setup/ovirt_engine_setup/database.py M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py 4 files changed, 10 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddd48d9656750ecbe3bb6c4ee062f31e17e880f6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: move packaging/man->packaging/man/man8
by oschreib＠redhat.com 18 Jun '13

18 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: move packaging/man->packaging/man/man8 ...................................................................... packaging: move packaging/man->packaging/man/man8 allow easier future blind copy. Change-Id: I571f139a7fb031af970e2b157283669370635c77 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile R packaging/man/man8/engine-config.8 R packaging/man/man8/engine-manage-domains.8 R packaging/man/man8/engine-setup.8 R packaging/man/man8/engine-upgrade.8 5 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I571f139a7fb031af970e2b157283669370635c77 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: move packaging/etc/pki to packaging/pki
by oschreib＠redhat.com 18 Jun '13

18 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: move packaging/etc/pki to packaging/pki ...................................................................... packaging: move packaging/etc/pki to packaging/pki this will ease future blind copy during installation. Change-Id: Id0032e4ce3c2bf795120a3bef7643844d04d81ce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile R packaging/pki/cacert.template.in R packaging/pki/cert.template.in R packaging/pki/openssl.conf 4 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0032e4ce3c2bf795120a3bef7643844d04d81ce Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: fix install file modes
by oschreib＠redhat.com 18 Jun '13

18 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: fix install file modes ...................................................................... packaging: build: fix install file modes missing executable and extra executable. Change-Id: I9beea5ea263c31d16148737e22274c113ab8d953 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/services/service.py 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9beea5ea263c31d16148737e22274c113ab8d953 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: quote everything
by oschreib＠redhat.com 18 Jun '13

18 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: quote everything ...................................................................... packaging: build: quote everything Change-Id: Idff4c68a59546cd94021ff6e82973ab8219f0298 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 134 insertions(+), 134 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idff4c68a59546cd94021ff6e82973ab8219f0298 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: move setup related files out of versionloc...
by oschreib＠redhat.com 18 Jun '13

18 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: move setup related files out of versionlock ...................................................................... packaging: setup: move setup related files out of versionlock the setup requires files that currently resides under base package. due to legacy, these files are versionlocked, this means that they are not at their latest version when setup runs. the only way to move them to setup package is to rename. 1. iptables.defaults is actually a template so adding .in suffix is required anyway. 2. nfs.sysconfig is not really a template but can be considered as such for future use. 3. ovirt-engine-proxy.conf.v2.in became ugly. Change-Id: Ia2e9938a7c1dba61a8c3d88e670c8b9f7203e6a4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in R packaging/conf/iptables.default.in R packaging/conf/nfs.sysconfig.in R packaging/conf/ovirt-engine-proxy.conf.v2.in M packaging/fedora/setup/basedefs.py M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/ovirt_engine_setup/util.py M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py 9 files changed, 24 insertions(+), 22 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2e9938a7c1dba61a8c3d88e670c8b9f7203e6a4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: move all customization vars to makefile pr...
by oschreib＠redhat.com 18 Jun '13

18 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: move all customization vars to makefile prefix ...................................................................... packaging: build: move all customization vars to makefile prefix Change-Id: I57e2748ad6651c746e89dc0f91af1f65a57a3ab0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 51 insertions(+), 44 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57e2748ad6651c746e89dc0f91af1f65a57a3ab0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: rework use of build flags
by oschreib＠redhat.com 18 Jun '13

18 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: rework use of build flags ...................................................................... packaging: build: rework use of build flags construct build flags as late binding and use only one variable in make targets. Change-Id: I9950ba118211f90177185ce7b29c002ca505be61 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M README.developer 2 files changed, 14 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9950ba118211f90177185ce7b29c002ca505be61 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0