- Engine-commits - oVirt List Archives

Change in ovirt-image-uploader[master]: config: added backward compatibilty
by sbonazzo＠redhat.com 18 Jun '13

18 Jun '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword rhevm instead of engine. When reading configurarion files, the user will be warned that there is a deprecated key that needs to be updated. Change-Id: Ic522c278157022b54d449bd4b0d73f9b9a2ce73d Bug-Url: https://bugzilla.redhat.com/975347 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic522c278157022b54d449bd4b0d73f9b9a2ce73d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: config: added backward compatibilty
by sbonazzo＠redhat.com 18 Jun '13

18 Jun '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword rhevm instead of engine. When reading configurarion files, the user will be warned that there is a deprecated key that needs to be updated. Change-Id: I6755c1ad020ee3220aa5f5335c6d66ead5139e57 Bug-Url: https://bugzilla.redhat.com/975209 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6755c1ad020ee3220aa5f5335c6d66ead5139e57 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Manage OS properties in a repository
by ofrenkel＠redhat.com 18 Jun '13

18 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Manage OS properties in a repository ...................................................................... core: Manage OS properties in a repository This is the implementation of the OS info according to http://www.ovirt.org/OS_info This feature enables ovirt to configure all its OS info in one place, out of the code, and in a way admins could extend it or easily configure it. It aims to merge all configuration items from the Config (currently vdc_options table) and the VmOsType.java enum to one file-based repository. This patch contains: * The default repo config file osinfo-defaults.properties * A loading logic to support multiple properties file loading * A Repository which holds an inner tree with all the configuration * A backend query to expose the data to UI Change-Id: I50384bf3b6763fa7a34badc2449e06242186a858 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M Makefile M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/MapBackedPreferences.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImplTest.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsLoader.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoaderTest.java A backend/manager/modules/utils/src/test/resources/osinfo.conf.d/00-osinfo-test.properties A backend/manager/modules/utils/src/test/resources/osinfo.conf.d/10-osinfo-test.properties M ovirt-engine.spec.in A packaging/conf/osinfo-defaults.properties 18 files changed, 1,188 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50384bf3b6763fa7a34badc2449e06242186a858 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Resolve conflict for gluster hook content
by ofrenkel＠redhat.com 18 Jun '13

18 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: Resolve conflict for gluster hook content ...................................................................... gluster: Resolve conflict for gluster hook content While resolving content conflict in gluster hook and user chooses the hook content from one of the server, the hook should be copied on all servers - not just conflicting servers. Change-Id: Ifc2d8ad65af2e019eda0d24b6b1f2f87561c8f73 Bug-Url: https://bugzilla.redhat.com/973137 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java 3 files changed, 37 insertions(+), 12 deletions(-) Approvals: Sahina Bose: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc2d8ad65af2e019eda0d24b6b1f2f87561c8f73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Slightly improve memory size unit relabeling
by tjelinek＠redhat.com 18 Jun '13

18 Jun '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Slightly improve memory size unit relabeling ...................................................................... frontend: Slightly improve memory size unit relabeling When creating a new VM, entering 1G (or 1g) into the Memory Size field, gets changed to '1 MB' after hitting tab instead of '1024 MB'. This patch allows entering suffixes 'm', 'M', 'g' and 'G'. Change-Id: I0006718ead0c7e97bcdc3d4a2827245dc468b554 Bug-Url: https://bugzilla.redhat.com/974379 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/parser/MemorySizeParser.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/15823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0006718ead0c7e97bcdc3d4a2827245dc468b554 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: avoid NPE in AttachDiskToVmCommand
by amureini＠redhat.com 18 Jun '13

18 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: avoid NPE in AttachDiskToVmCommand ...................................................................... core: avoid NPE in AttachDiskToVmCommand if the given disk doesn't exist, NPE will occur. Change-Id: Ifd68475c8f590e24eb5e20423aabba51df2ae33a Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd68475c8f590e24eb5e20423aabba51df2ae33a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: OvfReader- setPlugged for disks
by amureini＠redhat.com 18 Jun '13

18 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader- setPlugged for disks ...................................................................... core: OvfReader- setPlugged for disks When reading disks data of vm from an ovf file, set "plugged" to have the correct value from the ovf. Change-Id: I0a2223533530e84ebe007f64d4e571ca6213d29c Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a2223533530e84ebe007f64d4e571ca6213d29c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: avoid unneeded lock when moving a disk
by amureini＠redhat.com 18 Jun '13

18 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: avoid unneeded lock when moving a disk ...................................................................... core: avoid unneeded lock when moving a disk When moving a disk, as the copy operation ends the engine attempts to delete the source/target images (depending on whether the copy operation has failed or succeeded) - while performing the remove operation the disk shouldn't be locked (in the database) as it's already locked by the parent command. Change-Id: I0fed4563bdb0c245f485e64bcad61f8980e17ebe Signed-off-by: Liron Aravot <laravot(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fed4563bdb0c245f485e64bcad61f8980e17ebe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : call to show files on iso domain no longer shows a...
by mpastern＠redhat.com 18 Jun '13

18 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : call to show files on iso domain no longer shows all files ...................................................................... restapi : call to show files on iso domain no longer shows all files /api/storagedomain/xxx/files does not show all files, only shows iso files. Change-Id: I31d305baaa28e5c0f0b918e497197dbd7b0e496e Bug-Url: https://bugzilla.redhat.com/949261 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendFilesResourceTest.java 2 files changed, 13 insertions(+), 13 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31d305baaa28e5c0f0b918e497197dbd7b0e496e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: change path of console descriptors
by tjelinek＠redhat.com 18 Jun '13

18 Jun '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: change path of console descriptors ...................................................................... engine: change path of console descriptors This patch changes the path from which console descriptors are served (from console/console.* to ovirt-engine-attachment/console.*). The configuration of apache proxy is modified accordingly. Change-Id: Ib35c02a8edb1dd638d4062e4e33854b4df139547 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M packaging/conf/ovirt-engine-proxy.conf.in 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/15727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib35c02a8edb1dd638d4062e4e33854b4df139547 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0