- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove memory image on remove snapshot
by ofrenkel＠redhat.com 16 Jun '13

16 Jun '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove memory image on remove snapshot ...................................................................... core: remove memory image on remove snapshot If snapshot contains memory and it is the only one that contains that memory, remove the memory volumes when removing the snapshot as well. Note that there might be cases where more than one snapshot contain the same memory: 1. when preview snapshot, the memory volume is copied from the snapshot that is being previewed to the active snapshot 2. when running vm in stateless mode, the memory volume is copied to the active snapshot 3. in the future we might support cloning a VM with its memory state (clone from snapshot + import as clone) and the memory would be copied to the cloned VM's snapshots Change-Id: Ib0b4f5306c23046326c9dbb7ef5589b50c88462d Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/dbscripts/snapshots_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java 5 files changed, 150 insertions(+), 25 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0b4f5306c23046326c9dbb7ef5589b50c88462d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: fix incorrect compare of different object types
by mpastern＠redhat.com 16 Jun '13

16 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix incorrect compare of different object types ...................................................................... restapi: fix incorrect compare of different object types Change-Id: Ib206de5b38d95a90766426692e3185554d9bc249 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResource.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib206de5b38d95a90766426692e3185554d9bc249 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RegisterDiskCommand - correct storage domain
by mlipchuk＠redhat.com 16 Jun '13

16 Jun '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RegisterDiskCommand - correct storage domain ...................................................................... core: RegisterDiskCommand - correct storage domain When registering new disk, the disk was saved to the db using the domain information stored on its metadata - this can cause to failure during registration or to have incorrect information stored in the engine db. The domain on which the disk was existed on isn't necessarily the new one on which the disk is now, so it shouldn't be saved with it. The following patch set the saved storage domain to the current one and is part of the complete fix which involves also setting the current id to the image metadata in vdsm. Change-Id: I568668fc1a8024ff255754287afbaa5d35b8a2ed Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RegisterDiskParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/15193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I568668fc1a8024ff255754287afbaa5d35b8a2ed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Chris Morrissey <cmorriss(a)netapp.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi : host_id" and "host_name" are not on the autocomple...
by mpastern＠redhat.com 16 Jun '13

16 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : host_id" and "host_name" are not on the autocompletion list for 'update storagedomain' (#966661) ...................................................................... restapi : host_id" and "host_name" are not on the autocompletion list for 'update storagedomain' (#966661) Autocompletion list for 'update storagedomain' does not show host_id or host_name as one of the options. But one of host id or name is required for update. Change-Id: I676d437597ab8ed2b66ec609d837685d296399ad Bug-Url: https://bugzilla.redhat.com/966661 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I676d437597ab8ed2b66ec609d837685d296399ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Hook ID Comparison - minor code fix
by mpastern＠redhat.com 16 Jun '13

16 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Hook ID Comparison - minor code fix ...................................................................... restapi: Hook ID Comparison - minor code fix Change-Id: I61084b7a1854a63f06820f1cb08de5df23ef38ec Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResourceTest.java 2 files changed, 6 insertions(+), 12 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61084b7a1854a63f06820f1cb08de5df23ef38ec Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: list permits format better error when not enough parame...
by mpastern＠redhat.com 16 Jun '13

16 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: list permits format better error when not enough parameters(#962472) ...................................................................... cli: list permits format better error when not enough parameters(#962472) list permits when executed at cli gives an improper error message as shown below unknown error: not enough arguments for format string Change-Id: I349eb2719c15c0a5c08a31562597f095fd0cd9d1 Bug-Url: https://bugzilla.redhat.com/962472 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/15530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I349eb2719c15c0a5c08a31562597f095fd0cd9d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: Fixing a bug preventing daemons from regaining DB connectivi...
by yzaslavs＠redhat.com 16 Jun '13

16 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Fixing a bug preventing daemons from regaining DB connectivity ...................................................................... Fixing a bug preventing daemons from regaining DB connectivity If db connectivity is down, closeConnection in checkConnection will set connection null. From that point on, on each call to checkConnectivity a NPE will be thrown. Fix: If connection is null attempt to open it, this way: 1.) if db goes back up we will regain connectivity. 2.) if db does not come back up we will have a proper sqlException in the log thrown from openConnection, and not a NPE. Change-Id: Ia8dc7eb95e055e793f51155cd4024ebf5ce1914a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=973534 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8dc7eb95e055e793f51155cd4024ebf5ce1914a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: reuse code in StorageListModel
by derez＠redhat.com 16 Jun '13

16 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: reuse code in StorageListModel ...................................................................... webadmin: reuse code in StorageListModel Reuse handling of existing storage domains in StorageListModel by extracting the code to a separate method. Change-Id: I6f7d66790659150abd358a2cf00410c7fa3bd6a0 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 13 insertions(+), 24 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f7d66790659150abd358a2cf00410c7fa3bd6a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: move image group command
by mlipchuk＠redhat.com 16 Jun '13

16 Jun '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: move image group command ...................................................................... core: move image group command Added MoveImageGroupCommand - making MoveOrCopyImageGroup command to be used for copy only (CopyImageGroup). Reasons for that change: 1. When moving an image and attempting to delete with wipe - the operation will be faster rather then waiting for the wipe to complete. 2. Moving towards lowering the SPM involvement in the copy/move process. 3. The engine will be able to tell on which part of the "move" operation an error has occured. 4. Move operation on vdsm should be deprecated. Known issues and reasoning: * The whole operation might be slower for moving image groups without wipe as the delete part is quick (and now we will have two vdsm calls rather then one) - this issue is known and accepted as part of this RFE. Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706 Bug-Url: https://bugzilla.redhat.com/753549 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageDbOperationScope.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 20 files changed, 157 insertions(+), 48 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/13042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: reorder super constructor invocation in ordereddict
by mpastern＠redhat.com 16 Jun '13

16 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: reorder super constructor invocation in ordereddict ...................................................................... sdk: reorder super constructor invocation in ordereddict this way lock objects will be available for any type of the dict initialization Change-Id: I0e63d81f2de810de334e4944f9004f9d14aa9877 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/utils/ordereddict.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e63d81f2de810de334e4944f9004f9d14aa9877 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0