- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add missing sound card for imported vm
by ofrenkel＠redhat.com 12 May '13

12 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add missing sound card for imported vm ...................................................................... core: add missing sound card for imported vm This patch solves a bug in which when importing desktop vm that doesn't have sound card device (which is the case when importing vm that was created in 3.0 for example), the resulting vm won't have sound device. The solution is to check the imported vm and if it is desktop vm and it doesn't have sound device, we add sound device to it. Change-Id: I295d158f014f865be5a03f630ce48ba446752e5e Bug-Url: https://bugzilla.redhat.com/955498 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 24 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295d158f014f865be5a03f630ce48ba446752e5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: re-write using otopi
by oschreib＠redhat.com 12 May '13

12 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: re-write using otopi ...................................................................... packaging: setup: re-write using otopi OUTLINE We introduce a complete rewrite of ovirt-engine setup, which includes engine-setup, engine-upgrade, engine-cleanup. The new implementation is installed side-by-side, user may have a choice which implementation to use. COMPATIBILITY Implementation are incompatible, once setup using legacy, upgrade and cleanup will not work using the new implementation and vise versa. Answer file is not compatible between implementations. Implementation is not feature complete, setup is almost complete, cleanup needs more work to clean files that where partially modified, currently, setup is not able to upgrade non-new implementation setup. MAJOR FEATURES Fully support development environment installation. Up until now, developers had maintained parallel environment, manually customized, partial featured. Now, developers may setup product much like production using unprivileged user, custom location and custom database. For more information refer to README.developer file. Platform independent implementation The new implementation can/should be able to run in multiple distributions, setting up valid engine environment. So far tested fedora, rhel, centos, gentoo, ubuntu. Database access Split between host provisioning and database setup. Host provisioning is the part setup can configure the database package on host to be able to serve the application. The provisioning phase is now completely optional and is supported only at legacy distributions. Database setup is the part that a schema is created in existing database. This enables the dba to provide ovirt administration unprivileged database user and database for his use. Implementation Pluggable, mission centric, consistent, modern, customizable implementation. Reuse the otopi infrastructure that is also used for host-deploy, and future reuse of setup for dwh and reports components. Localization ready. Change-Id: Id587977be496f979f692ee5fd06a4e264d3f9197 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=911191 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M .gitignore M Makefile A README.developer M ovirt-engine.spec.in A packaging/check.sh A packaging/setup/bin/ovirt-engine-remove A packaging/setup/bin/ovirt-engine-setup A packaging/setup/bin/ovirt-engine-setup.env A packaging/setup/ovirt_engine_setup/__init__.py A packaging/setup/ovirt_engine_setup/config.py.in A packaging/setup/ovirt_engine_setup/constants.py A packaging/setup/ovirt_engine_setup/database.py A packaging/setup/ovirt_engine_setup/dialog.py A packaging/setup/ovirt_engine_setup/domains.py A packaging/setup/ovirt_engine_setup/util.py A packaging/setup/plugins/ovirt-engine-common/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/core/answerfile.py A packaging/setup/plugins/ovirt-engine-common/core/engine.py A packaging/setup/plugins/ovirt-engine-common/core/misc.py A packaging/setup/plugins/ovirt-engine-common/core/offlinepackager.py A packaging/setup/plugins/ovirt-engine-common/db/__init__.py A packaging/setup/plugins/ovirt-engine-common/db/connection.py A packaging/setup/plugins/ovirt-engine-common/system/__init__.py A packaging/setup/plugins/ovirt-engine-common/system/hostile_services.py A packaging/setup/plugins/ovirt-engine-remove/core/__init__.py A packaging/setup/plugins/ovirt-engine-remove/core/misc.py A packaging/setup/plugins/ovirt-engine-remove/db/__init__.py A packaging/setup/plugins/ovirt-engine-remove/db/clear.py A packaging/setup/plugins/ovirt-engine-remove/files/__init__.py A packaging/setup/plugins/ovirt-engine-remove/files/simple.py A packaging/setup/plugins/ovirt-engine-setup/all-in-one/__init__.py A packaging/setup/plugins/ovirt-engine-setup/all-in-one/core.py A packaging/setup/plugins/ovirt-engine-setup/all-in-one/cpu.py A packaging/setup/plugins/ovirt-engine-setup/all-in-one/firewall.py A packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py A packaging/setup/plugins/ovirt-engine-setup/all-in-one/storage.py A packaging/setup/plugins/ovirt-engine-setup/all-in-one/super_user.py A packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py A packaging/setup/plugins/ovirt-engine-setup/apache/__init__.py A packaging/setup/plugins/ovirt-engine-setup/apache/core.py A packaging/setup/plugins/ovirt-engine-setup/apache/ovirt_engine.py A packaging/setup/plugins/ovirt-engine-setup/apache/root.py A packaging/setup/plugins/ovirt-engine-setup/apache/selinux.py A packaging/setup/plugins/ovirt-engine-setup/apache/ssl.py A packaging/setup/plugins/ovirt-engine-setup/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/config/appmode.py A packaging/setup/plugins/ovirt-engine-setup/config/ca.py A packaging/setup/plugins/ovirt-engine-setup/config/database.py A packaging/setup/plugins/ovirt-engine-setup/config/domain_type.py A packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py A packaging/setup/plugins/ovirt-engine-setup/config/java.py A packaging/setup/plugins/ovirt-engine-setup/config/jboss.py A packaging/setup/plugins/ovirt-engine-setup/config/macrange.py A packaging/setup/plugins/ovirt-engine-setup/config/options.py A packaging/setup/plugins/ovirt-engine-setup/config/protocols.py A packaging/setup/plugins/ovirt-engine-setup/config/tools.py A packaging/setup/plugins/ovirt-engine-setup/core/__init__.py A packaging/setup/plugins/ovirt-engine-setup/core/misc.py A packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py A packaging/setup/plugins/ovirt-engine-setup/db/__init__.py A packaging/setup/plugins/ovirt-engine-setup/db/connection.py A packaging/setup/plugins/ovirt-engine-setup/db/schema.py A packaging/setup/plugins/ovirt-engine-setup/dialog/__init__.py A packaging/setup/plugins/ovirt-engine-setup/dialog/preview.py A packaging/setup/plugins/ovirt-engine-setup/dialog/titles.py A packaging/setup/plugins/ovirt-engine-setup/distro-rpm/__init__.py A packaging/setup/plugins/ovirt-engine-setup/distro-rpm/image_upload.py A packaging/setup/plugins/ovirt-engine-setup/distro-rpm/versionlock.py A packaging/setup/plugins/ovirt-engine-setup/network/__init__.py A packaging/setup/plugins/ovirt-engine-setup/network/firewall.py A packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py A packaging/setup/plugins/ovirt-engine-setup/network/firewalld.py A packaging/setup/plugins/ovirt-engine-setup/pki/__init__.py A packaging/setup/plugins/ovirt-engine-setup/pki/ca.py A packaging/setup/plugins/ovirt-engine-setup/pki/ssh.py A packaging/setup/plugins/ovirt-engine-setup/provisioning/__init__.py A packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py A packaging/setup/plugins/ovirt-engine-setup/system/__init__.py A packaging/setup/plugins/ovirt-engine-setup/system/environment.py A packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py A packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py A packaging/setup/plugins/ovirt-engine-setup/system/nfs.py A packaging/setup/plugins/ovirt-engine-setup/system/selinux.py A packaging/setup/plugins/ovirt-engine-setup/system/sysctl.py 84 files changed, 10,839 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id587977be496f979f692ee5fd06a4e264d3f9197 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Method with Boolean return explicit null
by shavivi＠redhat.com 12 May '13

12 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Method with Boolean return explicit null ...................................................................... findbugs: Method with Boolean return explicit null Change-Id: Ibe28d8e00e2597cdbfd59c0acbb3c7dd8d08c99a Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe28d8e00e2597cdbfd59c0acbb3c7dd8d08c99a Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Boxed value is unboxed and then immediately reboxe...
by shavivi＠redhat.com 12 May '13

12 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Boxed value is unboxed and then immediately reboxed ...................................................................... findbugs: Boxed value is unboxed and then immediately reboxed Change-Id: I28465ef80d706a5e8c08b3e3a92bd00f4a7de94f Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28465ef80d706a5e8c08b3e3a92bd00f4a7de94f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "restapi : AttachNetworkToVdsGroupCommand HTTP Status...
by mpastern＠redhat.com 12 May '13

12 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: Revert "restapi : AttachNetworkToVdsGroupCommand HTTP Status 500 - java.lang.NullPointerException(#961046)" ...................................................................... Revert "restapi : AttachNetworkToVdsGroupCommand HTTP Status 500 - java.lang.NullPointerException(#961046)" Reverting this change since: 38 String networkId = getNetworkId(network.getName(), clusterId); 39 network.setId(getNetworkId(network.getName(), clusterId)); 39 if (networkId == null) { 40 return handleError(Response.class, new BackendFailureException( 41 "Bad network name: "+network.getName()), false); here should be returned 404 error by not found 42 } 43 if (!network.isSetId()) { 44 network.setId(networkId); 45 } 46 else if (!network.getId().equals(networkId)) { 47 return handleError(Response.class, new BackendFailureException( 48 "Network id provided does not match the id for network with name: "+ 49 network.getName()), false); this is backend logic 40 } 50 } This reverts commit 0888726b8e5c39cacaefd5af9242513507d86292. Change-Id: I57ff677b72b82def25279b15e2d0c31bf70ffa7b Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResourceTest.java 2 files changed, 21 insertions(+), 30 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57ff677b72b82def25279b15e2d0c31bf70ffa7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : AttachNetworkToVdsGroupCommand HTTP Status 500 - j...
by mpastern＠redhat.com 12 May '13

12 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : AttachNetworkToVdsGroupCommand HTTP Status 500 - java.lang.NullPointerException(#961046) ...................................................................... restapi : AttachNetworkToVdsGroupCommand HTTP Status 500 - java.lang.NullPointerException(#961046) The server throws an internal server error when add network command is executed with invalid network name Change-Id: Ie0102d1d36de7012ebd98c53ef8eb106ac7b04b7 Bug-Url: https://bugzilla.redhat.com/961046 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResourceTest.java 2 files changed, 30 insertions(+), 21 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0102d1d36de7012ebd98c53ef8eb106ac7b04b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactoring AddVdsCommand#canDoAction()
by sanjal＠redhat.com 10 May '13

10 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Refactoring AddVdsCommand#canDoAction() ...................................................................... engine: Refactoring AddVdsCommand#canDoAction() to use failCanDoAction(), saving few lines of code. Also made sure that the gluster specific validation happens only if all previous validation was successful. Change-Id: Id2525aa9ce72654fea18eb60948a87d95a636602 Signed-off-by: Shireesh Anjal <anjalshireesh(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 10 insertions(+), 17 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2525aa9ce72654fea18eb60948a87d95a636602 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : power management types are not updated
by mpastern＠redhat.com 09 May '13

09 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: core : power management types are not updated ...................................................................... core : power management types are not updated Power management types from rest api and admin portal dont match. The rest api does not values from database. Change-Id: Ibd1f82f1508ff1c2f1148692b49b47c535dbbaa1 Bug-Url: https://bugzilla.redhat.com/955573 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd1f82f1508ff1c2f1148692b49b47c535dbbaa1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : if "filter: ..." header is set, use query instead ...
by mpastern＠redhat.com 09 May '13

09 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : if "filter: ..." header is set, use query instead of search to list items ...................................................................... restapi : if "filter: ..." header is set, use query instead of search to list items When the filter option is specified the api query should not throw a insufficient permissions exception. Instead the query should return a list of objects that the user has permissions for. This patch fixes /events/{id} Change-Id: Ia2ab0e1e62b9cc67fad51da5e5e0b2c1163087a6 Bug-Url: https://bugzilla.redhat.com/869334 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2ab0e1e62b9cc67fad51da5e5e0b2c1163087a6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Reverting the execution of encodingvalidator
by juan.hernandez＠redhat.com 09 May '13

09 May '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Reverting the execution of encodingvalidator ...................................................................... packaging: Reverting the execution of encodingvalidator This patch removes execution of the encodingvalidator utility on upgrade and restores running validators with SERVER_ADMIN permissions. Change-Id: Iabb320fd8d4df8b2a3f943a98dd3309469c730b7 Bug-Url: https://bugzilla.redhat.com/893459 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M backend/manager/tools/dbutils/validatedb.sh M packaging/fedora/setup/engine-upgrade.py 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabb320fd8d4df8b2a3f943a98dd3309469c730b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0