- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: changed Spice to SPICE
by tjelinek＠redhat.com 09 May '13

09 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: changed Spice to SPICE ...................................................................... userportal: changed Spice to SPICE Removed the hardcoded Spice string from ConsoleProtocol. Change-Id: I7e610d12a2966ccff81e722d41c3bcde4c6a4be7 Bug-Url: https://bugzilla.redhat.com/876900 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleProtocol.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java 2 files changed, 21 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e610d12a2966ccff81e722d41c3bcde4c6a4be7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: updated unattended upgrade mode
by oschreib＠redhat.com 09 May '13

09 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: updated unattended upgrade mode ...................................................................... packaging: updated unattended upgrade mode This patch provides an option for the upgrade utility that allows running a DB fix mode automatically. Bug-Url: https://bugzilla.redhat.com/893459 Change-Id: Ie8f64a8369633562e4b919cb64c80793c194bff9 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8f64a8369633562e4b919cb64c80793c194bff9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Rename validation method for clarification
by masayag＠redhat.com 09 May '13

09 May '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Rename validation method for clarification ...................................................................... engine: Rename validation method for clarification Change-Id: I9cecab62cd90cde99422aa91c372e58a30e0c9b4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cecab62cd90cde99422aa91c372e58a30e0c9b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: RDP doesn't pass clipboard
by tjelinek＠redhat.com 09 May '13

09 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: RDP doesn't pass clipboard ...................................................................... frontend: RDP doesn't pass clipboard This patch enables RDP clipboard passing. Change-Id: I01a07345a45f344a3218860bde023532e40d46c4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=909270 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpConnector.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01a07345a45f344a3218860bde023532e40d46c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: drop the obfuscation of database password
by yzaslavs＠redhat.com 09 May '13

09 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: db: drop the obfuscation of database password ...................................................................... db: drop the obfuscation of database password fill up the /etc/ovirt-engine/engine.conf.d/10-setup-database.conf with all database parameters as distinct parameters, to ease future read. Change-Id: I1da760e32ddef238324fe9889c1675de518d0c64 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958532 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java M ovirt-engine.spec.in D packaging/bin/engine-encrypt-passwd.sh M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py M packaging/services/ovirt-engine.xml.in 8 files changed, 68 insertions(+), 107 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1da760e32ddef238324fe9889c1675de518d0c64 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Installer pre-upgrade step should ensure...
by yzaslavs＠redhat.com 08 May '13

08 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Installer pre-upgrade step should ensure... ...................................................................... core: Installer pre-upgrade step should ensure... Installer pre-upgrade step should ensure DB consistency using fkvalidator.sh Fixing a problem in fkvalidator when the child table has a value that not exists in the parent table but this value is null. In that case fkvalidaor should not treat that data as a violation. Change-Id: Id76d9c3e3d619ac591a334b481c8af9ca675af9e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=893459 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/tools/dbutils/fkvalidator_sp.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id76d9c3e3d619ac591a334b481c8af9ca675af9e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: ovirt-engine-3.2.2-1.1
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.2.2-1.1 ...................................................................... packaging: ovirt-engine-3.2.2-1.1 Updated ovirt-engine-3.2.2 rpm release to 1.1 Change-Id: I023d02ec2723b84897202b73c93c39474e4908c6 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I023d02ec2723b84897202b73c93c39474e4908c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated DB validation flow.
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated DB validation flow. ...................................................................... packaging: Updated DB validation flow. This patch is an addition to http://gerrit.ovirt.org/#/c/14389. It updates the parameters handling in encodingvalidator utility. Also, it updates calling the validation utilities with an admin user (postgres) instead of engine. Change-Id: I34c87815bd667d80f3691ae4a2533523bfa89f29 Bug-Url: https://bugzilla.redhat.com/920565 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M backend/manager/tools/dbutils/encodingvalidator.sh M packaging/fedora/setup/engine-upgrade.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Alex Lourie: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34c87815bd667d80f3691ae4a2533523bfa89f29 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: protect configuration files
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: protect configuration files ...................................................................... packaging: engine-service: protect configuration files we need to protect configuration files as database password resides within. for some reason jboss changes the permissions of configuration file and deployment to 0777, enforcing umask of 0027 perform some remedy at the price of having logs not world readable as well, so it is not a solution. luckily, jboss does not modify the directory in which configuration file resides, so we split the configuration directory to own directory and set proper permissions. Change-Id: Ie76e5ffcdccd8c3a0bedbb9ce9bd56e146eeccd9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine.py M packaging/services/service.py 2 files changed, 34 insertions(+), 19 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie76e5ffcdccd8c3a0bedbb9ce9bd56e146eeccd9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove vm - remove VM during execute
by amureini＠redhat.com 08 May '13

08 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove vm - remove VM during execute ...................................................................... core: remove vm - remove VM during execute When removing vm the operation is done as synchronized operation, task is created for each disk and then the vm is removed from db. In order to deal with engine crash, in the end method a roll forward is performed in case that the vm still exists (the vm is being deleted and it's disks are being marked as illegal). This logic is unneeded and can cause to a bug, in case of deleted vm and imported vm with the same id, this can cause that the imported vm would be deleted from the db as the deletion tasks would end - therefore this logic is being removed. this patch contains the following changes: 1. the first step is to remove the vm, lock all the disks - in case of failure they will be in ILLEGAL status. 2. added a boolean member indicating whether RemoveImage should lock the image. 3. RemoveAllVmImages shouldn't fail in case of failure to create a task for deletion, the engine should continue and try to delete the other images- this change also prevents a storage leak in removing vm and templates from export domains. 4. RemoveAllVmImages returns a list of disks it failed to remove, instead of querying the db again. Change-Id: I7a3e497e52471f7255e6c17b59a2e3bf362b8783 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 6 files changed, 47 insertions(+), 78 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a3e497e52471f7255e6c17b59a2e3bf362b8783 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0