- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: BaseAutoCompleter.getCompletion() array size
by amureini＠redhat.com 24 Feb '13

24 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: BaseAutoCompleter.getCompletion() array size ...................................................................... core: BaseAutoCompleter.getCompletion() array size Used the proper way to convert a List to an array in BaseAutoCompleter.getCompletion(), for better performance. Change-Id: I0e699a3307e05694f5456282b07e95cf22332d44 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseAutoCompleter.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e699a3307e05694f5456282b07e95cf22332d44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: StorageListModel - remove unused local vars
by amureini＠redhat.com 24 Feb '13

24 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: ui: StorageListModel - remove unused local vars ...................................................................... ui: StorageListModel - remove unused local vars Removed unused local variables. Change-Id: I4573cb9136437eddb2e7a737fa12496cf4006924 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4573cb9136437eddb2e7a737fa12496cf4006924 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: ModelListTreeViewModel - unused var
by amureini＠redhat.com 24 Feb '13

24 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: ModelListTreeViewModel - unused var ...................................................................... webadmin: ModelListTreeViewModel - unused var Removed the unused local variable nullSet. Change-Id: I1f15ba4ef12d520b8cda43e200640e282b67aee4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ModelListTreeViewModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f15ba4ef12d520b8cda43e200640e282b67aee4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: AsyncDataProvier - remove unused local vars
by amureini＠redhat.com 24 Feb '13

24 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: ui: AsyncDataProvier - remove unused local vars ...................................................................... ui: AsyncDataProvier - remove unused local vars Removed unused local variables from AsyncDataProvider's functions. Change-Id: I63323233803ee08b3242f4a40fab62eeedd53153 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 4 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63323233803ee08b3242f4a40fab62eeedd53153 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfVmWriterTest.assertVm cleanup
by amureini＠redhat.com 24 Feb '13

24 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfVmWriterTest.assertVm cleanup ...................................................................... core: OvfVmWriterTest.assertVm cleanup Fixed the method's modifiers and removed a commented out line. Change-Id: I65c7d797a725626adb7bd67f1f73f8084b803daf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfVmWriterTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65c7d797a725626adb7bd67f1f73f8084b803daf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove useless null check
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove useless null check ...................................................................... webadmin: Remove useless null check Remove a useless null check from VdcQueryReturnValue_CustomFieldSerializer's serialize and deserialize methods. nulls are checked explicitly in the begging of the respective functions, so it cannot be null at their ends. Change-Id: I5a14e8a8705cdd3be8ea24b6da7288bedb01a453 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a14e8a8705cdd3be8ea24b6da7288bedb01a453 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: NlsCheck - unwrap else clause
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: build: NlsCheck - unwrap else clause ...................................................................... build: NlsCheck - unwrap else clause Unwrapped a useless else clause, since the if clause does not terminate properly (it returns from the function). Change-Id: Ie0d43d0402f948dd5f0c45279fc19a2997d7f27b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d43d0402f948dd5f0c45279fc19a2997d7f27b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: NlsCheck - proper inner class
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: build: NlsCheck - proper inner class ...................................................................... build: NlsCheck - proper inner class Made the inner class QuotedString private static, as it is not used outside this class and does not require access to the enclosing class' members. Also removed the redundant semicolon at the end of the declaration. Change-Id: I749db5319b56c90925a2a78385a6c722c58f7688 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I749db5319b56c90925a2a78385a6c722c58f7688 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DbFacadeUtils basic Java cleanup
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DbFacadeUtils basic Java cleanup ...................................................................... core: DbFacadeUtils basic Java cleanup Some basic Java cleanup - removed useless commit message, added braces, and replaced FQCN with import. Change-Id: I55f89c0684ca67813c6cdfde1c3a938368c13a88 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeUtils.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f89c0684ca67813c6cdfde1c3a938368c13a88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up exception in AuditLogDirectorTest
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Clean up exception in AuditLogDirectorTest ...................................................................... core: Clean up exception in AuditLogDirectorTest Fixed an Exception being printed in AuditLgDirectorTest, caused by the underlying AuditLogableBase trying to access DbFacade. Change-Id: I4ad2abc7c83bf199fc12d35a857cc44322cce0aa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ad2abc7c83bf199fc12d35a857cc44322cce0aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0