- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix NPE in AuditLogableBaseTest
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix NPE in AuditLogableBaseTest ...................................................................... core: Fix NPE in AuditLogableBaseTest AuditLogableBaseTest would print an annoying NullPointerException stacktrace due to getVm() trying to access VmNetworkInterfaceDao in getVm(). This patch adds a mock for that DAO (with no additional behavior, as to not change the test's semantics) to avoid this annoying output. Change-Id: I24940142c12e0259544f3e3cb8bc8bd8ca2c2cfa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24940142c12e0259544f3e3cb8bc8bd8ca2c2cfa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up Version.OpEquality
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Clean up Version.OpEquality ...................................................................... core: Clean up Version.OpEquality Proper handling of boolean values in OpEquality. Change-Id: Ib09be089763a101ff77e2bbf32970af827cd38df Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib09be089763a101ff77e2bbf32970af827cd38df Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: PropertyInfo method name
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: PropertyInfo method name ...................................................................... core: PropertyInfo method name Changes PropertyInfo' GetValue method to getValue, as per Java conventions. Change-Id: If29777eb963eeba10473ab0e2638ff80561549f9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If29777eb963eeba10473ab0e2638ff80561549f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix log modifiers in PropretyInfo
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix log modifiers in PropretyInfo ...................................................................... core: Fix log modifiers in PropretyInfo Fixed PropertyInfo's log to have correct modifiers, as per Java conventions. Change-Id: I0a3195d219d601065462f9ecc8a0c467e7561345 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a3195d219d601065462f9ecc8a0c467e7561345 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove PropertyCompat
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove PropertyCompat ...................................................................... core: Remove PropertyCompat PropertyCompat was an empty extension to PropertyInfo, with no additional logic of it's own, and hence pretty redundant. This patch removes it, replaces the single place it was used (TypeCompat) with PropertyInfo and renames the test accordingly. Change-Id: I21cfe23038e2647ee7ce816b532cb28f067ac826 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java R backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java 3 files changed, 7 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21cfe23038e2647ee7ce816b532cb28f067ac826 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: JUnit 4 style for PropertyCompatTest
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: JUnit 4 style for PropertyCompatTest ...................................................................... core: JUnit 4 style for PropertyCompatTest Fixed PropertyCompatTest to use JUnit 4 style instead of JUnit 3 style - stopped extending TestCase and added @Test annotations. Change-Id: I7d3ee0866a05301f354e366a046197b465796d1c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyCompatTest.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d3ee0866a05301f354e366a046197b465796d1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: TypeCompat - make log final
by amureini＠redhat.com 22 Feb '13

22 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: TypeCompat - make log final ...................................................................... core: TypeCompat - make log final Fixed the log's modifiers, as per proper Java conventions. Change-Id: Ia540ae7e42ad7a5315d02b46bba12cc5e6e8d5e5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia540ae7e42ad7a5315d02b46bba12cc5e6e8d5e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Add beanutils as dependency of utils
by juan.hernandez＠redhat.com 22 Feb '13

22 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Add beanutils as dependency of utils ...................................................................... packaging: Add beanutils as dependency of utils This is needed by the OVF related code. Change-Id: I633a0a3b4762b808fad9a2bf047889bde37b17f1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Federico Simoncelli: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I633a0a3b4762b808fad9a2bf047889bde37b17f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Use JBoss modules instead of class path
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: tools: Use JBoss modules instead of class path ...................................................................... tools: Use JBoss modules instead of class path Currently in order to run the tools we build the class path using mostly the "build-classpath" script and also some ad hoc searches. This tends to fail in environments where the jar files are installed in locations different than expected. This patch changes the scripts that starts the tools so that they use the JBoss modules launcher instead, thus manual class path building is no longer required. Change-Id: Id3e4f7a4bd9a3b31ceb453f9257b2ad8eaf03f5a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-config.sh M backend/manager/tools/src/main/shell/engine-manage-domains.sh M backend/manager/tools/src/main/shell/engine-notifier.sh M backend/manager/tools/src/main/shell/engine-prolog.sh.in 4 files changed, 61 insertions(+), 93 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3e4f7a4bd9a3b31ceb453f9257b2ad8eaf03f5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add jxpath as commons-configuration dep
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Add jxpath as commons-configuration dep ...................................................................... core: Add jxpath as commons-configuration dep The commons-configuration module provided by JBoss AS doesn't include commons-jxpath as a dependency, but engine-config needs it in order to parse configuration files, so we need to add a module for commons-jxpath and also override the commons-configuration module to include the dependency on commons-jxpath. Change-Id: I30b0ecc441062670b501d0e9bda1a23639919b5e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/apache/commons/configuration/main/module.xml A backend/manager/dependencies/src/main/modules/org/apache/commons/jxpath/main/module.xml 3 files changed, 69 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30b0ecc441062670b501d0e9bda1a23639919b5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0