- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add JBoss modules for libraries
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Add JBoss modules for libraries ...................................................................... core: Add JBoss modules for libraries This patch creates JBoss modules for the common, compat, dal, utils, tooks and searchbackend libraries. Change-Id: Ia14b6488b876ccc364d28b2355ccf6e8772b0627 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/modules/common/pom.xml A backend/manager/modules/common/src/main/modules/org/ovirt/engine/core/common/main/module.xml M backend/manager/modules/compat/pom.xml A backend/manager/modules/compat/src/main/modules/org/ovirt/engine/core/compat/main/module.xml M backend/manager/modules/dal/pom.xml A backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/searchbackend/pom.xml A backend/manager/modules/searchbackend/src/main/modules/org/ovirt/engine/core/searchbackend/main/module.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EngineEJBUtilsStrategy.java A backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M backend/manager/tools/pom.xml A backend/manager/tools/src/main/modules/org/ovirt/engine/core/tools/main/module.xml M ear/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M packaging/fedora/spec/ovirt-engine.spec.in M pom.xml 22 files changed, 304 insertions(+), 156 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia14b6488b876ccc364d28b2355ccf6e8772b0627 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: simplify VDSGroup.equals()
by dfediuck＠redhat.com 21 Feb '13

21 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: simplify VDSGroup.equals() ...................................................................... core: simplify VDSGroup.equals() Instead of manually doing a null-safe comparison for each VDSGroup object, use ObjectUtils.objectsEqual(). Also, optimize the order of comparison by looking at the id field first. Change-Id: Iecd1e2314d2791764a4c3456fe21fc7931fe224d Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java 1 file changed, 20 insertions(+), 94 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecd1e2314d2791764a4c3456fe21fc7931fe224d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: engine-iso-uploader - small usage's output change
by kroberts＠redhat.com 21 Feb '13

21 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: engine-iso-uploader - small usage's output change ...................................................................... engine-iso-uploader - small usage's output change The usage printed to the screen now says that upload option requires FILE as mandatory parameter. Change-Id: Ibf303445c4035589322d2b69dbed8d00d11a64f8 Bug-Url: https://bugzilla.redhat.com/785670 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf303445c4035589322d2b69dbed8d00d11a64f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: make /export preserved name
by mpastern＠redhat.com 21 Feb '13

21 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: make /export preserved name ...................................................................... codegen: make /export preserved name Change-Id: I96072237f92f9d2cfc56ac576e1b3102388e9fca Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96072237f92f9d2cfc56ac576e1b3102388e9fca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Move dependencies to a JBoss module
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Move dependencies to a JBoss module ...................................................................... packaging: Move dependencies to a JBoss module Currently we package dependencies as .jar files in the lib directories of the .ear and in the .war of RESTAPI. This has the inconvenient that those dependencies don't have an associated artifact and also can't be shared from different applications. This patch moves all those dependencies to the dependencies jboss module, so that they are added to the corresponding artifact, and can then be easily installed and shared. Change-Id: I82a775915f4b2066ef14961cf69c2a35d0673133 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/ovirt/engine/core/dependencies/main/module.xml M backend/manager/modules/restapi/webapp/pom.xml M ear/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF M packaging/fedora/spec/ovirt-engine.spec.in 6 files changed, 367 insertions(+), 250 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82a775915f4b2066ef14961cf69c2a35d0673133 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: add timestamps to engine-db-install logs
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: add timestamps to engine-db-install logs ...................................................................... packaging: add timestamps to engine-db-install logs Added new function logmsg that add a timestamp to the message that will be logged. Refactored the code for using logmsg for writing log messages. Change-Id: I2ed2bfd889da31ee4626365653d9ea2dee37fd9f Bug-Url: https://bugzilla.redhat.com/885611 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dbscripts/engine-db-install.sh 1 file changed, 30 insertions(+), 22 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ed2bfd889da31ee4626365653d9ea2dee37fd9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: changed psql parser in engine-upgrade.getCompensa...
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: changed psql parser in engine-upgrade.getCompensations ...................................................................... packaging: changed psql parser in engine-upgrade.getCompensations In engine-upgrade getCompensations previously parsed the output of psql searching for "0 rows" as flag for "no records found" and failed on locale like Italian where it is "0 righe". It also avoid to do the wrong thing if it contains a string like "10 rows". Now the parser doesn't rely on a localized string for detecting an empty set. Change-Id: I397d609fce6826e02b0f409e81228fe7d9d7be0a Bug-Url: https://bugzilla.redhat.com/912426 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I397d609fce6826e02b0f409e81228fe7d9d7be0a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: allow importing ISO domain on setup, exports.d su...
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: allow importing ISO domain on setup, exports.d support ...................................................................... packaging: allow importing ISO domain on setup, exports.d support moved the private function engine_validators._isPathInExportFs to common_utils.isPathInExportFs and made it public. isPathInExportFs previously redefined the built-in file, I've fixed it. engine_validators.validateMountPoint now accept an existing ISO domain as a valid path even if it's already exported allowing the user to re-import it. engine-setup._configNfsShare need to add the ISO domain path to /etc/exports only if it is not already there. If /etc/exports.d exists, then /etc/exports.d/ovirt-engine-iso-domain.exports will be used instead of /etc/exports and in this case existing configuration will be migrated to /etc/exports.d/ovirt-engine-iso-domain.exports as well. engine-setup._configNfsShare generate a new uuid and create a new domain only if it doesn't already exists in the supplied domain path. nfsutils.cleanNfsExports refactored taking advantage of the new private method _updateNfsExports. engine-cleanup: add support for /etc/exports.d Change-Id: I3a4343f8374e6439b0ee0a14fff233a0d4a0d5a3 Bug-Url: https://bugzilla.redhat.com/904149 Bug-Url: https://bugzilla.redhat.com/907899 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/nfsutils.py 6 files changed, 135 insertions(+), 37 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a4343f8374e6439b0ee0a14fff233a0d4a0d5a3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Send Bonded Network with bonding
by msalem＠redhat.com 21 Feb '13

21 Feb '13

Muli Salem has submitted this change and it was merged. Change subject: core: Send Bonded Network with bonding ...................................................................... core: Send Bonded Network with bonding This patch locates the underlying interface that the changed network is defined on and sends bonding type instead of nic, if the interface is a bond. In case we changed from a vlan network over a bond to a non-vlan network over a bond, we need to look up the interface using the interface name after stripping the vlan off of it. This may be the case even if the target network is not a vlan, since the source network was a vlan network. Change-Id: Ifa48513b89ba7a972826d31d7fc65ee5898d5741 Bug-Url: https://bugzilla.redhat.com/909678 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa48513b89ba7a972826d31d7fc65ee5898d5741 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactor SetupNetworksVdsCommand
by msalem＠redhat.com 21 Feb '13

21 Feb '13

Muli Salem has submitted this change and it was merged. Change subject: core: Refactor SetupNetworksVdsCommand ...................................................................... core: Refactor SetupNetworksVdsCommand This patch refactors the block of code that generate networks that were modified. for sending to Vdsm. Change-Id: Ic12d9c601dad77f77808bbec46271ea675509530 Bug-Url: https://bugzilla.redhat.com/909678 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 33 insertions(+), 29 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic12d9c601dad77f77808bbec46271ea675509530 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0