- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Updated the skipTests instruction for mvn build
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated the skipTests instruction for mvn build ...................................................................... packaging: Updated the skipTests instruction for mvn build Replaced maven.test.skip=true in rpm-quick make target with the more correct skipTests=true. Change-Id: If506bcdedb064a10675f5f838e75d17e9c0cdcd4 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If506bcdedb064a10675f5f838e75d17e9c0cdcd4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com 21 Feb '13

21 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - to cluster added tunnel_migration property - to DataCenter added Clusters sub-collection - to root collection resource Disk added Permissions sub-collectio - to root collection resource Disk added Statistic sub-collection - host can be attached to cluster now either by id or name - to StorageDomainTemplate added Disks sub-collection - to StorageDomainVM added Disks sub-collection - to template.display added keyboard_layout property - to template added tunnel_migration property - to vm.display added keyboard_layout property - to vm added tunnel_migration property - to VMSnapshot added preview method - to VMSnapshot added undo method - to VMSnapshot added commit method Change-Id: Ic645cc6fe5eecd5a8529e842049f696f2acc6f70 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ApiTemplate M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterCluster.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolume.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrick.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBricks.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumes.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetwork.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetworks.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterPermission.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterPermissions.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusters.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermissions.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskStatistics.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplate.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplateDisk.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplateDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVM.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVMDisk.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVMDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshot.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Cluster.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Display.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VM.java 34 files changed, 3,835 insertions(+), 1,273 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic645cc6fe5eecd5a8529e842049f696f2acc6f70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: refactor ApiTemplate to comply with latest changes
by mpastern＠redhat.com 21 Feb '13

21 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: refactor ApiTemplate to comply with latest changes ...................................................................... codegen: refactor ApiTemplate to comply with latest changes Change-Id: I56fb14080f4b00accfc03e044fba3f7bf04a9f4d Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ApiTemplate 1 file changed, 66 insertions(+), 83 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56fb14080f4b00accfc03e044fba3f7bf04a9f4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: updated executing backupDB function
by juan.hernandez＠redhat.com 21 Feb '13

21 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: updated executing backupDB function ...................................................................... packaging: updated executing backupDB function Calling backupDB function from the setup flow was incorrect. This patch fixes that behavior by supplying named parameters to the function and making sure that all the parameters are correct. Change-Id: Icef79b53992210c547af13deffd57039fa43e9b0 Bug-Url: https://bugzilla.redhat.com/913176 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icef79b53992210c547af13deffd57039fa43e9b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: passing back fingerprint while updating host
by sanjal＠redhat.com 21 Feb '13

21 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: webadmin: passing back fingerprint while updating host ...................................................................... webadmin: passing back fingerprint while updating host While importing the hosts from a gluster cluster, the hosts are saved along with their sshKeyFingerprint. While updating the details of the hosts, the sshKeyFingerprint will be passed back to the backend as it is. If it is not passed, then backend thinks that the user is trying to update the sshFingerprint with null and returns an update error to frontend. Change-Id: I9e73b8bbbf5e7f2281f7a192a0157c2cc395dfc5 Bug-Url: https://bugzilla.redhat.com/888247 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/12234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e73b8bbbf5e7f2281f7a192a0157c2cc395dfc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: cleanup volume and brick models
by sanjal＠redhat.com 21 Feb '13

21 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: webadmin: cleanup volume and brick models ...................................................................... webadmin: cleanup volume and brick models Removed the unnecessary fully qualified class names for ArrayList. Change-Id: I909176fa63a6282758304016e53b9f0b6397ed90 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 2 files changed, 8 insertions(+), 9 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/12243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I909176fa63a6282758304016e53b9f0b6397ed90 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Rx and Tx should be displayed as BYTES_PER_SECOND
by alkaplan＠redhat.com 21 Feb '13

21 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: Rx and Tx should be displayed as BYTES_PER_SECOND ...................................................................... restapi: Rx and Tx should be displayed as BYTES_PER_SECOND The rx and tx are reported and displayed in the rest as percent of the speed. It should be converted and displayed as BYTES_PER_SECOND. Change-Id: Icb004ae50c00acbcb7aeb53fb3962028e6966fbc Bug-Url: https://bugzilla.redhat.com/887230 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/HostNicStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/NicStatisticalQuery.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/RxTxCalculator.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendSubResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java 8 files changed, 58 insertions(+), 24 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb004ae50c00acbcb7aeb53fb3962028e6966fbc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed period list order (#913084)
by ydary＠redhat.com 21 Feb '13

21 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed period list order (#913084) ...................................................................... reports: fixed period list order (#913084) https://bugzilla.redhat.com/913084 Change-Id: Ic8d19f7126535bffa4d7874054cb0b56eaf3cade Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Period.xml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8d19f7126535bffa4d7874054cb0b56eaf3cade Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools : taskcleaner.sh utility returns always 0 as return co...
by yzaslavs＠redhat.com 21 Feb '13

21 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools : taskcleaner.sh utility returns always 0 as return code ...................................................................... tools : taskcleaner.sh utility returns always 0 as return code taskcleaner.sh always returns exit code of 0 even on failure Change-Id: If0c61616e0c4962ee141baba7eda40341d4f721b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=910796 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/tools/dbutils/taskcleaner.sh 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0c61616e0c4962ee141baba7eda40341d4f721b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Adding support for lock to survive restart
by mkublin＠redhat.com 20 Feb '13

20 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Adding support for lock to survive restart ...................................................................... engine: Adding support for lock to survive restart The following patch will add the following functionality: 1. Introduced annotation parameter which should add a possibility not to relase in memory lock in the end of execute 2. By using this parameter we are enforcing command to release a lock only after that all child commands are finished 3. Added code which should solve restart problem - added acquireLockAsyncTask method Change-Id: I8c73dac12f6f56ce92a16f94d3b49e0795ab2e46 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockIdNameAttribute.java 5 files changed, 74 insertions(+), 14 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c73dac12f6f56ce92a16f94d3b49e0795ab2e46 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0