- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Remove dependency on jsch
by juan.hernandez＠redhat.com 07 Feb '13

07 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Remove dependency on jsch ...................................................................... packaging: Remove dependency on jsch The dependency on this package has been removed long ago (in commit 426294) but the RPM dependency is still hanging around. Change-Id: Ibb507534b8e4be810221054a28d3a68427c3900a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb507534b8e4be810221054a28d3a68427c3900a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup: remove unnecessary variable and ifs
by tnisan＠redhat.com 07 Feb '13

07 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: cleanup: remove unnecessary variable and ifs ...................................................................... core: cleanup: remove unnecessary variable and ifs BaseImagesCommand.getImage() used unnecessary auxiliary variable and if statements for class member mImage assignment, and now only uses class member mImage. Change-Id: If4ce2493c4cda5bc851aafb7a1abdc2dba9a99b5 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/11831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4ce2493c4cda5bc851aafb7a1abdc2dba9a99b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Null Pointer Exception when during preview mode acti...
by mkublin＠redhat.com 07 Feb '13

07 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Null Pointer Exception when during preview mode action, service ovirt-engine restart ...................................................................... engine: Null Pointer Exception when during preview mode action, service ovirt-engine restart The following bug was caused because of wrong member name, which was caused by not passing serialization by dstSnapshotId, and after restoring it from DB after restart its value was Guid.Empty, so because of that we usually failed at endSuccessfully because of NullPointerException. Thise caused for VM to be stuck in status locked. Change-Id: I273369d20ae3db3e9598f33ff75eb094dd420f65 Bug-Url: https://bugzilla.redhat.com/871802 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I273369d20ae3db3e9598f33ff75eb094dd420f65 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix name in parameter
by mkublin＠redhat.com 07 Feb '13

07 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fix name in parameter ...................................................................... engine: Fix name in parameter Small cosmetic fix Change-Id: I1f7d45d2cff0f162f8b58e107a75f8caaa85ada0 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmOperationParameterBase.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f7d45d2cff0f162f8b58e107a75f8caaa85ada0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing compensation for RemoveVmTemplateCommand and ...
by mkublin＠redhat.com 07 Feb '13

07 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing compensation for RemoveVmTemplateCommand and possible other commands ...................................................................... engine: Fixing compensation for RemoveVmTemplateCommand and possible other commands So, the fix is simple - change name. After a restart of engine - RemoveVmTemplate command is created based on parameters, but with old name vmTemplateId did not pass json serialization and get default value - Guid.Empty, which is id of blank template. After that , we are trying to delete blank template and failed (We are lucky) - means command failed, a origin template left with status Locked Change-Id: Ifb042d6cb8276a3c457a94823e90c1e6936cfa69 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb042d6cb8276a3c457a94823e90c1e6936cfa69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: attach disk dialog - no selection validation
by derez＠redhat.com 07 Feb '13

07 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: attach disk dialog - no selection validation ...................................................................... webadmin: attach disk dialog - no selection validation Validate no selected disks on attach dialog (show a yellow frame with a tool-tip). Change-Id: I17bbe414323ee81723809f5de4434406fa37cf69 Bug-Url: https://bugzilla.redhat.com/879218 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ValidatedPanelWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ValidatedPanelWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 6 files changed, 89 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17bbe414323ee81723809f5de4434406fa37cf69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools : engine-config confirm new passwd when changing passw...
by yzaslavs＠redhat.com 06 Feb '13

06 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools : engine-config confirm new passwd when changing passwd ...................................................................... tools : engine-config confirm new passwd when changing passwd When changing internal users password engine-config does not ask the user to confirm the new password. This patch asks for the password a second time and validates it againts the previously entered password. Change-Id: I800d1857676ad12ed084b276b3c473237280cc77 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904762 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I800d1857676ad12ed084b276b3c473237280cc77 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix mispelling in feature name
by derez＠redhat.com 06 Feb '13

06 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: restapi: Fix mispelling in feature name ...................................................................... restapi: Fix mispelling in feature name Fix the word storage (from stroage) in feature name - POSIX-FS Storage Type Change-Id: I05bccbc62b84271cb6889a91a1da2401ae9fe236 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05bccbc62b84271cb6889a91a1da2401ae9fe236 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: packging: fix source URL
by kroberts＠redhat.com 06 Feb '13

06 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: packging: fix source URL ...................................................................... packging: fix source URL Change-Id: I98af825eeb267ad7fa8e096a2bacac1f9f3b9c55 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-iso-uploader.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98af825eeb267ad7fa8e096a2bacac1f9f3b9c55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: packging: fix source URL
by kroberts＠redhat.com 06 Feb '13

06 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: packging: fix source URL ...................................................................... packging: fix source URL Change-Id: I85135c0d1e4f54f789d1e424d8301985771dc4ff Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M ovirt-image-uploader.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85135c0d1e4f54f789d1e424d8301985771dc4ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0