- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.
by asaf＠redhat.com 06 Feb '13

06 Feb '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel. ...................................................................... webadmin: Fixing infinent loop in NewGuideVmInterfaceModel. Fix for the static invocation of NewGuideVmInterfaceModel.createInstance from the same method, which causes an infinent loop. Change-Id: I94b0db601a0b88b8083eabd5e285bdb1b3168d38 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideVmInterfaceModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94b0db601a0b88b8083eabd5e285bdb1b3168d38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Renamed EventListModel.forceRefresh->forceRefreshW...
by asaf＠redhat.com 06 Feb '13

06 Feb '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Renamed EventListModel.forceRefresh->forceRefreshWithoutTimers. ...................................................................... webadmin: Renamed EventListModel.forceRefresh->forceRefreshWithoutTimers. Renamed EventListModel.forceRefresh() to forceRefreshWithoutTimers() to avoid confusion with ForceRefresh:ForceRefresh(). Change-Id: Ic3fa5c0aea31163099c26ff980439b4446b5471e Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/SubTabEventListModel.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3fa5c0aea31163099c26ff980439b4446b5471e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: compat: convert to base64 without line feed
by oschreib＠redhat.com 06 Feb '13

06 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: compat: convert to base64 without line feed ...................................................................... compat: convert to base64 without line feed This is regression of change Ie7a540d9c69, as the ticketing base64 conversion should not contain line feed. Change-Id: I33790b47ede99eade178b488a66cd8cc280cb872 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Ticketing.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33790b47ede99eade178b488a66cd8cc280cb872 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: host-deploy: use tar instead of python tarfile
by oschreib＠redhat.com 06 Feb '13

06 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: host-deploy: use tar instead of python tarfile ...................................................................... host-deploy: use tar instead of python tarfile python usage was introduced when fedora-18 alpha lacked tar utility, now fedora-18 has tar utility and the python implementation is too buggy. It does not treat trailing zeros of tarfile correctly, causing the deployment to fail. Change-Id: I9ece009af7d0c1800eb69b1ca99930892903fe9f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ece009af7d0c1800eb69b1ca99930892903fe9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: engineencryptutils: test: add encrypt/decrypt test
by oschreib＠redhat.com 06 Feb '13

06 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: engineencryptutils: test: add encrypt/decrypt test ...................................................................... engineencryptutils: test: add encrypt/decrypt test Change-Id: Ia0e623ac0d88a2244c49173f76afa454f39090e3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/test/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtilsTest.java A backend/manager/modules/engineencryptutils/src/test/resources/key.p12 2 files changed, 66 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e623ac0d88a2244c49173f76afa454f39090e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: engineencryptutils: cleanup
by oschreib＠redhat.com 06 Feb '13

06 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: engineencryptutils: cleanup ...................................................................... engineencryptutils: cleanup Remove dead code. Remove redundant variables. Rework to reach somewhat similar structure between functions. Remove the use of StringHelper. Not that the result is good... but at least something in the right way. Change-Id: I9c1004e42ee92347cbf97011e3216a1ac5c23173 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/engineencryptutils/pom.xml M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java 2 files changed, 20 insertions(+), 114 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1004e42ee92347cbf97011e3216a1ac5c23173 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: compat: remove unsafe and unneeded Encoding class
by oschreib＠redhat.com 06 Feb '13

06 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: compat: remove unsafe and unneeded Encoding class ...................................................................... compat: remove unsafe and unneeded Encoding class Left over from legacy code. Base64 usage is thread unsafe. String usage is not required. Change-Id: Ie7a540d9c69b55ce8431839c1164927024161d30 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/compat/pom.xml D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Encoding.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/EncodingTest.java M backend/manager/modules/engineencryptutils/pom.xml M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java M backend/manager/modules/utils/pom.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Ticketing.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 10 files changed, 24 insertions(+), 112 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7a540d9c69b55ce8431839c1164927024161d30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: api: Current:currents needs to be static to avoid deadly emb...
by asaf＠redhat.com 06 Feb '13

06 Feb '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: api: Current:currents needs to be static to avoid deadly embrace. ...................................................................... api: Current:currents needs to be static to avoid deadly embrace. Discovered by findbugs: org.ovirt.engine.api.common.invocation.Current$1 needs to be _static_ to avoid a deadly embrace with org.ovirt.engine.api.common.invocation.Current.currentsFirst. By definition: ThreadLocal instances are typically private static fields in classes that wish to associate state with a thread. Change-Id: I86516044e758aa526f7bab570d41567b35176029 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/Current.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86516044e758aa526f7bab570d41567b35176029 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: use APP_NAME in /etc/exports comments
by oschreib＠redhat.com 06 Feb '13

06 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: use APP_NAME in /etc/exports comments ...................................................................... packaging: use APP_NAME in /etc/exports comments when configuring /etc/exports use APP_NAME instead of the hardcoded value "rhev installer". Change-Id: Ie7c343408d586f756251247da51a3412a5a9afdd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904149#c3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 20775e7818f6e036f014b7e3f1ffbdaa801d9815) --- M packaging/fedora/setup/engine-setup.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7c343408d586f756251247da51a3412a5a9afdd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: suggest path for local storage during AIO setup
by oschreib＠redhat.com 06 Feb '13

06 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: suggest path for local storage during AIO setup ...................................................................... packaging: suggest path for local storage during AIO setup When running AIO setup, the installer suggest a default location (/var/lib/images) for the Local storage domain path the same way we suggest for the local ISO domain. Renamed generateIsoDomainName in generateIsoDomainPath in engine-setup to be more accurate. Bug-Url: https://bugzilla.redhat.com/896465 Change-Id: I9ddc2810ab3a6c2c20ce8b7663a813e89312f4d1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit b1e0cf6614cc67d4832cf41e90e3f7898b78fd06) --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/plugins/all_in_one_100.py 2 files changed, 16 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ddc2810ab3a6c2c20ce8b7663a813e89312f4d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0