- Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: etl: fixed error events reporting in jobs (#902028)
by ydary＠redhat.com 06 Feb '13

06 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed error events reporting in jobs (#902028) ...................................................................... etl: fixed error events reporting in jobs (#902028) BugUrl: https://bugzilla.redhat.com/902028 Change-Id: Ic050e6fc8b65fc76ddd6b4c7d2c7c995d03e967a Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/context_files/ovirt_engine_dwh/dailytimekeepingjob_3_2/contexts/Default.properties M data-warehouse/history_etl/context_files/ovirt_engine_dwh/deletetimekeepingjob_3_2/contexts/Default.properties M data-warehouse/history_etl/context_files/ovirt_engine_dwh/hourlytimekeepingjob_3_2/contexts/Default.properties M data-warehouse/history_etl/context_files/ovirt_engine_dwh/parallelrun_3_2/contexts/Default.properties M data-warehouse/history_etl/context_files/ovirt_engine_dwh/sampletimekeepingjob_3_2/contexts/Default.properties M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/dailytimekeepingjob_3_2/DailyTimeKeepingJob.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_3_2/DeleteTimeKeepingJob.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historyetl_3_2/HistoryETL.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hourlytimekeepingjob_3_2/HourlyTimeKeepingJob.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/parallelrun_3_2/ParallelRun.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_3_2/SampleTimeKeepingJob.java A data-warehouse/history_etl/tos_project/configuration/ExpressionBuilder/SampleTimeKeepingJob.xml M data-warehouse/history_etl/tos_project/context/connectionJDBC_3.2.item M data-warehouse/history_etl/tos_project/context/connectionJDBC_3.2.properties M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.2.item M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.2.properties M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.2.item M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.2.properties M data-warehouse/history_etl/tos_project/process/HistoryETL_3.2.item M data-warehouse/history_etl/tos_project/process/HistoryETL_3.2.properties M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.2.item M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.2.properties M data-warehouse/history_etl/tos_project/process/ParallelRun_3.2.item M data-warehouse/history_etl/tos_project/process/ParallelRun_3.2.properties M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.2.item M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.2.properties 26 files changed, 10,775 insertions(+), 2,816 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic050e6fc8b65fc76ddd6b4c7d2c7c995d03e967a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: GetAllDisksBySD - fetch disks snapshots
by derez＠redhat.com 06 Feb '13

06 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: core: GetAllDisksBySD - fetch disks snapshots ...................................................................... core: GetAllDisksBySD - fetch disks snapshots * GetAllDisksByStorageDomainIdQuery: fetch disks' snapshots for calculating the actual size (DiskImage -> getActualDiskWithSnapshotsSize). * Remove redundant GetImagesByStorageId SP. Change-Id: I055e317ea21a9eabea126e9ca17af61db659cd10 Bug-Url: https://bugzilla.redhat.com/905595 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/dbscripts/disk_images_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java 5 files changed, 31 insertions(+), 41 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I055e317ea21a9eabea126e9ca17af61db659cd10 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: refactor in UserPortalListModel & BootSequenceMo...
by tjelinek＠redhat.com 06 Feb '13

06 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: refactor in UserPortalListModel & BootSequenceModel ...................................................................... userportal: refactor in UserPortalListModel & BootSequenceModel - extract the code that set the boot from network option for a given vm from UserPortalListModel#RunOnce to a new private method to make it a little bit shorter - extract the common code in BootSequenceModel#getHardDiskOption, BootSequenceModel#getNetworkOption, BootSequenceModel#getCdromOption to a new private method to reduce the code duplication Change-Id: I841bedf241e82f6f89e88a66d6cd4e4ea681102f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java 2 files changed, 21 insertions(+), 30 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I841bedf241e82f6f89e88a66d6cd4e4ea681102f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: no boot from hard disk for diskless VM
by tjelinek＠redhat.com 06 Feb '13

06 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: no boot from hard disk for diskless VM ...................................................................... userportal: no boot from hard disk for diskless VM This patch disable the boot from hard disk option, presented in Run Once dialog, for VM that doesn't have bootable disk Change-Id: Ie2752fb8308731c1e922600a81e410a374b0ba38 Bug-Url: https://bugzilla.redhat.com/885994 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 4 files changed, 97 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2752fb8308731c1e922600a81e410a374b0ba38 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: replace negative with positive check in RunVmCommand
by rgolan＠redhat.com 06 Feb '13

06 Feb '13

Roy Golan has submitted this change and it was merged. Change subject: core: replace negative with positive check in RunVmCommand ...................................................................... core: replace negative with positive check in RunVmCommand Minor refactoring in RunVmCommand changing negative check with positive one in a ternary structure - making it more readable Change-Id: I6588f22bf6a5f8e2bc2dcd5a01f147f8c6a09c99 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6588f22bf6a5f8e2bc2dcd5a01f147f8c6a09c99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: introduce NullableFrontendActionAsyncCallback
by tjelinek＠redhat.com 06 Feb '13

06 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: introduce NullableFrontendActionAsyncCallback ...................................................................... webadmin: introduce NullableFrontendActionAsyncCallback The methods Frontend#RunAction expect to receive an instance of IFrontendActionAsyncCallback. but there are multiple places where the result of the action isn't interesting. in those cases an instance of empty IFrontendActionAsyncCallback is created and passed to those methods. This patch introduce Frontend#NULLABLE_ASYNC_CALLBACK which is an instance of Frontend#NullableFrontendActionAsyncCallback that we can passe to Frontend#RunAction methods instead. Using NULLABLE_ASYNC_CALLBACK instead of creating new empty implementation each time is better because: 1. the code is more readable as each creation of empty implementation of the callback interface is composed on several lines in the code 2. the code is more efficient as we create less objects Change-Id: Ic0cf37a9f4ffb973a3791323596af6d97c7365cb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 6 files changed, 41 insertions(+), 92 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0cf37a9f4ffb973a3791323596af6d97c7365cb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: wrong display type on run once
by tjelinek＠redhat.com 06 Feb '13

06 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: wrong display type on run once ...................................................................... userportal: wrong display type on run once This patch solves a bug that when running a VM using 'run once' mode from the user-portal, the VM is starting with its default display type even though other display type was selected for it from the 'run once' dialog. This patch also fix the default selection of the display type in the 'run once' dialog of user-portal to be the default display type of the VM (there was no default selection of display type in the dialog before). Change-Id: I665ab4578fea13fce6a22b77ee0c5d627b5c235b Bug-Url: https://bugzilla.redhat.com/907776 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/11790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I665ab4578fea13fce6a22b77ee0c5d627b5c235b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: host-deploy: use tar instead of python tarfile
by yzaslavs＠redhat.com 06 Feb '13

06 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: use tar instead of python tarfile ...................................................................... host-deploy: use tar instead of python tarfile python usage was introduced when fedora-18 alpha lacked tar utility, now fedora-18 has tar utility and the python implementation is too buggy. It does not treat trailing zeros of tarfile correctly, causing the deployment to fail. Change-Id: I9ece009af7d0c1800eb69b1ca99930892903fe9f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ece009af7d0c1800eb69b1ca99930892903fe9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Findbug fix of isPluggable method
by mkolesni＠redhat.com 06 Feb '13

06 Feb '13

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Findbug fix of isPluggable method ...................................................................... core: Findbug fix of isPluggable method This fixes an equals issue at isPluggable method Change-Id: I4360ac7b3ccc02a3ec70e217bc7a1c3aa7d24301 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4360ac7b3ccc02a3ec70e217bc7a1c3aa7d24301 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in otopi[master]: core: aggregate correctly multi-value 'after'
by Alon Bar-Lev 06 Feb '13

06 Feb '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: aggregate correctly multi-value 'after' ...................................................................... core: aggregate correctly multi-value 'after' Change-Id: I281b22f7cf128cb2dcc2350c725f3d649fa0f7bc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I281b22f7cf128cb2dcc2350c725f3d649fa0f7bc Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0