- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Removed classes DateTimeStyles, CultureInfo, TimeForma...
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed classes DateTimeStyles, CultureInfo, TimeFormatValidation ...................................................................... core: Removed classes DateTimeStyles, CultureInfo, TimeFormatValidation Removed the classes DateTimeStyles, CultureInfo, TimeFormatValidation from the compat package, they are no longer needed and all using methods had no references and were removed Change-Id: I765a43e6c5e9a6fc176caedd8294b4b0168f39a6 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/CultureInfo.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateTime.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateTimeStyles.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/DateTime.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/TimeFormatValidation.java 7 files changed, 0 insertions(+), 82 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I765a43e6c5e9a6fc176caedd8294b4b0168f39a6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove deprecated DictionaryEntry from compat
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove deprecated DictionaryEntry from compat ...................................................................... core: Remove deprecated DictionaryEntry from compat Removed the deprecated class DictionaryEntry from compat, Replaced usages with AbstractMap.SimpleEntry<String, Object> Change-Id: Ibda467f6a5bf6021849aa07ea557e6cfd3080894 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DictionaryEntry.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/ResXResourceReader.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 3 files changed, 14 insertions(+), 40 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibda467f6a5bf6021849aa07ea557e6cfd3080894 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Eliminated use of StringHelper.EqOp
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Eliminated use of StringHelper.EqOp ...................................................................... core: Eliminated use of StringHelper.EqOp Removed the method StringHelper.EqOp which was used mainly in searchbackend module to check String equality with constants thus it could be replaced with standard String implementation of equals and equalsIgnoreCase Change-Id: Iaf3d65db824f31df05dc7b0eda5f9c24274cf53c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AdUserConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/AuditLogConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ClusterConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StoragePoolFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdsConditionFieldAutoCompleter.java 13 files changed, 65 insertions(+), 82 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf3d65db824f31df05dc7b0eda5f9c24274cf53c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed deprecated StringTokenizerCompat class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed deprecated StringTokenizerCompat class ...................................................................... core: Removed deprecated StringTokenizerCompat class Removed the deprecated StringTokenizerCompat class and replaced all usages with the standard StringTokenizer Change-Id: I6e1e6af00c92cd715321d00dfcc95e56fe709363 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringTokenizerCompat.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SqlInjectionChecker.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml 3 files changed, 2 insertions(+), 38 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e1e6af00c92cd715321d00dfcc95e56fe709363 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed deprecated StringBuilderCompat class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed deprecated StringBuilderCompat class ...................................................................... core: Removed deprecated StringBuilderCompat class Remove the deprecated StringBuilderCompat class and replaced all usages to use the standard StringBuilder, in the single classes that special methods were used, the methods were extracted to the using class itself Change-Id: I5192154dc008c18c4169020c8bfe71946c3c8716 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringBuilderCompat.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml 4 files changed, 26 insertions(+), 75 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5192154dc008c18c4169020c8bfe71946c3c8716 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed unnecessary calls to StringFormat & StringHelp...
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed unnecessary calls to StringFormat & StringHelper ...................................................................... core: Removed unnecessary calls to StringFormat & StringHelper Replaced calls to StringFormat.format to String.format where possible (i.e. not code that compiles to GWT) and to simple String concatenation where possible. Also replaced calls to StringHelper.EqOp calls in String.equals calls in cases that at least one of the args was not null. Added @Override annotation to methods in the edited classes where needed Change-Id: I57dc0d9d30f9e5cd4f0beacc8bfd35fe5023afc1 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringFormat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java 8 files changed, 48 insertions(+), 55 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57dc0d9d30f9e5cd4f0beacc8bfd35fe5023afc1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: updated user prompts for stopping ovirt-engine se...
by oschreib＠redhat.com 05 Feb '13

05 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: updated user prompts for stopping ovirt-engine service during setup ...................................................................... packaging: updated user prompts for stopping ovirt-engine service during setup * If the engine service is in state not running, and only in this state, avoid to ask for stopping the service. The script doesn't check for service up and running, avoiding a regression on RHBZ #837812. * Avoid to stop the engine service if already stopped and not configured. Change-Id: I01da6e908a9f396bf4211afe863475d9fc2093be Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=896694 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit b1da51482448ddabaa9b9f5c27c06188266d4e4a) --- M packaging/fedora/setup/engine-setup.py 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified Alex Lourie: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01da6e908a9f396bf4211afe863475d9fc2093be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed MatchCollection class
by tnisan＠redhat.com 05 Feb '13

05 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed MatchCollection class ...................................................................... core: Removed MatchCollection class Removed the class MatchCollection from the compat module and all it's usages Change-Id: Ifc8ccf733c85caa257390595b2eb79f9546c2fdd Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/MatchCollection.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Regex.java 2 files changed, 0 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc8ccf733c85caa257390595b2eb79f9546c2fdd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: build: prepare for ovirt-log-collector-3.2.0 release
by kroberts＠redhat.com 05 Feb '13

05 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: build: prepare for ovirt-log-collector-3.2.0 release ...................................................................... build: prepare for ovirt-log-collector-3.2.0 release Change-Id: I5bbdf1197b452962480eaeb57768f97a4ccca2f5 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Kiril Nesenko: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bbdf1197b452962480eaeb57768f97a4ccca2f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: build: prepare for ovirt-image-uploader-3.2.0 release
by kroberts＠redhat.com 05 Feb '13

05 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: build: prepare for ovirt-image-uploader-3.2.0 release ...................................................................... build: prepare for ovirt-image-uploader-3.2.0 release Change-Id: Ida8837ac9e84110e0f2e5b7e691d43653c738c71 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Kiril Nesenko: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida8837ac9e84110e0f2e5b7e691d43653c738c71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0