- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove userGroup member from tags
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove userGroup member from tags ...................................................................... core: Remove userGroup member from tags Removed the private member "userGroup" from the tags class. This member was never updated (in fact, there are no methods to modify it!), and never queried. Its only use was in its getter, which was never used anywhere in the code. Thus, it's useless to continue holding it. Change-Id: I9e965c455a426afbd894caa85059d3d39159b84e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e965c455a426afbd894caa85059d3d39159b84e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: HOST_DEFAULT_SPM_PRIORITY constant as static
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: HOST_DEFAULT_SPM_PRIORITY constant as static ...................................................................... core: HOST_DEFAULT_SPM_PRIORITY constant as static Changed the HOST_DEFAULT_SPM_PRIORITY constant in VdsStatic to be static, as per java's conventions for constants. Change-Id: I504c3550713e78915fb2230fdbdb3ae402a19c7d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I504c3550713e78915fb2230fdbdb3ae402a19c7d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmPayload: efficient map iteration
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmPayload: efficient map iteration ...................................................................... core: VmPayload: efficient map iteration Replaced a keySet() iteration with a more efficient entrySet() iteration in the VmPayload class. Change-Id: Idb7d010c8744a161bf49d03fe9fc1b6c1c0fc32f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb7d010c8744a161bf49d03fe9fc1b6c1c0fc32f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DEFAULT_PRESTARTED_VMS constant as static
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DEFAULT_PRESTARTED_VMS constant as static ...................................................................... core: DEFAULT_PRESTARTED_VMS constant as static Changed the DEFAULT_PRESTARTED_VMS constant in vm_pools to be static, as per java's conventions for constants. Change-Id: I47cf4450bdedfebc49fc5ec49af80d586e972a52 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47cf4450bdedfebc49fc5ec49af80d586e972a52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up RemoveStoragePool.canDoAction
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Clean up RemoveStoragePool.canDoAction ...................................................................... core: Clean up RemoveStoragePool.canDoAction General Java cleanup to RemoveStorageDomain.canDoAction() - moved action type setting to setActionMessageParameters(), used getXXXDao() methods where available and removed redundant null check. Change-Id: I8aa157b7589b3ae5039c71ca07c3dc11ff88ce0d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 17 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8aa157b7589b3ae5039c71ca07c3dc11ff88ce0d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removal unneeded boolean and finally block from recove...
by mlipchuk＠redhat.com 03 Feb '13

03 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: removal unneeded boolean and finally block from recovery command. ...................................................................... core: removal unneeded boolean and finally block from recovery command. When running reconstruct as internal command, there's no need to the finally block as exceptions won't be thrown - therefore the finally block and the used boolean can be removed safely. Change-Id: I5c14601c1b9f5097c600c0139f785cbe43f4a588 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java 1 file changed, 37 insertions(+), 41 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c14601c1b9f5097c600c0139f785cbe43f4a588 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: use return value instead of a shared boolean in recove...
by mlipchuk＠redhat.com 03 Feb '13

03 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: use return value instead of a shared boolean in recovery ...................................................................... core: use return value instead of a shared boolean in recovery This patch adds the use of return value to return whether reconstruct command got to execute ReconstructMasterVDS, rather then use a shared boolean - this allows also to execute reconstruct from recovery as internal command rather then super.execute() which is less trivial and can cause to some issues. NOTE: execution of reconstruct from recovery was reverted in commit I9423d880a7d10a5bfa917e415fe41651f9d7e7f1 because of some issues that it caused, this patch fixes those issues. Change-Id: I880361ebe3f23a098a4ede760310c1f0148ae5c6 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java 2 files changed, 28 insertions(+), 19 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I880361ebe3f23a098a4ede760310c1f0148ae5c6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix multiple domains to support useDnsLookup flag
by yzaslavs＠redhat.com 03 Feb '13

03 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix multiple domains to support useDnsLookup flag ...................................................................... core: Fix multiple domains to support useDnsLookup flag Even if useDnsLookup flag is set to true at /etc/ovirt-engine/engine-manage-domains/engine-manage-domains.conf The [domain_realm] with domain realm mapping must exist in case there is more than one managed domain. Change-Id: Iebad744a40370c970d9462fb628092d9ebed13b1 bug-url: https://bugzilla.redhat.com/905291 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebad744a40370c970d9462fb628092d9ebed13b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Find bugs fix at manage-domains
by yzaslavs＠redhat.com 03 Feb '13

03 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Find bugs fix at manage-domains ...................................................................... core: Find bugs fix at manage-domains Change-Id: Iebad744a40370c970d9462fb628092d9ebed13b0 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebad744a40370c970d9462fb628092d9ebed13b0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: executing squartz job immediately
by mkublin＠redhat.com 03 Feb '13

03 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: core: executing squartz job immediately ...................................................................... core: executing squartz job immediately This patch adds an option in the SchedulerUtil API to execute scheduled job immediately. SchedulerUtil#triggerJob method, that executes immediately the job with the given id, was added. Relevant unit test was added and set to be disabled like the rest of the similar tests which already exists. Change-Id: I4661691ae970e7517a4e3a43ae87736ebd1cc15f Bug-Url: https://bugzilla.redhat.com/888396 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java M backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java M backend/manager/modules/beans/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java 3 files changed, 70 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4661691ae970e7517a4e3a43ae87736ebd1cc15f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0