- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: attach sd - avoid failover in case of export domain
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: attach sd - avoid failover in case of export domain ...................................................................... core: attach sd - avoid failover in case of export domain When attaching an export storage domain and having a failure which isn't spm/master domain related, avoid failover. Change-Id: Iea8ae06d5327e46b5cdb7ed73239744a1ba6ffc3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=896484 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/11677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea8ae06d5327e46b5cdb7ed73239744a1ba6ffc3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix mispelling in class Messages
by derez＠redhat.com 04 Feb '13

04 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fix mispelling in class Messages ...................................................................... webadmin: Fix mispelling in class Messages Fix mispelling in word storage in class Messages Change-Id: Ibe79165bfa5affc6281b972cfdf024e77dbad62a Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe79165bfa5affc6281b972cfdf024e77dbad62a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: Hosts from another data center displayed when...
by emesika＠redhat.com 04 Feb '13

04 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: Hosts from another data center displayed when... ...................................................................... Hosts from another data center displayed when... Hosts from another data center displayed when clicked on Hosts in tree view for cluster names with a single difference The way the ESCAPE character is used was changed between 8.4 and 9.x The '_' character is considered as regexp '?' character in the case ilike is used as the condition operator, therefore, we are forced to sign it as a normal character that is part of the string However, it seems that PG 8.4 forces us to use double ESCAPE character for that while it will not find any matching with one ESCAPE character and PG 9.1 is exactly the opposite , one ESCAPE character works while double ESCAPE characters will bring no data. The patch adds a new configuration variable PgMajorRelease that is computed when the 0000_config.sql script is running. The value of this variable is used to determine how to skip the special character '_' if found in the value string. Change-Id: I808fe02553b5554b76f08b43a30fb0ffd7d99973 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=874660 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 3 files changed, 50 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I808fe02553b5554b76f08b43a30fb0ffd7d99973 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: prestarted VM and increase num of VMs restyled
by tjelinek＠redhat.com 04 Feb '13

04 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: prestarted VM and increase num of VMs restyled ...................................................................... webadmin: prestarted VM and increase num of VMs restyled Edit pool dialog, prestarted VMs and increase num of VMs incorreclty styled. The sizes where hard coded. The problem become visible after the dialog has been shrinked. After unfolding the "Advanced Parameters", the scroll bar appeared effectivly shrinking the width of the dialog. The hard-coded widths where not able to respond to this. Change-Id: Iaa4130b1076162a09a3189f569b0a6a3da434d39 Bug-Url: https://bugzilla.redhat.com/879334 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 5 insertions(+), 16 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa4130b1076162a09a3189f569b0a6a3da434d39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: shrink VM, Pool, Template window
by tjelinek＠redhat.com 04 Feb '13

04 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: shrink VM,Pool,Template window ...................................................................... userportal,webadmin: shrink VM,Pool,Template window Shrinked the window so it fits to 1024x768 resolution. Change-Id: I84598f10564b8069077db6f67e977a049c8b946c Bug-Url: https://bugzilla.redhat.com/879329 Bug-Url: https://bugzilla.redhat.com/879331 Bug-Url: https://bugzilla.redhat.com/879334 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84598f10564b8069077db6f67e977a049c8b946c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine-manage-domains: Adding man page
by yzaslavs＠redhat.com 04 Feb '13

04 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine-manage-domains: Adding man page ...................................................................... engine-manage-domains: Adding man page Fix change I26e69ce141 engine-manage-domains.8 Change-Id: Icd979479d40c0cdae1db17bfbcffb0ecca5cd0b2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=742421 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd979479d40c0cdae1db17bfbcffb0ecca5cd0b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Streamline RemoveExternalEvent canDoAction()
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Streamline RemoveExternalEvent canDoAction() ...................................................................... core: Streamline RemoveExternalEvent canDoAction() Streamlined and cleaned up RemoveExternalEventCommand's canDoAction() method by using the early return pattern and overriding setActionMessageParameters(). A nice side effect of this cleanup was do solve the possible NullPointerExcetion FindBugs was complaining about, as the function would not terminate if the event was null. Change-Id: I3d2110e40ad17aea852e1002fe1de5e576dc8248 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d2110e40ad17aea852e1002fe1de5e576dc8248 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Don't check equality in BE setters
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't check equality in BE setters ...................................................................... core: Don't check equality in BE setters Some old business entities used the change-check idiom in their setters: public void setXXX (Object newValue) { if (!newValue.equals(dataMember) { dataMember = newValue; } } This was probably produced by the C# conversion, but is completely useless in Java - in any event, at the end of the setXXX method the dataMember's value will be equal to the one passed, and the equality check is more expensive than just assigning the new value. This patch removes this old idiom from the code. As a nice side-bonus, it also removes a couple of StringHelper usages from the code, as part of the ongoing effort to get rid of this class. Change-Id: Iafac9ca646c6c988470bf49d0596d973531c4616 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java 4 files changed, 4 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafac9ca646c6c988470bf49d0596d973531c4616 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Don't use EqOp on constants in commons
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't use EqOp on constants in commons ...................................................................... core: Don't use EqOp on constants in commons This patch removes the usage on StringHelper.EqOp for string constants from the commons package, and replaces them with the standard JDK string equality checks such as equals and equalsIgnoreCase. Note that the EqOp is just redundant in these cases, since a string constant is known not to be null. Change-Id: Id0936f213025c76b8c34df6d447e8067500a9887 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceStatusReturnValue.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0936f213025c76b8c34df6d447e8067500a9887 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove domains member from storage_pool
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove domains member from storage_pool ...................................................................... core: Remove domains member from storage_pool Removed the private member "domains" from the storage_pool class. This member was never updated (in fact, there are no methods to modify it!), and never queried (no such methods exists either), and was only used in the equals(Object) and hashCode() methods. Since its value is always null, it's useless to continue holding it. Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0