- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Renamed tags_user_map.java to TagsUserMap.java
by yzaslavs＠redhat.com 17 Dec '12

17 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Renamed tags_user_map.java to TagsUserMap.java ...................................................................... core: Renamed tags_user_map.java to TagsUserMap.java Change-Id: I64dafb5d61f94d1fc3916a612ff314fbbd550935 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToTagCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsUserMap.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAOHibernateImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/tags/TagUserMapDAO.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/TagDAOTest.java 8 files changed, 37 insertions(+), 37 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64dafb5d61f94d1fc3916a612ff314fbbd550935 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Renamed tags_vds_map_id.java to TagsVdsMapId.java
by yzaslavs＠redhat.com 17 Dec '12

17 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Renamed tags_vds_map_id.java to TagsVdsMapId.java ...................................................................... core: Renamed tags_vds_map_id.java to TagsVdsMapId.java Change-Id: I6bcdb73c38cc47ed27dfa45124da66827cafd65b Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVdsMapId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags_vds_map.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAOHibernateImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/tags/TagVdsMapDAO.java 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bcdb73c38cc47ed27dfa45124da66827cafd65b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Renamed tags_user_group_map.java to TagsUserGroupMap.j...
by yzaslavs＠redhat.com 17 Dec '12

17 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Renamed tags_user_group_map.java to TagsUserGroupMap.java ...................................................................... core: Renamed tags_user_group_map.java to TagsUserGroupMap.java Change-Id: I2313b7ff9c42543e6cb83f2074c95e0d1fa1a8a2 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserGroupToTagCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsUserGroupMap.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAOHibernateImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/tags/TagUserGroupMapDAO.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/TagDAOTest.java 8 files changed, 36 insertions(+), 36 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2313b7ff9c42543e6cb83f2074c95e0d1fa1a8a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix a typo in ErrorTranslatorImpl code
by emesika＠redhat.com 16 Dec '12

16 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: core: fix a typo in ErrorTranslatorImpl code ...................................................................... core: fix a typo in ErrorTranslatorImpl code This patch fixes a typo in ErrorTranslatorImpl code replaces then with than. Change-Id: Ia6cf9510bf085f3b233f02ca96c1fb09f84dda09 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6cf9510bf085f3b233f02ca96c1fb09f84dda09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add support for iLO2 and iLO4 as...(#837907)
by emesika＠redhat.com 16 Dec '12

16 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Add support for iLO2 and iLO4 as...(#837907) ...................................................................... core: Add support for iLO2 and iLO4 as...(#837907) Add support for iLO2 and iLO4 as a fencing options(#837907) ilo2 is mapped to ilo and ilo4 is mapped to ilo3. The change is only in configuration and is backward compatible. This patch does not change the naming from ilo<n> to iLo<n> since the scripts that are called in the fence_agents package use lowercase. (Actually in bug description this was described only as a Bonus and is not a part of the required solution) Also, I didn't apply this bonus since it implies upgrade of current installations values and I wanted to lower the risk of a regression. Change-Id: I01af8bdb69b379edb688b1d11d5f020e841ac354 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01af8bdb69b379edb688b1d11d5f020e841ac354 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm test cleanup: stop spying
by amureini＠redhat.com 16 Dec '12

16 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm test cleanup: stop spying ...................................................................... core: ImportVm test cleanup: stop spying Removed useless calls to Mockito.spy(), which simply spied objects but did not add any defined behaviour. Change-Id: I3e895e90994e139c369b0b5f3c3218024b7bf103 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e895e90994e139c369b0b5f3c3218024b7bf103 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: build: ax_ln_sr.m4: remove debug code
by Alon Bar-Lev 16 Dec '12

16 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: ax_ln_sr.m4: remove debug code ...................................................................... build: ax_ln_sr.m4: remove debug code Change-Id: I1b00b1155d1602eb1c94b4849dbe39d53bb34b3a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M m4/ax_ln_sr.m4 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b00b1155d1602eb1c94b4849dbe39d53bb34b3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: build: ax_ln_sr.m4: remove debug code
by Alon Bar-Lev 16 Dec '12

16 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: ax_ln_sr.m4: remove debug code ...................................................................... build: ax_ln_sr.m4: remove debug code Change-Id: If5e1d6b42ecc0e2140654c3c35be983ea1b4a727 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M m4/ax_ln_sr.m4 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5e1d6b42ecc0e2140654c3c35be983ea1b4a727 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VM.setStaticData cleanup
by lhornyak＠redhat.com 16 Dec '12

16 Dec '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: VM.setStaticData cleanup ...................................................................... core: VM.setStaticData cleanup - fixed null protection Change-Id: I566edd95a7b4c78b2a359c67173c6c6d4e70cd0b Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I566edd95a7b4c78b2a359c67173c6c6d4e70cd0b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix broken chalanger test
by mpastern＠redhat.com 16 Dec '12

16 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix broken chalanger test ...................................................................... restapi: fix broken chalanger test Change-Id: Ifaf8e16897468ab6d0ce3567daf7c5297e9b2f06 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/security/auth/ChallengerTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaf8e16897468ab6d0ce3567daf7c5297e9b2f06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0