- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Cleanup VMCommand
by lhornyak＠redhat.com 01 Oct '12

01 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup VMCommand ...................................................................... core: Cleanup VMCommand Renamed methods to conform to camelcase convention. Change-Id: I6750a6bf6bac763a73f5e7eb9912acf7bd0c50e0 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java 8 files changed, 16 insertions(+), 16 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6750a6bf6bac763a73f5e7eb9912acf7bd0c50e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: cleanup: sync log file global variable in setup a...
by juan.hernandez＠redhat.com 01 Oct '12

01 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: cleanup: sync log file global variable in setup and upgrade ...................................................................... packaging: cleanup: sync log file global variable in setup and upgrade Change-Id: I04fedb7460ec9ecc1959ff56da67300406fd1b77 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04fedb7460ec9ecc1959ff56da67300406fd1b77 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix to AddVdsSpmIdCommand
by derez＠redhat.com 30 Sep '12

30 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: fix to AddVdsSpmIdCommand ...................................................................... core: fix to AddVdsSpmIdCommand related to https://bugzilla.redhat.com/show_bug.cgi?id=771699 Currently AddVdsSpmIdCommand relies on that the vds was previously removed from it's previous DC (if present), the fix to this bug rearranged the order of the commands so that the vds is added to the new DC at first and then removed from it's previous DC, so this check caused that hosts couldn't be moved between DC. Change-Id: Id311f2ae71eda95d122ce186f0da1d87768eab0d Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id311f2ae71eda95d122ce186f0da1d87768eab0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: edit disk - hide attach checkbox (#854543)
by derez＠redhat.com 30 Sep '12

30 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: edit disk - hide attach checkbox (#854543) ...................................................................... webadmin: edit disk - hide attach checkbox (#854543) Edit disk dialog: hide 'Attach Disk' check-box since it's not relevant for 'Edit' dialog. Change-Id: I85e53c00e0642da1e7f32b29776c2954d6f905d9 Bug-Url: https://bugzilla.redhat.com/854543 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85e53c00e0642da1e7f32b29776c2954d6f905d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: select last snapshot by default (#851094)
by derez＠redhat.com 30 Sep '12

30 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: select last snapshot by default (#851094) ...................................................................... webadmin: select last snapshot by default (#851094) VMs main-tab -> Snapshots sub-tab: select the last (below 'Active VM') snapshot by default. Change-Id: Id09884a06615ecd2c1fdf7128f7af684a7e70a7d Bug-Url: https://bugzilla.redhat.com/851094 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 3 files changed, 31 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id09884a06615ecd2c1fdf7128f7af684a7e70a7d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix actual size column in disk view (#847800)
by tnisan＠redhat.com 30 Sep '12

30 Sep '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix actual size column in disk view (#847800) ...................................................................... webadmin: Fix actual size column in disk view (#847800) https://bugzilla.redhat.com/847800 Fixed actual size column in VM disks main tab to show the actual size with snapshots, and removed the actual size column from the disks main tab Change-Id: I96a45d426813bb296300e0871a206a3fdb24f52d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 2 files changed, 5 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96a45d426813bb296300e0871a206a3fdb24f52d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: check for duplicate upgrade scripts on unix
by derez＠redhat.com 30 Sep '12

30 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: check for duplicate upgrade scripts on unix ...................................................................... core: check for duplicate upgrade scripts on unix The check for duplicate upgrade scripts is implemented as a /bin/bash script, so there is no point on running it on non-unix machines. Change-Id: I2f997b63b3342d9fbfe972d6aa2ba7cb29d82ba6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/pom.xml 1 file changed, 31 insertions(+), 21 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f997b63b3342d9fbfe972d6aa2ba7cb29d82ba6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: use PKCS#12 format to store keys
by yzaslavs＠redhat.com 30 Sep '12

30 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: use PKCS#12 format to store keys ...................................................................... pki: use PKCS#12 format to store keys Java supports standard cryptographic format PKCS#12, this format bundles private key and certificate chain into one file with integrity of passphrase. Using Java proprietary key store format force additional work if using non-Java solutions. This change is a migration from JKS and duplicates into single PKCS#12 keystore for private key store. It does not handle the trust store which is left as JKS for now. Remove unnecessary scripts from CA implementations that do not support this effort. Also issue separate apache certificate and key to ease future enrollment separation. Change-Id: I2abda5778477faff09798a43cf3dc96435efb272 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=854540 --- M Makefile M backend/manager/conf/ca/CreateCA.sh D backend/manager/conf/ca/CreateKStore.sh D backend/manager/conf/ca/CreatePem.sh D backend/manager/conf/ca/CreateReq.sh D backend/manager/conf/ca/exportK2SSH.sh D backend/manager/conf/ca/generate-ssh-keys D backend/manager/conf/ca/importToKeyStore.sh M backend/manager/conf/ca/installCA.sh M backend/manager/conf/ca/installCA_dev.sh D backend/manager/conf/ca/store-utils.sh M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DomainsPasswordMapTest.java D backend/manager/modules/dal/src/test/resources/.keystore A backend/manager/modules/dal/src/test/resources/key.p12 M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java D backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/StoreUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java D backend/manager/modules/utils/src/test/resources/.hostKstore D backend/manager/modules/utils/src/test/resources/.keystore A backend/manager/modules/utils/src/test/resources/key.p12 M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M packaging/fedora/engine-service.xml.in M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/spec/ovirt-engine.spec.in 32 files changed, 279 insertions(+), 703 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2abda5778477faff09798a43cf3dc96435efb272 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: pki: cleanup: remove void statement from cert.conf
by yzaslavs＠redhat.com 30 Sep '12

30 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: cleanup: remove void statement from cert.conf ...................................................................... pki: cleanup: remove void statement from cert.conf Using $1..$9 at function gives function parameters, as a result the X.500 Subject name is not set in certificate template, actually variables had no effect. Change-Id: I3a558649e5509b5807aa142a9def5fa5b0477f2b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/ca/CreateReq.sh 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a558649e5509b5807aa142a9def5fa5b0477f2b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: support edit config file in "uncomment" mode
by yzaslavs＠redhat.com 30 Sep '12

30 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: packaging: support edit config file in "uncomment" mode ...................................................................... packaging: support edit config file in "uncomment" mode Currently comment lines are ignored, and new values are added at the bottom of the file. This breaks apache configuration which needs configuration to be specified in designated blocks. Luckily, apache provides commented keys, so we can use these as template. Change-Id: I6bc9b90b929315848aaeca10d8b1bc795938ab71 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py 2 files changed, 45 insertions(+), 16 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bc9b90b929315848aaeca10d8b1bc795938ab71 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0