- Engine-commits - oVirt List Archives

Change in ovirt-image-uploader[master]: tools: Don't print help on error (BZ858968)
by kroberts＠redhat.com 27 Sep '12

27 Sep '12

Keith Robertson has submitted this change and it was merged. Change subject: tools: Don't print help on error (BZ858968) ...................................................................... tools: Don't print help on error (BZ858968) Change-Id: I8698c1c32010d889ebae4ccb99df10c590e39ff5 Signed-off-by: Keith Robertson <kroberts(a)redhat.com> --- M src/engine-image-uploader.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8698c1c32010d889ebae4ccb99df10c590e39ff5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: tools: Fix default port (BZ857480)
by kroberts＠redhat.com 27 Sep '12

27 Sep '12

Keith Robertson has submitted this change and it was merged. Change subject: tools: Fix default port (BZ857480) ...................................................................... tools: Fix default port (BZ857480) Change-Id: Idab93219597d8199ffb79a0c7c664c6369c0416a Signed-off-by: Keith Robertson <kroberts(a)redhat.com> --- M src/engine-iso-uploader.8 M src/engine-iso-uploader.py M src/isouploader.conf 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Moran Goldboim: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idab93219597d8199ffb79a0c7c664c6369c0416a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com 27 Sep '12

27 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api ...................................................................... sdk: rebase to latest api >From ClusterGlusterVolumes.add() params removed access_protocols/access_control_list Change-Id: Iec72cccf00c6b8db8ea7c0bcc9da034a7bb1f4ad Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 6 insertions(+), 216 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec72cccf00c6b8db8ea7c0bcc9da034a7bb1f4ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: defend against disconnected mode when no proxy cached
by mpastern＠redhat.com 27 Sep '12

27 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: defend against disconnected mode when no proxy cached ...................................................................... sdk: defend against disconnected mode when no proxy cached Change-Id: Id2349669dcbd26b32d877d9adefba8ed5afa5990 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/entrypoint/entrypoint.py M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/common.py M src/ovirtsdk/infrastructure/errors.py 4 files changed, 67 insertions(+), 47 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2349669dcbd26b32d877d9adefba8ed5afa5990 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: remove unused filter_header argument
by mpastern＠redhat.com 27 Sep '12

27 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: remove unused filter_header argument ...................................................................... sdk: remove unused filter_header argument Change-Id: I8f99f1acbb434ee05c26a9e50c563b9e113fd923 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/entrypoint/entrypoint.py M src/ovirtsdk/api.py 2 files changed, 1 insertion(+), 11 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f99f1acbb434ee05c26a9e50c563b9e113fd923 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: allow persistent_auth via localhost
by mpastern＠redhat.com 27 Sep '12

27 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: allow persistent_auth via localhost ...................................................................... sdk: allow persistent_auth via localhost Change-Id: If3df5b766cfcea48dcc5a9cfb266c55570e55234 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/proxy.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3df5b766cfcea48dcc5a9cfb266c55570e55234 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AuditLogConditionFieldAutoCompleterTest JU4
by derez＠redhat.com 27 Sep '12

27 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: AuditLogConditionFieldAutoCompleterTest JU4 ...................................................................... core: AuditLogConditionFieldAutoCompleterTest JU4 Fixed AuditLogConditionFieldAutoCompleterTest to use JUnit 4 semantics (e.g., @Test, @Before annotations) instead of JUnit 3 semantics (e.g., extending TestCase). Change-Id: I21e61ea0cd1a5f77c16be44566bc2bc1f8468ecc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AuditLogConditionFieldAutoCompleterTest.java 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/8239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21e61ea0cd1a5f77c16be44566bc2bc1f8468ecc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:AuditLogConditionFieldAutoCompleterTest locale
by derez＠redhat.com 27 Sep '12

27 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core:AuditLogConditionFieldAutoCompleterTest locale ...................................................................... core:AuditLogConditionFieldAutoCompleterTest locale AuditLogConditionFieldAutoCompleterTest makes implicit assumptions about the default locale, which makes it fail on several machines (e.g., Israeli machines with iw_IL locales). This patch explicitly sets the default as en_US, so the test acts consistently, regardless of the locale of the machine it's run on. Change-Id: Ia45df7d84a7c1fd78143145de3cd234dfa9a29c3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AuditLogConditionFieldAutoCompleterTest.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/8238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia45df7d84a7c1fd78143145de3cd234dfa9a29c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: ClusterModel FindBugs
by derez＠redhat.com 27 Sep '12

27 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin: ClusterModel FindBugs ...................................................................... userportal,webadmin: ClusterModel FindBugs In StoragePool_SelectedItemChanged, selectedDataCenter is validated to be non-null in the beginning of the method, so further checks are redundant, and can be safely removed. Change-Id: Id3d2dbe60db232d07f463af96a3b05b9513a40e6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Allon Mureinik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3d2dbe60db232d07f463af96a3b05b9513a40e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: SearchSuggestionDisplay Findbugs
by derez＠redhat.com 27 Sep '12

27 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: SearchSuggestionDisplay Findbugs ...................................................................... webadmin: SearchSuggestionDisplay Findbugs Fixed the FindBugs issue: "Possible null pointer dereference of suggestBox in org.ovirt.engine.ui.webadmin.widget.autocomplete. SearchSuggestionDisplay.showSuggestions (SuggestBox,Collection, boolean, boolean, SuggestBox$SuggestionCallback)" The addition of the autoHidePartner should be done inside the null-check, not after it. Change-Id: Iffde64f273f4a9bdfa2e61a280827f5b8f0e377b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/autocomplete/SearchSuggestionDisplay.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Allon Mureinik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffde64f273f4a9bdfa2e61a280827f5b8f0e377b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0