- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Remove multiple entities with single query
by yzaslavs＠redhat.com 30 Sep '12

30 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Remove multiple entities with single query ...................................................................... engine: Remove multiple entities with single query Modified the gluster volume, brick and option DAOs to support mass remove operations. For this, - New procedures in gluster_volumes_sp.sql to support removal of multiple entities in a single query - added removeAll() method in the MassOperationsDao interface - provided default implementation in MassOperationsGenericDaoDbFacade - In this process, fixed a bug in MassOperationsGenericDaoDbFacade#updateAll(Collection<T>) - Minor change in affected DAO interfaces / classes Change-Id: Ia3a1d873807952a154c970860933daa43058cf63 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/dbscripts/gluster_volumes_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeOptionEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DefaultGenericDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkStatisticsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 21 files changed, 227 insertions(+), 47 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3a1d873807952a154c970860933daa43058cf63 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: cleanup: use constant instead of explicit rpm nam...
by juan.hernandez＠redhat.com 29 Sep '12

29 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: cleanup: use constant instead of explicit rpm name ...................................................................... packaging: cleanup: use constant instead of explicit rpm name Change-Id: I2355ac9bbd66df75ebf6ecf878a192b61972c09f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/post_upgrade.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2355ac9bbd66df75ebf6ecf878a192b61972c09f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated names of etl and notifier services
by juan.hernandez＠redhat.com 29 Sep '12

29 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated names of etl and notifier services ...................................................................... packaging: Updated names of etl and notifier services Change-Id: Icea5953c7d233b068056b75955f440b6dd6df329 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-upgrade.py 2 files changed, 14 insertions(+), 14 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icea5953c7d233b068056b75955f440b6dd6df329 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: New block storage - Unresponsive OK (#839521)
by derez＠redhat.com 27 Sep '12

27 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: New block storage - Unresponsive OK (#839521) ...................................................................... webadmin: New block storage - Unresponsive OK (#839521) Removed a call for GetStorageDomainsByConnection when creating a new block storage domain (the query is relevant only when creating a new file storage domain). The redundant query prevented a creation of a new block storage domain right after creating a file storage domain. Change-Id: I5264bada28dbcd0c7305d2032e30ec9a8b41cc15 Bug-Url: https://bugzilla.redhat.com/839521 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/8254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5264bada28dbcd0c7305d2032e30ec9a8b41cc15 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: disks tab - images as default (#860949)
by derez＠redhat.com 27 Sep '12

27 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disks tab - images as default (#860949) ...................................................................... webadmin: disks tab - images as default (#860949) Disks main-tab and VMs-Disk sub-tab: 'Images' view is displayed by default (instead of 'All'). Change-Id: I27582c4b02ae353f7b75d2e8e319507f8cee1a72 Bug-Url: https://bugzilla.redhat.com/860949 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewRadioGroup.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 5 files changed, 10 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27582c4b02ae353f7b75d2e8e319507f8cee1a72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixed exception in RemoveSnapshot
by derez＠redhat.com 27 Sep '12

27 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Fixed exception in RemoveSnapshot ...................................................................... core: Fixed exception in RemoveSnapshot Fixed exception when polling a task to remove a snapshot. Change-Id: I32f58364cbc0cd7a9beda6785fa1227fb838cc5a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32f58364cbc0cd7a9beda6785fa1227fb838cc5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine:Validate maximum number of hosts in DC.(#771699)
by derez＠redhat.com 27 Sep '12

27 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: engine:Validate maximum number of hosts in DC.(#771699) ...................................................................... engine:Validate maximum number of hosts in DC.(#771699) http://bugzilla.redhat.com/show_bug.cgi?id=771699 when a host is added, there should be a check whether the maximum number of hosts attached to DC has been exceeded. If max number of hosts is exceeded, user should be presented with an appropriate message. Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties 5 files changed, 47 insertions(+), 26 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Use standard colors in the shell output (no bz)
by juan.hernandez＠redhat.com 27 Sep '12

27 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: tools: Use standard colors in the shell output (no bz) ...................................................................... tools: Use standard colors in the shell output (no bz) There are tools that can work only with the standard colors, like the AnsiColor plugin for Jenkins. Change-Id: Iafb18728efb6b1724fb3725cbf1615621187b3a1 Signed-off-by: Rami Vaknin <rvaknin(a)redhat.com> --- M packaging/fedora/setup/basedefs.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafb18728efb6b1724fb3725cbf1615621187b3a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Rami Vaknin <rvaknin.redhat.com(a)gmail.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Rami Vaknin <rvaknin.redhat.com(a)gmail.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ActivateDeactivateSingleAsyncOperationFactory cleanup
by lhornyak＠redhat.com 27 Sep '12

27 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: ActivateDeactivateSingleAsyncOperationFactory cleanup ...................................................................... core: ActivateDeactivateSingleAsyncOperationFactory cleanup added import java.util.ArrayList Change-Id: Ie724fe04effb46cbd7b7d09714c6934adcc03660 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie724fe04effb46cbd7b7d09714c6934adcc03660 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix error caused by javac 1.6.0_24 bug in VdsManager
by rgolan＠redhat.com 27 Sep '12

27 Sep '12

Roy Golan has submitted this change and it was merged. Change subject: core: fix error caused by javac 1.6.0_24 bug in VdsManager ...................................................................... core: fix error caused by javac 1.6.0_24 bug in VdsManager seems like 1.6._024 compiler is failing to parse "(Config.<Object>" in some circumstances. Flipping the order does the trick. Change-Id: I2855a27b27163385530156e306fd8beca2c7cda3 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2855a27b27163385530156e306fd8beca2c7cda3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0