- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: common: handle resources if path contains special characters
by dfediuck＠redhat.com 30 Aug '12

30 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: common: handle resources if path contains special characters ...................................................................... common: handle resources if path contains special characters ClassLoader.getResource() returns URL, URL.getPath() returns URI encoded string. Trying to use this string to access file will fail without decoding it first. Change-Id: Iff53340e6243b9e7c634ba00f30bac685b82ef80 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DomainsPasswordMapTest.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/PackageExplorer.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/ReflectionHelper.java M backend/manager/tools/engine-config/src/test/java/org/ovirt/engine/core/config/EngineConfigTest.java 4 files changed, 14 insertions(+), 8 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff53340e6243b9e7c634ba00f30bac685b82ef80 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extracts method to find VMs using nets (#824497)
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extracts method to find VMs using nets (#824497) ...................................................................... engine: Extracts method to find VMs using nets (#824497) https://bugzilla.redhat.com/824497 The patch extracts a method which finds VMs that uses a given list of networks. The method will be used by SetupNetworks to enforce same validation. Change-Id: I07cfac66a34618772aaf87bafb01b870d4d38322 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 3 files changed, 88 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07cfac66a34618772aaf87bafb01b870d4d38322 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Modify Vm names key in message (#824497)
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Modify Vm names key in message (#824497) ...................................................................... engine: Modify Vm names key in message (#824497) https://bugzilla.redhat.com/824497 The patch modifies the VM names key in error message so it could be utilized by the SetupNetwork commands for reporting a multiple entities. Change-Id: I01eaaf33a8becb77ab2378e7aa1df008ad399119 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 7 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01eaaf33a8becb77ab2378e7aa1df008ad399119 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Deny removal of used network (#824497)
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Deny removal of used network (#824497) ...................................................................... engine: Deny removal of used network (#824497) https://bugzilla.redhat.com/824497 The patch denies removal of a network which is currently used by running VMs via SetupNetworks command. If the network is used, an appropriate error message will appear. Change-Id: Idbe45c13d0e86fd64096dd28d7df4381feeb075c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbe45c13d0e86fd64096dd28d7df4381feeb075c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: Delete oldNetworkName from UpdateNetworkToVds"
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: Delete oldNetworkName from UpdateNetworkToVds" ...................................................................... Revert "core: Delete oldNetworkName from UpdateNetworkToVds" This reverts commit 96ccaea207fa0da4a1ee9c544117ee2b8993d2f2. Change-Id: I7ea26efae18c8fbeed30966ab26ac64aef526645 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 3 files changed, 18 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ea26efae18c8fbeed30966ab26ac64aef526645 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Update bond mode on 3.0 DC (#850423)
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Update bond mode on 3.0 DC (#850423) ...................................................................... webadmin: Update bond mode on 3.0 DC (#850423) https://bugzilla.redhat.com/850423 The patch enables updating bonding options when VLANs are created on top of the bond. It is enabled by exposing the VLAN networks on the list of available networks to the user. Change-Id: If316259f9760777c5f85db0880a157021c61a6bd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If316259f9760777c5f85db0880a157021c61a6bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: Cannot replace management network nic (#840888...
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: Cannot replace management network nic (#840888)" ...................................................................... Revert "core: Cannot replace management network nic (#840888)" This reverts commit e8590ce0e5a37df793873c7b0f9a51eb990d48d2. Change-Id: I3c15d815c4963dab9c58800a884734b3d1236ccd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 8 insertions(+), 38 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c15d815c4963dab9c58800a884734b3d1236ccd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: Fix validation of Updating attached network"
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: Fix validation of Updating attached network" ...................................................................... Revert "core: Fix validation of Updating attached network" This reverts commit b06f11509e488f2888ed4044081f5041d00fa93e Change-Id: Ica21e3fa8f823cc750e35a494e0d0364ea7462c6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 28 insertions(+), 24 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica21e3fa8f823cc750e35a494e0d0364ea7462c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "engine: Change iteration to foreach (#849971)"
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "engine: Change iteration to foreach (#849971)" ...................................................................... Revert "engine: Change iteration to foreach (#849971)" This reverts commit a11ea98b0ec411e8fdde6898a1ca02ebc40c13d2. Change-Id: Ia7f3648090329109838fd8f1dffd235579968b3e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7f3648090329109838fd8f1dffd235579968b3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: Add message that more than one network attache...
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: Add message that more than one network attached (#849971)" ...................................................................... Revert "core: Add message that more than one network attached (#849971)" This reverts commit 0a998d9d130fae64eea484e2972e41f98e07dccb. Messages are removed since aren't in use anymore due to revert of the patch which used them. Change-Id: I757c23d87fc728ad902bbd352686487330d9fcfe Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 0 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I757c23d87fc728ad902bbd352686487330d9fcfe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0