- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Change Error Message in DetachNetwork (#842748)
by msalem＠redhat.com 02 Sep '12

02 Sep '12

Muli Salem has submitted this change and it was merged. Change subject: core: Change Error Message in DetachNetwork (#842748) ...................................................................... core: Change Error Message in DetachNetwork (#842748) https://bugzilla.redhat.com/842748 Please refer to subject. Change-Id: Id0332467769237c7fd4e4bbf3b52e05919978351 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 5 insertions(+), 5 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0332467769237c7fd4e4bbf3b52e05919978351 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: ManageDomainsResult prints null when setConfigValue ...
by oourfali＠redhat.com 02 Sep '12

02 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: engine: ManageDomainsResult prints null when setConfigValue fails (#851069) ...................................................................... engine: ManageDomainsResult prints null when setConfigValue fails (#851069) When deleting domain we get wrong error messages. This fix it: 1. In ConfigurationProvider we throw ManageDomainsResult with list of strings instead initializing it with the entry, and the error has two sperate arguments. This results in printing a default message instead of the real one. 2. ManageDomainsResult didn't override getMessage method. 3. The output for ManageDomainsResult with no default message was changed to include also enumResult message. Change-Id: If5b7abde0edb700f42563f06160cd7278848ad0e Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResult.java 2 files changed, 15 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5b7abde0edb700f42563f06160cd7278848ad0e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: delete last domain fails with engine-manage-domain (#8...
by oourfali＠redhat.com 02 Sep '12

02 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: delete last domain fails with engine-manage-domain (#851069) ...................................................................... core: delete last domain fails with engine-manage-domain (#851069) Setting AdUserPassword to empty string failed because AdUserPassword.type is CompositePassword. CompositePassword must contain the char ':' otherwise set operation on this value will fail. The fix lets us also assign empty string to CompositePassword when we want to erase this value in db. Change-Id: I9d4904a916f2055288e99114f2f267face16797b Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d4904a916f2055288e99114f2f267face16797b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: enable Edit button for non-active block SDs (#8507...
by derez＠redhat.com 02 Sep '12

02 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: enable Edit button for non-active block SDs (#850733) ...................................................................... webadmin: enable Edit button for non-active block SDs (#850733) https://bugzilla.redhat.com/850733 Storage main-tab: Enabling 'Edit' button when a non-active block storage domain is selected - the 'Edit Domain' dialog should be opened in view-only mode (merely for displaying domain's information). Change-Id: I2bfe64fe10ebe1ddbdd5d8df475b176db5cd9794 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiTargetToLunView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 6 files changed, 77 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bfe64fe10ebe1ddbdd5d8df475b176db5cd9794 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: missing hourglass on remove VM from export
by derez＠redhat.com 02 Sep '12

02 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: missing hourglass on remove VM from export ...................................................................... webadmin: missing hourglass on remove VM from export Added an hourglass to 'remove VM from export domain' dialog. Change-Id: I172874a0d8cde8ed91e855a8d817dc14bb655793 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I172874a0d8cde8ed91e855a8d817dc14bb655793 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: API: support name attribute for PortMirrorings Network (#842...
by shavivi＠redhat.com 02 Sep '12

02 Sep '12

Shahar Havivi has submitted this change and it was merged. Change subject: API: support name attribute for PortMirrorings Network (#842163) ...................................................................... API: support name attribute for PortMirrorings Network (#842163) https://bugzilla.redhat.com/show_bug.cgi?id=842163 Change-Id: I4405f1a551dbc32b81e3e521844eee1376e61f6c Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java 2 files changed, 81 insertions(+), 43 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4405f1a551dbc32b81e3e521844eee1376e61f6c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: fix /Disk backward compatibility issue
by mpastern＠redhat.com 02 Sep '12

02 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix /Disk backward compatibility issue ...................................................................... restapi: fix /Disk backward compatibility issue removing /type element from disk will cause backward compatibility issue between 3.0 & 3.1 Change-Id: I938ecd2d09195c8bbba4964a708f3a73e1534bfe Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I938ecd2d09195c8bbba4964a708f3a73e1534bfe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor SearchObjectAutoCompleter cleanup
by lhornyak＠redhat.com 31 Aug '12

31 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: minor SearchObjectAutoCompleter cleanup ...................................................................... core: minor SearchObjectAutoCompleter cleanup simplifications and cleanups for findbugs warnings. Change-Id: I1f0395d9e7d12034ca1e849999a5b1dc48f7b0f5 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 2 files changed, 16 insertions(+), 19 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f0395d9e7d12034ca1e849999a5b1dc48f7b0f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: packaging: updated utility function for parsing web-conf.js
by juan.hernandez＠redhat.com 31 Aug '12

31 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: updated utility function for parsing web-conf.js ...................................................................... packaging: updated utility function for parsing web-conf.js Change-Id: Ic81a7a10d33a608fee3011ccdf462d7e74ecf52c Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic81a7a10d33a608fee3011ccdf462d7e74ecf52c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: support external host for VdsInstallerSSH tests
by dfediuck＠redhat.com 30 Aug '12

30 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: utils: support external host for VdsInstallerSSH tests ...................................................................... utils: support external host for VdsInstallerSSH tests Useful for problem determination using real sshd. Similar to low level SSH tests, only that it cannot receive custom key store. Change-Id: I007282dbb9404f0a0a898ae2443dccf9f0c0e404 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java 1 file changed, 50 insertions(+), 25 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I007282dbb9404f0a0a898ae2443dccf9f0c0e404 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0