- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Revert "engine: Obtain old network name from correct NIC (#8...
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "engine: Obtain old network name from correct NIC (#849971)" ...................................................................... Revert "engine: Obtain old network name from correct NIC (#849971)" This reverts commit d9472bf9135f5d230603da30dc9d1ee65fcdf947. Commit b06f11509e488f2888ed4044081f5041d00fa93e introduced several regressions. It designed to calculate the network name by the interfaces being sent (in order to prevent remove of network not related to the modified interfaces). However it fails to resolve several cases in which the sent interface doesn't contain the network name (multiple VLANs over bond where on backend side assumption can't be made). Change-Id: I853fcd2400ab131f687d798a4cff230a99294c8f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 5 insertions(+), 12 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I853fcd2400ab131f687d798a4cff230a99294c8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AddVmInterface Calls PlugUnplugCommand (#850854)
by msalem＠redhat.com 30 Aug '12

30 Aug '12

Muli Salem has submitted this change and it was merged. Change subject: core: AddVmInterface Calls PlugUnplugCommand (#850854) ...................................................................... core: AddVmInterface Calls PlugUnplugCommand (#850854) https://bugzilla.redhat.com/850854 Instead of calling HotPlugNicVdsCommand, AddVmInterfaceCommand is changed to call PlugUnPligVmNicCommand. This prevents redundancy between the two engine commands. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: Ibc4636c8003ea3fc170a13be96a3efb9dc8cca24 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java 1 file changed, 56 insertions(+), 37 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Mike Kolesnik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc4636c8003ea3fc170a13be96a3efb9dc8cca24 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Changing Command Name to be Accurate (#850854)
by msalem＠redhat.com 30 Aug '12

30 Aug '12

Muli Salem has submitted this change and it was merged. Change subject: core: Changing Command Name to be Accurate (#850854) ...................................................................... core: Changing Command Name to be Accurate (#850854) https://bugzilla.redhat.com/850854 Since the HotPlugUnplugVmNicCommand does not necessarily perform hotplug, changing the command name accordingly. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: I3504be61ba4ad7bd53d1bf188ee9367310b8f9c0 --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugVmNicCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PlugUnplugVmNicParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 22 insertions(+), 22 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3504be61ba4ad7bd53d1bf188ee9367310b8f9c0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Validate Network is in Host for HotPlug (#850854)
by msalem＠redhat.com 30 Aug '12

30 Aug '12

Muli Salem has submitted this change and it was merged. Change subject: core: Validate Network is in Host for HotPlug (#850854) ...................................................................... core: Validate Network is in Host for HotPlug (#850854) https://bugzilla.redhat.com/850854 This patch makes sure the Network that is being added to the VM and activated, is in the VM's current Host. Change-Id: Ie1ef34503e5232280c506cf6a909fd703e99acb3 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugVmNicCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 37 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Mike Kolesnik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1ef34503e5232280c506cf6a909fd703e99acb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Set Vds Only When Vm is UP (#850854)
by msalem＠redhat.com 30 Aug '12

30 Aug '12

Muli Salem has submitted this change and it was merged. Change subject: core: Set Vds Only When Vm is UP (#850854) ...................................................................... core: Set Vds Only When Vm is UP (#850854) https://bugzilla.redhat.com/850854 This patch makes sure that setVdsId is only done in PlugUnPlugVmNicCommand if the Vm is running. Change-Id: I6f4fbf069555f6eb8cadd07d9a80a40ec0923013 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PlugUnplugVmNicCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f4fbf069555f6eb8cadd07d9a80a40ec0923013 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: bond on 3.0- default boot proto is Dhcp should be ...
by alkaplan＠redhat.com 30 Aug '12

30 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: bond on 3.0- default boot proto is Dhcp should be none (#851513) ...................................................................... webadmin: bond on 3.0- default boot proto is Dhcp should be none (#851513) https://bugzilla.redhat.com/851513 DC/CL 3.0 When creating bond on host, radio button Boot Protocol: is set to DHCP which is different from assigning network/VLAN to single NIC, there is radio button set to none. Change-Id: Idddd8678b6c47553e1ac99073aaedffcd09c2cce Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idddd8678b6c47553e1ac99073aaedffcd09c2cce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed 'show deleted' in reports. (#768712)
by ydary＠redhat.com 30 Aug '12

30 Aug '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed 'show deleted' in reports. (#768712) ...................................................................... reports: fixed 'show deleted' in reports. (#768712) https://bugzilla.redhat.com/768712 Change-Id: Ib4ed35597569f22cf10c718a829fce654c714df8 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Executive/active_vms_by_os_br18_files/full details.jrxml.data M reports/repository_files/resources/Reports/Executive/cluster_capacity_vs_usage_br19_files/full details br19.jrxml.data M reports/repository_files/resources/Reports/Executive/host_os_break_down_BR22_files/full details.jrxml.data M reports/repository_files/resources/Reports/Executive/summary_of_host_usage_resources_br17_files/full details.jrxml.data M reports/repository_files/resources/Reports/Inventory/Hosts_Inventory_files/full details br1.jrxml.data M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/full details.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/full details br13.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/cluster_uptime_br7_files/br7 full details.jrxml.data M reports/repository_files/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/br7b full details.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/cluster_quality_of_service_vms_br13_files/full details.jrxml.data M reports/repository_files/resources/Reports/Service_level/VMs/virtual_servers_uptime_br14_files/br14 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/Five_most_utilized_hosts_over_time_files/br7 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/br7 full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_least_utilized_vms_Over_Time_BR12_files/full details.jrxml.data M reports/repository_files/resources/Reports/Trend/Virtual_machines/five_most_utilized_vms_over_time_br11_files/full details.jrxml.data 15 files changed, 30 insertions(+), 30 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4ed35597569f22cf10c718a829fce654c714df8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Unsynced networks boot parameters can be changed (...
by alkaplan＠redhat.com 30 Aug '12

30 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Unsynced networks boot parameters can be changed (#848354) ...................................................................... webadmin: Unsynced networks boot parameters can be changed (#848354) https://bugzilla.redhat.com/848354 If after marking the network as to-sync and changing its parameter, the to-sync is unmarked, the changed parameters should be reverted. Change-Id: I688e46577f03dd55024b8eea9c38aec57dfcd511 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 3 files changed, 53 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I688e46577f03dd55024b8eea9c38aec57dfcd511 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: checking quota even if can-do fails (#846777)
by dfediuck＠redhat.com 30 Aug '12

30 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: checking quota even if can-do fails (#846777) ...................................................................... core: checking quota even if can-do fails (#846777) https://bugzilla.redhat.com/846777 there is a problem in quota flow, that I validate and set (set is the wrong part here) quota even if the command fails. that causes a lot of problems when the command fails and the quota get validated, and the use of that command is getting cached... therefore, the validate & set quota will be invoked iff all the command will go on to the execute part. Change-Id: I0f4dd77582985f521ef0009b421cbd0e83466b57 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f4dd77582985f521ef0009b421cbd0e83466b57 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: block operation with unsync network (#848373)
by alkaplan＠redhat.com 30 Aug '12

30 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: block operation with unsync network (#848373) ...................................................................... webadmin: block operation with unsync network (#848373) https://bugzilla.redhat.com/848373 - Block operation with unsync network- same as unmanaged network. - If sync network is detached- The network will get the dc values and will be condsidered as synced (when detaching the network will automatically be added to the sync list sent to the backend.) Change-Id: I0225ec2240ceab7777373812c2742e261ca8534a Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/DcNetworkParams.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 7 files changed, 148 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0225ec2240ceab7777373812c2742e261ca8534a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0