- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Remove checkboxes from 3.0 and less host interface...
by alkaplan＠redhat.com 30 Aug '12

30 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Remove checkboxes from 3.0 and less host interfaces tab(#831845) ...................................................................... webadmin: Remove checkboxes from 3.0 and less host interfaces tab(#831845) https://bugzilla.redhat.com/831845 Remove the selection checkboxes from 3.0 and less host-interfaces sub tab. Change-Id: Ia0d4f21c4e1b8570a8aa3be954e6bd8868f7d01d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java 5 files changed, 73 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0d4f21c4e1b8570a8aa3be954e6bd8868f7d01d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SPMAsyncTask: Make logger final
by mlipchuk＠redhat.com 30 Aug '12

30 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: SPMAsyncTask: Make logger final ...................................................................... core: SPMAsyncTask: Make logger final Flagged the logger as final to stress the fact that it's immutable. In addition, any minor performance enhancement we can get for free would be welcome here. Change-Id: I89c182046d7b18a0c86dcd132f6629baaf41d801 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89c182046d7b18a0c86dcd132f6629baaf41d801 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Disk move job description details (#849981)
by oourfali＠redhat.com 30 Aug '12

30 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Disk move job description details (#849981) ...................................................................... core: Disk move job description details (#849981) https://bugzilla.redhat.com/849981 This patch adds details to the CopyOrMoveDiskCommand job, to contain the source and target storage domains. Change-Id: Id325e9871d1bac01be1119d92853984bd6ebe1bc Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id325e9871d1bac01be1119d92853984bd6ebe1bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Cluster with Virt and Gluster enabled - configurable
by ofrenkel＠redhat.com 30 Aug '12

30 Aug '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Cluster with Virt and Gluster enabled - configurable ...................................................................... engine: Cluster with Virt and Gluster enabled - configurable A new configuration property is added vdc_options named 'AllowClusterWithVirtGlusterEnabled'. It is to determine whether the user is allowed to create a cluster with both Virt and Gluster services enable or not. It will have the default value as true, so that user can have a cluster with Virt and Gluster enabled. Required entries are added to engine-config.properties. Change-Id: I63c501501545f35ee445861f71ec3c7197d66e06 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/tools/engine-config/src/main/resources/engine-config.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 48 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63c501501545f35ee445861f71ec3c7197d66e06 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:Enable update for storage domain name(#851835)
by ofrenkel＠redhat.com 30 Aug '12

30 Aug '12

Omer Frenkel has submitted this change and it was merged. Change subject: core:Enable update for storage domain name(#851835) ...................................................................... core:Enable update for storage domain name(#851835) https://bugzilla.redhat.com/show_bug.cgi?id=851835 Update storage domain name fails since lastTimeUsedAsMaster property is sent from the client is not synchronized with the DB value. This is because this field is not reflected to the user and it is internally used in the engine. The proposed fix is to update the field with the old value from the DB before update the storage domain in the DB. Change-Id: I77de69fb8bd28a3c2c1ec1a9be576cb7b4e9dd69 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/7598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77de69fb8bd28a3c2c1ec1a9be576cb7b4e9dd69 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Changing Directory service exception handling (#844733...
by oourfali＠redhat.com 30 Aug '12

30 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Changing Directory service exception handling (#844733) ...................................................................... core: Changing Directory service exception handling (#844733) https://bugzilla.redhat.com/844733 The following patch introduces the following: a. Exception hierarchy for Directory services issues - a.1. A new DirectoryServiceException class serving base class for Engine DS exceptions a.2. Renaming EngineDirectoryServiceException to AuthenticationResultException and have it extend DirectoryServiceException b. Throwing DirectoryServiceException at GetRootDSE instead of current exception swallowing Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6573 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/AuthenticationResultException.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectoryServiceException.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/EngineDirectoryServiceException.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPILdapTemplateWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSETask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchExceptionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/PrepareLdapConnectionTask.java 12 files changed, 82 insertions(+), 58 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6573 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: setting proper timeout mechanism for GetRootDSE (#8447...
by oourfali＠redhat.com 30 Aug '12

30 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: setting proper timeout mechanism for GetRootDSE (#844733) ...................................................................... core: setting proper timeout mechanism for GetRootDSE (#844733) https://bugzilla.redhat.com/844733 This is a first patch in series of patches that deals with a problem that search users reaches a timeout. In this patch, a proper timeout mechanism is used. Although it was assumed that changing LdapQueryTimeout to a low value (i.e - 3 seconds) will yield a timeout after the provided amount of time, in fact it took longer for GetRootDSE to timeout. This patch fixes this issue. Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6579 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 7 files changed, 37 insertions(+), 4 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6579 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: USB policy template issues (#850719)
by oourfali＠redhat.com 30 Aug '12

30 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: USB policy template issues (#850719) ...................................................................... core: USB policy template issues (#850719) https://bugzilla.redhat.com/850719 Previous patch did some fixes for this issue, but one of the changes were accidently omitted. This patch contains the spec params fix for the USB controllers. Change-Id: I805e70f30a3b767814d7814c99e820b6de4e9e48 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/7601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I805e70f30a3b767814d7814c99e820b6de4e9e48 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: manage-domains: remove obsolete keys from engine-manage-doma...
by yzaslavs＠redhat.com 30 Aug '12

30 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: manage-domains: remove obsolete keys from engine-manage-domains.conf ...................................................................... manage-domains: remove obsolete keys from engine-manage-domains.conf These are unused since commit 936b5b092. Change-Id: I0f96123684a3ee731fb2ca4611eb0beda2022677 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/resources/engine-manage-domains.conf 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f96123684a3ee731fb2ca4611eb0beda2022677 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: run once with stateless uses run (#852345)
by tjelinek＠redhat.com 30 Aug '12

30 Aug '12

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: run once with stateless uses run (#852345) ...................................................................... engine: run once with stateless uses run (#852345) https://bugzilla.redhat.com/852345 select vm->run once->boot options->check Run Stateless->click OK Fixed by changing the RunVmCommand.EndSuccessfully runInternalAction(VdcActionType.RunVm runInternalAction(getActionType() because the EndSuccessfully is inherited also by RunVmOnceCommand. Change-Id: Ib50667011e8fab98b456652648f18137ede1ef58 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib50667011e8fab98b456652648f18137ede1ef58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0