- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core : correct message when suspend vm witout image disks(#8...
by mlipchuk＠redhat.com 28 Aug '12

28 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core : correct message when suspend vm witout image disks(#841504) ...................................................................... core : correct message when suspend vm witout image disks(#841504) https://bugzilla.redhat.com/841504 if VM has no image disks so there is no place to write the suspend file to. before this message the message that was presented to the user was regarding low disk space and not related to the fact that the VM doesn't have any image disks. Change-Id: I11fb32b54cf159fb63e172504342861493d2aa77 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 18 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11fb32b54cf159fb63e172504342861493d2aa77 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:encrypt vds_static pm_password field on upgrade to 3.1
by emesika＠redhat.com 28 Aug '12

28 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core:encrypt vds_static pm_password field on upgrade to 3.1 ...................................................................... core:encrypt vds_static pm_password field on upgrade to 3.1 In 3.0 all host having PM configured add the agent password (pm_password) in plain-text. In 3.1 when we configure PM, we also encrypt its password and it stored in the database. This patch goes over all hosts that are upgrading from 3.0 to 3.1 and encrypt the agent password in the database (vds_static.pm_password) if it has PM configured (pm_enabled = true) The patch gets all information needed for the encryption from the database configuration values (stored in vdc_options) table) and uses the encryption exposed by store-utils to get the work done. All the above is executed via a shell script The script is numbered as 03_00_0420 since 03_00_0410 was the last 3.0 script and we want the shell script to run only when upgrading from 3.0 to 3.1. Also, please note that the pm_password field in vds_static was changed from varchar to text in 03_01_0030 and we had to verify that this change occurs also in our patch. This is OK since the general function used for that to change the type validates the source type. Change-Id: I4196ef1070ffabdbc7b8b2846fc4f0340ef07ac8 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_00_0420_encrypt_pm_passwd.sh 1 file changed, 37 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4196ef1070ffabdbc7b8b2846fc4f0340ef07ac8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: db function extensions
by emesika＠redhat.com 28 Aug '12

28 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: db function extensions ...................................................................... core: db function extensions Adding a new function that accepts the option_name and value and return back the option_value. This function is needed as an infrastructure for further bug resolving. In case of a shell upgrade script export variables to be used by it. Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6587 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6587 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Check HTTP response status for Reports.xml
by vszocs＠redhat.com 28 Aug '12

28 Aug '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Check HTTP response status for Reports.xml ...................................................................... webadmin: Check HTTP response status for Reports.xml In ReportInit.parseReportsXML method, HTTP response status should be checked first, before trying to parse response text as XML. For example, missing Reports.xml will cause 404 (not found) HTTP response, with response text being HTML (error page). Change-Id: I40823031291c6223cf9acb484e5b20d74baa8142 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40823031291c6223cf9acb484e5b20d74baa8142 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix notifier parameters
by yzaslavs＠redhat.com 28 Aug '12

28 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix notifier parameters ...................................................................... core: Fix notifier parameters The default parameters of the notifier service are not adjusted when the engine is configured. This patch changes the notifier so that it will get the parameters directly from the engine configuration file /etc/sysconfig/ovirt-engine. Change-Id: Ic4adb0c079b5d008e83dcf5449582916d8bd9ef3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.conf M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.sh M backend/manager/tools/engine-notifier/engine-notifier-service/pom.xml M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/connection-test-notifier.conf M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/error-notifier.conf D backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/login-config.xml M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/notifier.conf D backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/postgres-ds.xml 10 files changed, 26 insertions(+), 224 deletions(-) Approvals: Juan Hernandez: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4adb0c079b5d008e83dcf5449582916d8bd9ef3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add local configuration helper
by yzaslavs＠redhat.com 28 Aug '12

28 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Add local configuration helper ...................................................................... core: Add local configuration helper This patch adds the LocalConfig class intended to centralize the management of local configuration stored in the /etc/sysconfig/ovirt-engine file (or whatever the ENGINE_VARS environment variable points to). The name "local" is intended to convey the difference between the configuration that is specific to a particular node and the configuration that is "global", stored in the database, and shared by all the nodes in a (future) cluster. The intended use is something like this: LocalConfig config = LocalConfig.getInstance(); String myVar = config.getProperty("MY_VAR"); In addition to this generic interface it also supports other methods to get the values of well known variables, like port numbers and directories, for example: int httpPort = config.getExternalHttpPort(); int httpsPort = config.getExternalHttpPort(); These methods contain some logic to decide if the external port is the one used by the web server or the one used by the application server. Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java 1 file changed, 326 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000055 Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: SDs missing from tree (#851853)
by gchaplik＠redhat.com 28 Aug '12

28 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: SDs missing from tree (#851853) ...................................................................... webadmin: SDs missing from tree (#851853) https://bugzilla.redhat.com/851853 The webadmin's left hand side tree was missing individual storage domains under the storage group Tree pane. The problem was a wrong use of 'instanceof' operator. Change-Id: I2de63a284c120f059fa11095e9997f6b22a195da Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2de63a284c120f059fa11095e9997f6b22a195da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: NPE in remove from export domain (#847652)
by gchaplik＠redhat.com 28 Aug '12

28 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: NPE in remove from export domain (#847652) ...................................................................... core: NPE in remove from export domain (#847652) https://bugzilla.redhat.com/847652 While removing VM/Template from export domain, in endCommand we construct the command again and try to fetch the vm/template, which will fail (because the vm/template doesn't exist), therefore, we need a Null check there. Change-Id: I8b65227d94ba426b943181398fcd06b6137638fa Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java 2 files changed, 16 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b65227d94ba426b943181398fcd06b6137638fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove check for permissions on pool on detach user fr...
by ofrenkel＠redhat.com 28 Aug '12

28 Aug '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove check for permissions on pool on detach user from vm (#850741) ...................................................................... core: remove check for permissions on pool on detach user from vm (#850741) https://bugzilla.redhat.com/show_bug.cgi?id=850741 When detaching user from pool-vm, there is a check that the user has permissions on the pool. this check is not correct since user may have lost his permissions on the pool before stopping the vm, this check was removed. anyway user is detached from vms in this pool so it has no meaning. Change-Id: I3bfb1a741c6be33427e94d944a8c41d3553cba80 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bfb1a741c6be33427e94d944a8c41d3553cba80 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, packaging: Don't use JBoss default ports (#831193)
by juan.hernandez＠redhat.com 28 Aug '12

28 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: core, packaging: Don't use JBoss default ports (#831193) ...................................................................... core, packaging: Don't use JBoss default ports (#831193) https://bugzilla.redhat.com/831193 This patch changes the default ports used by the engine so that they don't conflict with the default ports used by JBoss. The port numbers proposed are the following: http: 8700 https: 8701 ajp: 8702 remoting: 8703 txn-recovery: 8704 txn-status: 8705 Why these port numbers and not others? 1. They are not allocated according to /etc/services. 2. They are reasonably low. 3. The 8700-8731 range is not allocated by IANA, so we could request them for ovirt-engine, to reduce the chances of conflicts in the future. 4. 8700 is reasonabley easy to remember. 5. They are reasonably far away from the ranges used by VNC and spice displays of virtual machines. Change-Id: I3c0ffcab66fe9ae6f3dcb932040feb4421e18bf6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/conf/engine.conf.defaults M backend/manager/conf/standalone.xml M backend/manager/dbscripts/config_devel.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/LinkHelperTest.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/error-notifier.conf M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/notifier.conf M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M packaging/fedora/engine-service.xml.in M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/ovirt_port80.py 16 files changed, 36 insertions(+), 36 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c0ffcab66fe9ae6f3dcb932040feb4421e18bf6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0