- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: vm migration in case of failure is..(#818289)
by emesika＠redhat.com 28 Aug '12

28 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: vm migration in case of failure is..(#818289) ...................................................................... core: vm migration in case of failure is..(#818289) ovirt-engine-backend [Task Manager]: vm migration in case of failure is not logged in task manager. https://bugzilla.redhat.com/show_bug.cgi?id=818289 The bug was that not all calls to VdcActionType.SetNonOperationalVds set the job execution context. Adding creation of job execution context to all places where a call to VdcActionType.SetNonOperationalVds is issued. Change-Id: I0d4599498f3c604c703e008601b1bc5f4972fe51 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsCpuFlagsOrClusterChangedCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 5 files changed, 10 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d4599498f3c604c703e008601b1bc5f4972fe51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Updated backups folder creation
by juan.hernandez＠redhat.com 27 Aug '12

27 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated backups folder creation ...................................................................... packaging: Updated backups folder creation Change-Id: I0e79b78f4448bbe5f20b4836983e916b60c06acd Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alex Lourie: Verified; Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e79b78f4448bbe5f20b4836983e916b60c06acd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Deatch network doesn't closed in case of an error ...
by alkaplan＠redhat.com 27 Aug '12

27 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Deatch network doesn't closed in case of an error (#849889) ...................................................................... webadmin: Deatch network doesn't closed in case of an error (#849889) https://bugzilla.redhat.com/849889 If after detaching a network from a vm the is an error, the detach dialog remain open. Change-Id: I156a2d0cbbd559fed6966fcffad571545a7f1518 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I156a2d0cbbd559fed6966fcffad571545a7f1518 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add confirm dialog to "save network configuration"...
by alkaplan＠redhat.com 27 Aug '12

27 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add confirm dialog to "save network configuration" (#823922) ...................................................................... webadmin: Add confirm dialog to "save network configuration" (#823922) https://bugzilla.redhat.com/823922 The dialog should be added just to the "save network configuration" action on SubTabHostInterface, not to the check box on (SetupNetwork, Add/Edit, detach...) Change-Id: Ic36412f1075b13ec34a4f959a4ab615ed18ae03e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 57 insertions(+), 20 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic36412f1075b13ec34a4f959a4ab615ed18ae03e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix potential NPE in MainTabHostView
by ecohen＠redhat.com 27 Aug '12

27 Aug '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Fix potential NPE in MainTabHostView ...................................................................... webadmin: Fix potential NPE in MainTabHostView In Host "Load" column, fixed potential NPE coming from getProgressValue() method. Change-Id: I2552b3a917b848472ba9964e49d0e60d45cba0d3 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2552b3a917b848472ba9964e49d0e60d45cba0d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: call AttachDiskToVm with RunAction (#849443)
by derez＠redhat.com 27 Aug '12

27 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: call AttachDiskToVm with RunAction (#849443) ...................................................................... webadmin: call AttachDiskToVm with RunAction (#849443) https://bugzilla.redhat.com/849443 Calling AttachDiskToVm using RunAction instead of RunMultipleAction - in order to ensure PCI limit check (regarding IDE/virtIO disks limit). Change-Id: Ic771ef86926c471ed46524c77a0fdfafc00c63cf Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 5 files changed, 53 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic771ef86926c471ed46524c77a0fdfafc00c63cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added functions references for cleaner code.
by juan.hernandez＠redhat.com 27 Aug '12

27 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Added functions references for cleaner code. ...................................................................... packaging: Added functions references for cleaner code. Change-Id: Ic8fec87bf8dc99e990cb62d85e2915246f38fbac Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fec87bf8dc99e990cb62d85e2915246f38fbac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: use cached /filter argument rather than demanding it in...
by mpastern＠redhat.com 27 Aug '12

27 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: use cached /filter argument rather than demanding it in methods ...................................................................... sdk: use cached /filter argument rather than demanding it in methods Filter header value cached during proxy .ctr initiation and then reused instead of asking for it in different methods Change-Id: I45d2b7899035b64cfda0abce5a68287fd323ac1a Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/doc/documentation.py M src/codegen/imp/imprt.py M src/codegen/utils/headerutils.py M src/ovirtsdk/infrastructure/brokers.py 4 files changed, 51 insertions(+), 60 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45d2b7899035b64cfda0abce5a68287fd323ac1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com 27 Aug '12

27 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api ...................................................................... sdk: rebase to latest api added correlation_id to: - restore snapshot - detach HostNIC Change-Id: I9e53fc7d3cf85ea5704d48090f8fea4536693a3d Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 259 insertions(+), 165 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e53fc7d3cf85ea5704d48090f8fea4536693a3d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add 3.1 Features To Capabilities
by oliel＠redhat.com 27 Aug '12

27 Aug '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Add 3.1 Features To Capabilities ...................................................................... restapi: Add 3.1 Features To Capabilities Change-Id: Ic20e90027722febc173c833b7c872856e7829147 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java 5 files changed, 262 insertions(+), 16 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20e90027722febc173c833b7c872856e7829147 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0