- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Remove Wrong Template Links
by oliel＠redhat.com 27 Aug '12

27 Aug '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Remove Wrong Template Links ...................................................................... restapi: Remove Wrong Template Links Change-Id: Ic4665bbac339d4c3ed1e701bc3105fb407de20cc Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4665bbac339d4c3ed1e701bc3105fb407de20cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: 500 instead of 404 for api/events/search
by oliel＠redhat.com 27 Aug '12

27 Aug '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: 500 instead of 404 for api/events/search ...................................................................... restapi: 500 instead of 404 for api/events/search Change-Id: Icf2a7f2abcc3ddae675c6ec2f677380ed25ac121 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf2a7f2abcc3ddae675c6ec2f677380ed25ac121 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add 'unknown' status to Power Management
by oliel＠redhat.com 27 Aug '12

27 Aug '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Add 'unknown' status to Power Management ...................................................................... restapi: Add 'unknown' status to Power Management Change-Id: I53225ed72745d3a7c5ba97ed3a516f8bc8665ed6 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PowerManagementStatus.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53225ed72745d3a7c5ba97ed3a516f8bc8665ed6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Move defaults out of service script
by juan.hernandez＠redhat.com 27 Aug '12

27 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Move defaults out of service script ...................................................................... packaging: Move defaults out of service script We used to have the defaults values for local engine configuration files hardcoded in the service start/stop script. This means that other tools need to duplicate these values. This change moves the default values to a separate plain file that can be easily consumed by all kinds of programs. The file will be stored in /usr/share/ovirt-engine because it is *not* a configuration file. Change-Id: I062bb033bf20db9a0d68b8286151345a3653cb03 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile A backend/manager/conf/engine.conf.defaults M packaging/fedora/engine-service.py M packaging/fedora/engine-service.sysconfig M packaging/fedora/engine-service.xml.in 5 files changed, 221 insertions(+), 146 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I062bb033bf20db9a0d68b8286151345a3653cb03 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: sysprep.inf contents are visible in engine.log (#84966...
by oourfali＠redhat.com 27 Aug '12

27 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: sysprep.inf contents are visible in engine.log (#849666) ...................................................................... core: sysprep.inf contents are visible in engine.log (#849666) https://bugzilla.redhat.com/849666 When VDSM returs VM devices without address, an information message with the device details is printed to the log. In the sysprep case, it is a floppy device, which may contain sensitive information. This patch will not print the details of floppy devices. Change-Id: I5b9825ef299272ce2d6e9ea3bdecc92bcd1a78cc Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 32 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b9825ef299272ce2d6e9ea3bdecc92bcd1a78cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: rename V.Disks sub-tabs to Disks (#850749)
by derez＠redhat.com 27 Aug '12

27 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: rename V.Disks sub-tabs to Disks (#850749) ...................................................................... webadmin: rename V.Disks sub-tabs to Disks (#850749) https://bugzilla.redhat.com/850749 Renamed all 'Virtual Disks' sub-tabs to 'Disks'. Change-Id: Id469b62f26e95c0e8d27a8ed8f1e9d9649ff6d81 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 8 files changed, 11 insertions(+), 14 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id469b62f26e95c0e8d27a8ed8f1e9d9649ff6d81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: Check ENGINE_PROXY_ENABLED correctly
by ydary＠redhat.com 27 Aug '12

27 Aug '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Check ENGINE_PROXY_ENABLED correctly ...................................................................... packaging: Check ENGINE_PROXY_ENABLED correctly Currently the setup only checks if this configuration is present, but it should check if it is present and if it is value is true. Change-Id: I7e7819b51ef8f6a91bc3c1c4e7389c034bc6567b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e7819b51ef8f6a91bc3c1c4e7389c034bc6567b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, ui: prevent cow shareable disk creation (#848021)
by derez＠redhat.com 27 Aug '12

27 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: core,ui: prevent cow shareable disk creation (#848021) ...................................................................... core,ui: prevent cow shareable disk creation (#848021) https://bugzilla.redhat.com/848021 Preventing creation of shareable DiskImage that is COW formatted (since the combination is unsupported). core: * Added validations to AddDiskCommand and UpdateVmDiskCommand (updated tests accordingly). * Added error messages in VdcBllMessages and AppErrors. ui: * Added validations to 'Add Disk' dialog (I.e. disabled Shareable check-box for unsupported combinations). Change-Id: Ie9594978c0b509fd540803e9dc4137266bd0501b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 230 insertions(+), 29 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9594978c0b509fd540803e9dc4137266bd0501b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Cant add correlation id to detach HostNIC #851031
by mpastern＠redhat.com 27 Aug '12

27 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Cant add correlation id to detach HostNIC #851031 ...................................................................... restapi: Cant add correlation id to detach HostNIC #851031 https://bugzilla.redhat.com/show_bug.cgi?id=851031 Change-Id: Ied9786ee4f7e3542269bbecd1a3d1de545abfd08 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied9786ee4f7e3542269bbecd1a3d1de545abfd08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Cant add correlation id to restore snapshot #851232
by mpastern＠redhat.com 27 Aug '12

27 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Cant add correlation id to restore snapshot #851232 ...................................................................... restapi: Cant add correlation id to restore snapshot #851232 https://bugzilla.redhat.com/show_bug.cgi?id=851232 Change-Id: I4446db705d3bb3713b6adef2b74c7c9f81179d74 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4446db705d3bb3713b6adef2b74c7c9f81179d74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0