- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Cleanup quota view (#848107)
by gchaplik＠redhat.com 26 Aug '12

26 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Cleanup quota view (#848107) ...................................................................... webadmin: Cleanup quota view (#848107) Cleanup, number format fix and constants added in edit quota popup and quota subtub. Change-Id: Ib27be9b4cec1bf515a6759e38ad1f9349be5b771 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaStorage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaVdsGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java 4 files changed, 35 insertions(+), 15 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib27be9b4cec1bf515a6759e38ad1f9349be5b771 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: UI: Host load progress overlap when there is more then 100 V...
by gchaplik＠redhat.com 26 Aug '12

26 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: UI: Host load progress overlap when there is more then 100 VMs (#849668) ...................................................................... UI: Host load progress overlap when there is more then 100 VMs (#849668) https://bugzilla.redhat.com/show_bug.cgi?id=849668 Change-Id: Ie6d24f0bf341376178f26c3d3eae8bab86d15e35 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6d24f0bf341376178f26c3d3eae8bab86d15e35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Commenting out powermock based tests
by yzaslavs＠redhat.com 26 Aug '12

26 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Commenting out powermock based tests ...................................................................... core: Commenting out powermock based tests The following patch comments out several tests using powermock, in order to remove powermock dependency from the code Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6586 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandlerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapTester.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapperTest.java 4 files changed, 1,742 insertions(+), 1,718 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6586 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: enhance storage error message (#842146)
by oourfali＠redhat.com 26 Aug '12

26 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: enhance storage error message (#842146) ...................................................................... core: enhance storage error message (#842146) https://bugzilla.redhat.com/842146 When failing to import a storage domain, the real source of the problem is printed to the event log, so changing the message to direct the user to the event log to get more details. Also, adding code 477 translation to the backend (mount problems). Change-Id: I1f842b6b1740996c30d87527053f5980331f0ce6 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 6 files changed, 7 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/7428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f842b6b1740996c30d87527053f5980331f0ce6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: NPE in ImportVmTemplate (#844396)
by mkolesni＠redhat.com 26 Aug '12

26 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: NPE in ImportVmTemplate (#844396) ...................................................................... core: NPE in ImportVmTemplate (#844396) https://bugzilla.redhat.com/844396 Refer to subject. Change-Id: I5c854b1370d9fb6e9c3d79ef46873c53225b6af5 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c854b1370d9fb6e9c3d79ef46873c53225b6af5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: path count shows incorrect number on luns>targets ...
by asaf＠redhat.com 26 Aug '12

26 Aug '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: path count shows incorrect number on luns>targets (#838912) ...................................................................... webadmin: path count shows incorrect number on luns>targets (#838912) https://bugzilla.redhat.com/838912 When logging into a new target the new LUNs are merged into a cached list which contains the previouse loaded LUNs, If the cached list already contains a new LUN which has been updated with new details, the new LUN won't be merged, This patch updates existing cached LUNs in case there is a new version available after target login. Change-Id: I7f700b411b119310b554a17f8447fc51c554d1ff Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f700b411b119310b554a17f8447fc51c554d1ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Obtain old network name from correct NIC (#849971)
by mkolesni＠redhat.com 26 Aug '12

26 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Obtain old network name from correct NIC (#849971) ...................................................................... engine: Obtain old network name from correct NIC (#849971) https://bugzilla.redhat.com/849971 The old network name should be taken from the NIC it's defined on. If there is more than one network defined on the given NICs, this command can't handle it and should fail. VLANs are also handled since a NIC can have several VLANs based on it which in turn can have networks attached to them. Change-Id: I1311be342aa72bac9f1b79cec816be52f37d966d Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1311be342aa72bac9f1b79cec816be52f37d966d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Change iteration to foreach (#849971)
by mkolesni＠redhat.com 26 Aug '12

26 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Change iteration to foreach (#849971) ...................................................................... engine: Change iteration to foreach (#849971) https://bugzilla.redhat.com/849971 Iterate using foreach instead of LinqUtils. This way the loop can be extended to do other things as well, besides finding a single element. Change-Id: I2fbb9bf14ed5f94b2e74ab6bfde39e959300b31d Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fbb9bf14ed5f94b2e74ab6bfde39e959300b31d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add message that more than one network attached (#8499...
by mkolesni＠redhat.com 26 Aug '12

26 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add message that more than one network attached (#849971) ...................................................................... core: Add message that more than one network attached (#849971) https://bugzilla.redhat.com/849971 The message is necessary to stop actions (such as update network on interfaces) where there is more than one network attached, where there is no support for such a situation. Change-Id: I22a75bb644367921a7ef69d44cd3316e7f9f8fb0 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 7 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22a75bb644367921a7ef69d44cd3316e7f9f8fb0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use interfaceBasedOn where appropriate (#849971)
by mkolesni＠redhat.com 26 Aug '12

26 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Use interfaceBasedOn where appropriate (#849971) ...................................................................... engine: Use interfaceBasedOn where appropriate (#849971) https://bugzilla.redhat.com/849971 Use the new interfaceBasedOn method where it is appropriate. Change-Id: I5698cf5e76aaac20e84f4283165d13406b1f981c Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllChildVlanInterfacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVlanParanetQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 5 files changed, 7 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5698cf5e76aaac20e84f4283165d13406b1f981c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0