- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: autocompletion support for NULL (#845297)
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: autocompletion support for NULL (#845297) ...................................................................... core: autocompletion support for NULL (#845297) https://bugzilla.redhat.com/845297 Autocompletion support for search queries Change-Id: Ide95b10b7ee5e94af1a9413c48c32820d3cd70da Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NullableStringAutoCompleter.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/SearchBackend.gwt.xml 2 files changed, 35 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide95b10b7ee5e94af1a9413c48c32820d3cd70da Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SyntaxChecker cleanup V
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SyntaxChecker cleanup V ...................................................................... core: SyntaxChecker cleanup V - moves the processing logic to generateSafeConditionStatement, only - the old generateConditionStatment is generating a safeValue, this value is passed over to generateSafeConditionStatement, the originalValue and isSafe are no longer passed Change-Id: I4034db4e89dfd4450a3d2f01c8adbd018e914468 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4034db4e89dfd4450a3d2f01c8adbd018e914468 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SyntaxChecker cleanup IV
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SyntaxChecker cleanup IV ...................................................................... core: SyntaxChecker cleanup IV - refactored customizedRelation initialization to a separate method (buildCustomizedRelation) Change-Id: I76c4c8acd6e4236027927c74d8daa0fbda0a51cb Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 33 insertions(+), 13 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c4c8acd6e4236027927c74d8daa0fbda0a51cb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SyntaxChecker cleanup III
by lhornyak＠redhat.com 10 Aug '12

10 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SyntaxChecker cleanup III ...................................................................... core: SyntaxChecker cleanup III - refactored the computation of the customizedValue value to a new method (buildCustomizedValue) Change-Id: I3bfa411978cff11db35069f5bf363dbedbb881ba Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 36 insertions(+), 19 deletions(-) Approvals: Laszlo Hornyak: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bfa411978cff11db35069f5bf363dbedbb881ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Option with empty name and value ...
by emesika＠redhat.com 10 Aug '12

10 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Option with empty name and value ... ...................................................................... core: Option with empty name and value ... Option with empty name and value in the request's xml to rest-api should not be allowed. The problem is not with the PM options, this is working without a problem. There is a leading blank in the UUID of the DC in the request that caused the exception. Adding a check for DC ID validity in canDoAction of ConnectStorageToVdsCommand command. Change-Id: I8d53cc13dc6669e02020cf1a5bfacb4fc1285b74 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d53cc13dc6669e02020cf1a5bfacb4fc1285b74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: misleading error when trying to fen(#843168)
by emesika＠redhat.com 10 Aug '12

10 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core: misleading error when trying to fen(#843168) ...................................................................... core: misleading error when trying to fen(#843168) ovirt-engine-backend: misleading error when trying to fence host without PM configured https://bugzilla.redhat.com/843168 Problem was that the code in the canDoAction of the base class was not adding any message if fencing is not configured in the host and also retries the operation event though there is no chance that it will succeed. Changing the code to add a message when Start/Stop is called on a non configured Host. Make StopVdsCommand call the super.canDoAction in the same manner as StartVdsCommand does. Change-Id: I7aab4f6a7c70fa5e18db106ea15a7b20b709db28 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java 2 files changed, 10 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aab4f6a7c70fa5e18db106ea15a7b20b709db28 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:we do not clean alerts from the weba(#840495)
by emesika＠redhat.com 10 Aug '12

10 Aug '12

Eli Mesika has submitted this change and it was merged. Change subject: core:we do not clean alerts from the weba(#840495) ...................................................................... core:we do not clean alerts from the weba(#840495) we do not clean alerts from the webadmin once fixed https://bugzilla.redhat.com/840495 Changing the Alert text as suggested in the bug. Change-Id: Iefc3d948e73403933a1ea129a7c50818fedcf610 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefc3d948e73403933a1ea129a7c50818fedcf610 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Updated SPICE cab download fix (#846341)
by ecohen＠redhat.com 09 Aug '12

09 Aug '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Updated SPICE cab download fix (#846341) ...................................................................... webadmin: Updated SPICE cab download fix (#846341) https://bugzilla.redhat.com/846341 Before this patch, this was the situation: class Configurator { protected abstract Event getSpiceVersionFileFetchedEvent(); // Configurator c'tor public Configurator() { ... ... updateSpiceVersion(); } private void updateSpiceVersion() { doSomething(getSpiceVersionFileFetchedEvent()); } } --- class WebAdminConfigurator extends Configurator { public Event spiceVersionFileFetchedEvent = [initialized]; // WebAdminConfigurator c'tor public WebAdminConfigurator(EventBus eventBus) { super(); ... ... } @Override protected Event getSpiceVersionFileFetchedEvent() { return spiceVersionFileFetchedEvent; } } In the WebAdminConfigurator c'tor, there is a call to "super()", i.e., Configurator c'tor, that calls to updateSpiceVersion(), which calls to getSpiceVersionFileFetchedEvent(). getSpiceVersionFileFetchedEvent() is an abstract method in Configurator. Its "implementation" (override) in WebAdminConfigurator returns the spiceVersionFileFetchedEvent member which, theoretically, should be initialized with the "[initialized]" value. However, practically, since the above is happenning during the base class (Configurator) c'tor execution, the WebAdminConfigurator members' initialization hasn't occurred yet, therefore, "spiceVersionFileFetchedEvent" is actually null, and not initialized to "[initialized]" yet. This prevents the "post-fetch-spice-version-file" event from being treated by the relevant event handler, hence the actual server-side SPICE ActiveX cab version is not updated appropriately within the configurator; so the server-side spice-version value practically supplied by the Configurator is the default hard-coded value with which the spiceVersion Configurator member was initialized, i.e. "4.4". So in case the client has a spice ActiveX with a version greater than 4.4, it won't download the SPICE ActiveX cab from the server, since the client thinks that the version of the server-side cab is 4.4, i.e., less than what is currently installed, so no reason to download and upgrade the ActiveX. If the actual version of the server-side cab is greater than 4.4, it can cause a buggy behavior in case client is installed with a version smaller than the actual server-side version: Updated server-side cab should be downloaded to the client since its actual version is larger than the one installed on the client, but due to this bug - it won't happen. E.g.: - reported (buggy) server-side SPICE version: 4.4 - actual server-side SPICE version: 5.0 - SPICE version installed on the client: 4.8. - client asks server for the server-side-SPICE version. - server returns: 4.4 - client compares currently-installed version (4.8) against server-side version (4.4) -> 4.4 is smaller than 4.8 -> client concludes that there is no need to download server-side cab. This is incorrect behavior - actual server-side SPICE version is 5.0, and *should* be downloaded to the client in this case. In this patch, the call to updateSpiceVersion() is done in the WebAdminConfigurator (and UserPortalConfigurator) c'tor, instead of the Configurator c'tor, in a stage in which the spiceVersionFileFetchedEvent member is already initialized; Therefore, once the SPICE version txt file is fetched and read, the version is updated correctly within the configurator, server reports correct version of server-side cab, hence client downloads updated server-side cab when it should. Change-Id: I100e722ed85554451d51e9ddb73f3bb35522684f Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 3 files changed, 7 insertions(+), 4 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I100e722ed85554451d51e9ddb73f3bb35522684f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: text fix engine->Engine (#845430)
by derez＠redhat.com 09 Aug '12

09 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: text fix engine->Engine (#845430) ...................................................................... webadmin: text fix engine->Engine (#845430) https://bugzilla.redhat.com/845430 "Verify connectivity between Host and engine" -> "Verify connectivity between Host and Engine" Change-Id: I89c8bacd8bb0742b2765b752c197adfdbf9edae8 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89c8bacd8bb0742b2765b752c197adfdbf9edae8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: bug fix in unmanaged networks (#820504)
by derez＠redhat.com 09 Aug '12

09 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: bug fix in unmanaged networks (#820504) ...................................................................... webadmin: bug fix in unmanaged networks (#820504) https://bugzilla.redhat.com/820504 If a network is vlan-ed the implementation details are on the nic.vlanId and not nic. In isManaged and isInSync it read the details from the nic and not nic.vlan_id Change-Id: Ie42e349be4873e44a5c6ee71671d6c630e58342c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie42e349be4873e44a5c6ee71671d6c630e58342c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0