- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: SyntaxChecker cleanup II
by lhornyak＠redhat.com 09 Aug '12

09 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SyntaxChecker cleanup II ...................................................................... core: SyntaxChecker cleanup II - java.util import instead of fqn - more variable.equals("CONSTANT") to "CONSTANT".equals(variable) Change-Id: I0f95ffd0f437bf0eb5f189990a01a97d58974d99 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f95ffd0f437bf0eb5f189990a01a97d58974d99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SyntaxChecker cleanup I
by lhornyak＠redhat.com 09 Aug '12

09 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: SyntaxChecker cleanup I ...................................................................... core: SyntaxChecker cleanup I - final parameters in overcomplicated functions where possible, so that they can be tracked easily - variable.equals("CONSTANT") and StringHelper.EqOp(variable, "CONSTANT") replaced by "CONSTANT".equals(variable) - some decision factored out to new methods Change-Id: I8da7918b8c048af46313d99663e44142118eee49 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 30 insertions(+), 17 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8da7918b8c048af46313d99663e44142118eee49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: port mirroring should be enabled just for 3.1 and ...
by gchaplik＠redhat.com 09 Aug '12

09 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: port mirroring should be enabled just for 3.1 and upper (#846025) ...................................................................... webadmin: port mirroring should be enabled just for 3.1 and upper (#846025) https://bugzilla.redhat.com/846025 Port mirroring should bne enabed in vnic dialogs with cluster 3.1 and upper otherwise- disabled. Change-Id: Ie77035a3197ea284d68de35825f738e182274264 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie77035a3197ea284d68de35825f738e182274264 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove the word ovirt from SetupNetworks dialog (#...
by masayag＠redhat.com 09 Aug '12

09 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: remove the word ovirt from SetupNetworks dialog (#845430) ...................................................................... webadmin: remove the word ovirt from SetupNetworks dialog (#845430) https://bugzilla.redhat.com/845430 Change "Verify connectivity between Host and ovirt-engine" to "Verify connectivity between Host and engine" Change-Id: I92deb3fd40d88be5bfacc92f72ebd63f1c64e686 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92deb3fd40d88be5bfacc92f72ebd63f1c64e686 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix wrong text (#835533)
by masayag＠redhat.com 09 Aug '12

09 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: fix wrong text (#835533) ...................................................................... webadmin: fix wrong text (#835533) https://bugzilla.redhat.com/show_bug.cgi?id=835533 UnAssign->Unassign UnManaged->Unmanaged Change-Id: I5a4ee8855dceaaac5fb5b43f0d8dfae0794fb250 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a4ee8855dceaaac5fb5b43f0d8dfae0794fb250 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: localization of SetupNetworks (#840842)
by masayag＠redhat.com 09 Aug '12

09 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: localization of SetupNetworks (#840842) ...................................................................... webadmin: localization of SetupNetworks (#840842) https://bugzilla.redhat.com/840842 Change-Id: Iac30cc55d2b16d5abb88da9b3aa62df05da91008 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java 6 files changed, 49 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac30cc55d2b16d5abb88da9b3aa62df05da91008 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improve tests to expect violating entity (#844158)
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Improve tests to expect violating entity (#844158) ...................................................................... engine: Improve tests to expect violating entity (#844158) https://bugzilla.redhat.com/844158 The SetupNetworksHelperTest that expects a violation will now expect also that the key for the violating entity will be filled with correct value. Change-Id: I8b21418b7ef8f1ede06155ffd8cedb15e2336b5b Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 2 files changed, 41 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b21418b7ef8f1ede06155ffd8cedb15e2336b5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed old add violation command (#844158)
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Removed old add violation command (#844158) ...................................................................... engine: Removed old add violation command (#844158) https://bugzilla.redhat.com/844158 This method is no longer used, so remove it. Change-Id: Ie26934df3ac073028699a6814b9de22e90b82cad Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie26934df3ac073028699a6814b9de22e90b82cad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: engine: Replace message of too few bond slaves (#844158)
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Replace message of too few bond slaves (#844158) ...................................................................... engine: Replace message of too few bond slaves (#844158) https://bugzilla.redhat.com/844158 The new message will contain a list of all bonds that have less than two slaves. Change-Id: Ide2b0ce81703850c86fb405281a9ab6b8c1a3536 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 10 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide2b0ce81703850c86fb405281a9ab6b8c1a3536 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replace message of network not exists (#844158)
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Replace message of network not exists (#844158) ...................................................................... engine: Replace message of network not exists (#844158) https://bugzilla.redhat.com/844158 The new message will contain a list of all networks that don't exist in the cluster. Change-Id: Id455f1d3f664973fb408bbd49307d4a215b3758c Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 10 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id455f1d3f664973fb408bbd49307d4a215b3758c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0