- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Replace message of unsync networks (#844158)
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Replace message of unsync networks (#844158) ...................................................................... engine: Replace message of unsync networks (#844158) https://bugzilla.redhat.com/844158 The old message was specified for one network but more than one network can be out of sync, so changed to a plural message that also lists the network names. Change-Id: I1a3413a5669fe4992f423dccf6a16dc16c2008ba Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 9 insertions(+), 9 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a3413a5669fe4992f423dccf6a16dc16c2008ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replace message of interface not exists (#844158)
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Replace message of interface not exists (#844158) ...................................................................... engine: Replace message of interface not exists (#844158) https://bugzilla.redhat.com/844158 The new message will contain a list of all nics that were specified (either directly or as part of a vlan device name) but don't actually exist on the host. Change-Id: Iffe581725ead596ba2b43e6ce96b966b6bae5c10 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 11 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe581725ead596ba2b43e6ce96b966b6bae5c10 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replace message of network already attached (#844158...
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Replace message of network already attached (#844158) ...................................................................... engine: Replace message of network already attached (#844158) https://bugzilla.redhat.com/844158 The new message will contain a list of all networks that are attached more than one NIC. Change-Id: I31c2a5bca0968b6189e974d644f988e0c854f84a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 8 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31c2a5bca0968b6189e974d644f988e0c854f84a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replace message of nic specified more than once (#84...
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Replace message of nic specified more than once (#844158) ...................................................................... engine: Replace message of nic specified more than once (#844158) https://bugzilla.redhat.com/844158 The new message will contain a list of all nics that were specified more than once. It replaces 2 old messages, which had no real use-case for distinction between bond and not bond in this case. Change-Id: Ic18fe73d154cc8e7b3cd186158ce64845f0f3d97 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 9 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic18fe73d154cc8e7b3cd186158ce64845f0f3d97 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change violations to Map (#844158)
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Change violations to Map (#844158) ...................................................................... engine: Change violations to Map (#844158) https://bugzilla.redhat.com/844158 Changed violations list to be a Map in order to allow generating a list of offending entities (which will be generated by the pattern "{KEY}_LIST" where {KEY} is the violation name). Also added a method to add a violating entity to the map for following patches to start using. Change-Id: Ic70f4d93e1ca06a9991e6e443e92f6be11fc88d4 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java 1 file changed, 21 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic70f4d93e1ca06a9991e6e443e92f6be11fc88d4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add method to add violation (#844158)
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add method to add violation (#844158) ...................................................................... engine: Add method to add violation (#844158) https://bugzilla.redhat.com/844158 This method will help abstract the implementation of how violations are saved exactly. Change-Id: Icba581724d1f9fdb56fd195fd2c6e08e1983cabb Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icba581724d1f9fdb56fd195fd2c6e08e1983cabb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change return of violation to list of String (#84415...
by mkolesni＠redhat.com 09 Aug '12

09 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Change return of violation to list of String (#844158) ...................................................................... engine: Change return of violation to list of String (#844158) https://bugzilla.redhat.com/844158 This return value is more versatile, and will allow to translate the violations into ones which contain a list of offending entities. Change-Id: Ifae8dedd4265146b56c4b130ad5cbff64c89212f Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 3 files changed, 15 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifae8dedd4265146b56c4b130ad5cbff64c89212f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: use allow viewing children only in disks, templates an...
by oourfali＠redhat.com 09 Aug '12

09 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: use allow viewing children only in disks, templates and VMs (#846300) ...................................................................... core: use allow viewing children only in disks, templates and VMs (#846300) https://bugzilla.redhat.com/show_bug.cgi?id=846300 This patch is one of the patches for fixing the bug above. Previous commit added the ability to specify whether an action group allows to view the children on the granted object or not. This ability to specify that is relevant only for specific object types, which are disks, templates and VMs, so this patch removes it from all the other objects in the system. Change-Id: I4dfecc6e433f13e773532864fafd44d9ffe8c7d0 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dfecc6e433f13e773532864fafd44d9ffe8c7d0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: make user-API relevant queries to be user queries (#84...
by oourfali＠redhat.com 09 Aug '12

09 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: make user-API relevant queries to be user queries (#846300) ...................................................................... core: make user-API relevant queries to be user queries (#846300) https://bugzilla.redhat.com/show_bug.cgi?id=846300 This patch is one of the patches for fixing the bug above. In order to allow users to view datacenters and storage domains in the user level API, we need to allow them to run the queries GetStorageServerConnectionById and GetAvailableStoragePoolVersions. Change-Id: I2953ea0709f7a9acb7de81ad43da442fc19734e2 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableStoragePoolVersionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java 3 files changed, 17 insertions(+), 14 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2953ea0709f7a9acb7de81ad43da442fc19734e2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: Granting AddPermission to some admin roles (#845026...
by oourfali＠redhat.com 09 Aug '12

09 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: backend: Granting AddPermission to some admin roles (#845026) ...................................................................... backend: Granting AddPermission to some admin roles (#845026) https://bugzilla.redhat.com/845026 The "AddPermission" action group was missing from some predefined roles: 1. DC admin 2. Cluster admin 3. User VM manager 4. Template owner 5. Disk operator This patch grants this action group to these roles. Change-Id: I47a2e7aff362ddbe7fb95a05cc74a253080c5bf1 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1350_add_AddPermission_to_roles.sql 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47a2e7aff362ddbe7fb95a05cc74a253080c5bf1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0