- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: Improve the automation scripts
by omachace＠redhat.com 03 Oct '16

03 Oct '16

Ondra Machacek has submitted this change and it was merged. Change subject: Improve the automation scripts ...................................................................... Improve the automation scripts This patch improves the automation scripts so that they decide automatically when to do release or scratch builds. Release builds will be automatically performed when the version in the POM file doesn't contain the -SNAPSHOT suffix. Change-Id: Iff51dd8a7ea3a0accf4a80bdb6faf1c263330bf4 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A automation/build-artifacts.packages.el7 D automation/build-artifacts.packages.fc23 D automation/build-artifacts.packages.fc24 A automation/build-artifacts.packages.fc24 D automation/build-artifacts.sh A automation/build-artifacts.sh R automation/build.packages A automation/build.py D automation/check-merged.packages A automation/check-merged.packages D automation/check-merged.sh A automation/check-merged.sh D automation/check-patch.packages.el7 A automation/check-patch.packages.el7 D automation/check-patch.packages.fc23 D automation/check-patch.packages.fc24 A automation/check-patch.packages.fc24 D automation/check-patch.sh A automation/check-patch.sh D automation/version.py M generator/pom.xml D packaging/build.sh M packaging/spec.el7.in M packaging/spec.fc24.in R packaging/spec.fc25.in M pom.xml M sdk/pom.xml 27 files changed, 342 insertions(+), 285 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff51dd8a7ea3a0accf4a80bdb6faf1c263330bf4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VM dialog mem leak
by awels＠redhat.com 03 Oct '16

03 Oct '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: VM dialog mem leak ...................................................................... webadmin: VM dialog mem leak - Fixed memory leaks in the VM dialog. Change-Id: I53c22111275458753bdabc43f710b9e837a59a46 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368101 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/HasDataListModelEditorAdapter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ManagePolicyUnitPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java 13 files changed, 66 insertions(+), 27 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64470 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53c22111275458753bdabc43f710b9e837a59a46 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix confirmation popup issue in host remove
by awels＠redhat.com 03 Oct '16

03 Oct '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fix confirmation popup issue in host remove ...................................................................... webadmin: fix confirmation popup issue in host remove I have introduced a confirmation popup for Host Maintenance in https://gerrit.ovirt.org/#/c/59102/. But same popup provider was used for host removal. This is not correct. Changing it back to use regular RemoveConfirmPopupProvider for host removal. Change-Id: Ib55fb2625f06c81271a93d6a4b82b06ce643927d Bug-Url: https://bugzilla.redhat.com/1379754 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/64890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib55fb2625f06c81271a93d6a4b82b06ce643927d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use 'doReturn' instead of 'when' in RefreshGlusterHo...
by masayag＠redhat.com 02 Oct '16

02 Oct '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use 'doReturn' instead of 'when' in RefreshGlusterHooksCommandTest ...................................................................... engine: Use 'doReturn' instead of 'when' in RefreshGlusterHooksCommandTest Using when on a spied object causes the real method to be called. Change-Id: Icd740d3d9ca5532e22754cd7211c16ecbfa6739a Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sahina Bose: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/64949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd740d3d9ca5532e22754cd7211c16ecbfa6739a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: when breaking bond, we need to remove unmanaged ne...
by masayag＠redhat.com 02 Oct '16

02 Oct '16

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: when breaking bond, we need to remove unmanaged networks as well. ...................................................................... webadmin: when breaking bond, we need to remove unmanaged networks as well. Change-Id: I8a342f0de7db42b8b77a5c394c80d50445dfd31d Bug-Url: https://bugzilla.redhat.com/1360630 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a342f0de7db42b8b77a5c394c80d50445dfd31d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Spy gluster hooks tests
by amureini＠redhat.com 02 Oct '16

02 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: @Spy gluster hooks tests ...................................................................... core: @Spy gluster hooks tests Clean up the gluster hooks tests to use the @Spy annotation to spy the command under test in order to facilitate injecting dependencies to the command in subsequent patches. - Changing the command being tested to be initialized once and annotated with @Spy and @InjectMocks. - Thus, there is only only command object per test, so all the methods receiving commands as parameters were redone to use the member. - Since the command is now a member, it was removed from method signatures. Change-Id: I79fff2e3fb79f55d7054ff1d58ebb2fae3433e83 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommandTest.java 6 files changed, 62 insertions(+), 92 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79fff2e3fb79f55d7054ff1d58ebb2fae3433e83 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVdsCommandTest spying
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVdsCommandTest spying ...................................................................... core: AddVdsCommandTest spying Mocking an object and calling doRetrunRealMethod() on most of its methods is essentially spying it, but with the wrong default (a mocked result instead of the real one). Since the command is the actual object we want to test, it should NOT be mocked, and only the relevant parts (e.g., where it interacts with external resources) should be spied away. Change-Id: I804128d81482a83c26b6da595c6b7162f9492a4c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java 1 file changed, 31 insertions(+), 41 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I804128d81482a83c26b6da595c6b7162f9492a4c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InstallVdsInternalCommandTest constants
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: InstallVdsInternalCommandTest constants ...................................................................... core: InstallVdsInternalCommandTest constants Remove unused constants from the class. Change-Id: I717070c195dcbbfea4eab71e3f2837aad91956b1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I717070c195dcbbfea4eab71e3f2837aad91956b1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StartVdsCommandTest @InjectMocks
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StartVdsCommandTest @InjectMocks ...................................................................... core: StartVdsCommandTest @InjectMocks Use the @InjectMocks annotation to inject mocks to the tested command in order to save some boiler-plated code and make the test cleaner and more concise. Change-Id: I0be6bdb8ac8851c26cd7e27d9a6620364cde49a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/StartVdsCommandTest.java 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0be6bdb8ac8851c26cd7e27d9a6620364cde49a7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RefreshGlusterHooksCommandTest @Spy
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RefreshGlusterHooksCommandTest @Spy ...................................................................... core: RefreshGlusterHooksCommandTest @Spy Clean up RefreshGlusterHooksCommandTest to use the @Spy annotation to spy the command under test in order to facilitate injecting dependencies to the command in subsequent patches. - Changing the command being tested to be initialized once and annotated with @Spy and @InjectMocks. - Thus, there is only only command object per test, so all the methods receiving commands as parameters were redone to use the member. Change-Id: Ic761866ad707894d27a84b4a53fba16067722e0f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommandTest.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic761866ad707894d27a84b4a53fba16067722e0f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0