- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: StartVdsCommandTest @Test annotations
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StartVdsCommandTest @Test annotations ...................................................................... core: StartVdsCommandTest @Test annotations Removed a useless empty argument list from the annotation. Change-Id: Ia2d51eda238319f07b4884b3141eef632b755867 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/StartVdsCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2d51eda238319f07b4884b3141eef632b755867 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddExternalJobCommandTest mocking
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddExternalJobCommandTest mocking ...................................................................... core: AddExternalJobCommandTest mocking Remove the redundant (and wrong!) mocking from the test. Change-Id: Icac78a12426615c1ad284d21f8aa1d649bac9e71 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddExternalJobCommandTest.java 1 file changed, 7 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icac78a12426615c1ad284d21f8aa1d649bac9e71 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddExternalJobCommandTest mock logger
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddExternalJobCommandTest mock logger ...................................................................... core: AddExternalJobCommandTest mock logger Remove the unused mocked logger. Change-Id: I3957f3671987c7b77e15d532862cabf4e0286762 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddExternalJobCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3957f3671987c7b77e15d532862cabf4e0286762 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateVdsCommandTest spying
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVdsCommandTest spying ...................................................................... core: UpdateVdsCommandTest spying Mocking an object and calling doRetrunRealMethod() on most of its methods is essentially spying it, but with the wrong default (a mocked result instead of the real one). Since the command is the actual object we want to test, it should NOT be mocked, and only the relevant parts (e.g., where it interacts with external resources) should be spied away. Change-Id: I505bfbaead2ea2f5b34971dee4b6dbc074f2fe3b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommandTest.java 1 file changed, 35 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I505bfbaead2ea2f5b34971dee4b6dbc074f2fe3b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVdsCommandTest mocks
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVdsCommandTest mocks ...................................................................... core: AddVdsCommandTest mocks Remove redundant mocks. Change-Id: I5e8fa2d530ae9f6000b11edbed02f3f602312e98 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e8fa2d530ae9f6000b11edbed02f3f602312e98 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVdsCommandTest un-@Ignore test
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVdsCommandTest un-@Ignore test ...................................................................... core: AddVdsCommandTest un-@Ignore test The message in the @Ignore annotation is unclear, and seems outdated as the test clearly runs and passes. This patch removes the redundant annotation and allows another test to run. Change-Id: I33ff10328b30b1806c53065753fcf5501a1da6c5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33ff10328b30b1806c53065753fcf5501a1da6c5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddExternalStepCommandTest mock logger
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddExternalStepCommandTest mock logger ...................................................................... core: AddExternalStepCommandTest mock logger Remove the unused mocked logger. Change-Id: I62cce256881a5c6c16112ec589092d3b85e1c561 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddExternalStepCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62cce256881a5c6c16112ec589092d3b85e1c561 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveVdsComamndTest#mockHasVolumeOnServer javadoc
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVdsComamndTest#mockHasVolumeOnServer javadoc ...................................................................... core: RemoveVdsComamndTest#mockHasVolumeOnServer javadoc Remove a wrong parameter from the javadoc. Change-Id: Idaab19bc2f132924ade97c23a701129ec5c876b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaab19bc2f132924ade97c23a701129ec5c876b8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveVdsCommandTest @Spy
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVdsCommandTest @Spy ...................................................................... core: RemoveVdsCommandTest @Spy Use the @Spy annotation to spy the command being tested in order to allow injecting mocks in subsequent patches. This patch includes: - Changing the command being tested to be initialized once and annotated with @Spy and @InjectMocks. - Thus, there is only only command object per test, so all the methods receiving commands as parameters were redone to use the member. - Removed redundant mocking. - Wherever possible, these now argument-less methods were annotated with @Before to avoid having to call them explicitly in each test. - Setters were added to the parameter class to allow changing its properties after the command has been created. Change-Id: If956ce1c275bb2daa83e49aba7a347d83f52f81f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java 2 files changed, 12 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If956ce1c275bb2daa83e49aba7a347d83f52f81f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateCluserCommandTest single StoragePoolDao
by amureini＠redhat.com 01 Oct '16

01 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateCluserCommandTest single StoragePoolDao ...................................................................... core: UpdateCluserCommandTest single StoragePoolDao The test, like the production code, should have a single instance of a StoragePoolDao. Change-Id: I9d1b52f4e39eb24f414a0c3954edb86fe489a2e9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d1b52f4e39eb24f414a0c3954edb86fe489a2e9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0