- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: BasicTest: statically import assumeNotNull
by amureini＠redhat.com 19 Sep '16

19 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: BasicTest: statically import assumeNotNull ...................................................................... core: BasicTest: statically import assumeNotNull Statically import the method, as per the project's standards. Change-Id: I360b59ed736ef1a0a81fbd5072c5ce7198b19d53 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I360b59ed736ef1a0a81fbd5072c5ce7198b19d53 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: TestCommon try-with-resource
by amureini＠redhat.com 19 Sep '16

19 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: TestCommon try-with-resource ...................................................................... core: TestCommon try-with-resource Use Java 7's try-with-resource syntax to clean up the code and make it more concise. Change-Id: I3252f05f3c74644c6cef351deafb294eb277b28a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java 2 files changed, 2 insertions(+), 22 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3252f05f3c74644c6cef351deafb294eb277b28a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SSH test exceptions
by amureini＠redhat.com 19 Sep '16

19 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: SSH test exceptions ...................................................................... core: SSH test exceptions A lot of the tests in the ssh package will catch any exception and throw a RuntimeException, thus failing the test. A much cleaner approach would be to just throw the original exception all the way up. This way the test will still fail, but will at least provide some useful information on why it failed. Change-Id: I81a2661b6d3d5d48e548b90c20b53e243f0c5d68 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java 6 files changed, 23 insertions(+), 58 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81a2661b6d3d5d48e548b90c20b53e243f0c5d68 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: TestCommon @BeforeClass and @AfterClass
by amureini＠redhat.com 19 Sep '16

19 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: TestCommon @BeforeClass and @AfterClass ...................................................................... core: TestCommon @BeforeClass and @AfterClass All the tests in the this suite start with calling TestCommon.initialize() and they all end with calling TestCommon.terminate(). Instead of repeating these calls, a much cleaner approach would be to simply annotate them as such, have all the tests extend TestCommon, and allow JUnit to do all the heavy lifting. Change-Id: Ia362d885ddb184d35e1d3851e43349c6797a7b5f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java 5 files changed, 8 insertions(+), 44 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia362d885ddb184d35e1d3851e43349c6797a7b5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: TestCommon#main
by amureini＠redhat.com 19 Sep '16

19 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: TestCommon#main ...................................................................... core: TestCommon#main Remove TestCommon's main function - we have a perfectly good Maven environment set up to run JUnit tests. There's no reason to maintain a competing main too. Change-Id: I75c9279a3afd58349371284c0c546061efca6f06 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java 1 file changed, 0 insertions(+), 38 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75c9279a3afd58349371284c0c546061efca6f06 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: remove ovirt-engine update db job in ci
by eedri＠redhat.com 19 Sep '16

19 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: remove ovirt-engine update db job in ci ...................................................................... remove ovirt-engine update db job in ci This job is obseleted by the setup-upgrade job which already does DB update internally as part of the upgrade process and does a much more comprehensive test flow Change-Id: If5a2d79d94d1fd8aece5b32746480cb91f0f153a Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- D jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-db.yaml D jobs/confs/shell-scripts/ovirt-engine_upgrade-db.cleanup.sh D jobs/confs/shell-scripts/ovirt-engine_upgrade-db.sh D jobs/confs/yaml/builders/ovirt-engine_upgrade-db.yaml D jobs/confs/yaml/templates/engine-upgrade-db.yaml 5 files changed, 0 insertions(+), 216 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5a2d79d94d1fd8aece5b32746480cb91f0f153a Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Engine should not invoke revoke all on session expi...
by mperina＠redhat.com 19 Sep '16

19 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Engine should not invoke revoke all on session expiration ...................................................................... engine : Engine should not invoke revoke all on session expiration On session expiration SessionDataContainer should not invoke revoke-all for the token. If there are no other sessions for the token SSO will cleanup the session on revoke. Change-Id: I8bffd0551efd7ec4850b8913e4e9c8789c36785d Bug-Url: https://bugzilla.redhat.com/1377422 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bffd0551efd7ec4850b8913e4e9c8789c36785d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: removing changedbowner.sh script
by mperina＠redhat.com 19 Sep '16

19 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: core: removing changedbowner.sh script ...................................................................... core: removing changedbowner.sh script This script was relevant when the old backup utility was used and there was a chance that the backup was done with other user than 'engine'. In that case, if we try to restore the database we will got permissions issues. Now that engine-backup is used and verifies that the user that backup the database is 'engine', this script is no longer relevant. Change-Id: I0474ea645e2f3a0f4db20b510e2a1ef68e73b4ca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1371501 Signed-off-by: emesika <emesika(a)redhat.com> --- D packaging/setup/dbutils/changedbowner.sh M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py 3 files changed, 0 insertions(+), 88 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0474ea645e2f3a0f4db20b510e2a1ef68e73b4ca Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unused field in vm-dynamic
by ahadas＠redhat.com 19 Sep '16

19 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove unused field in vm-dynamic ...................................................................... core: remove unused field in vm-dynamic Remove VmDynamic#STATUS_FIELD_NAME Change-Id: Ia65d4c82ec27dfe3db55e9d71ef6119265243a81 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia65d4c82ec27dfe3db55e9d71ef6119265243a81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: adding debug message to DWH heart beat
by mperina＠redhat.com 19 Sep '16

19 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: core: adding debug message to DWH heart beat ...................................................................... core: adding debug message to DWH heart beat Adding debug messages on DWH heart beat start/end in order to investigate delays that occur sometimes when the result is that the update of the corresponding field in DB not occurs in the configured rate. This will not solve the reported bug, rather it will give us information which part cause the delay, the scheduling mechanism or the database. Change-Id: Ia32c559ee380e0dbb7279f94b7dd9a99c0670a2a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373456 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Shirly Radco: Looks good to me, but someone else must approve Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia32c559ee380e0dbb7279f94b7dd9a99c0670a2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0