- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Default storage format once adding SD.
by mlipchuk＠redhat.com 18 Sep '16

18 Sep '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Default storage format once adding SD. ...................................................................... webadmin: Default storage format once adding SD. If a Data Center is in an uninitialized status its format type is also uninitialized although the Data Center might not support specific storage formats. For example a v4.0 Data Center should not support v4 storage domains Today, once a storage domain is being added to an uninitialized 4.0 Data Center the default storage format will be V4 for new storage domains since the Data Center's format type is still un-initialized, and the add operation will fail for a reason of unsupported version format. The proposed fix sets the Data Center's format type once it is uninitialized based on its compatibility version Change-Id: Ia117efc7369056f70854b8bbfbb6dd7dec7ce318 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/63717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia117efc7369056f70854b8bbfbb6dd7dec7ce318 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Clear IDE disk address on bootable change
by amureini＠redhat.com 18 Sep '16

18 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Clear IDE disk address on bootable change ...................................................................... engine: Clear IDE disk address on bootable change In the following scenario, the VM will fail to start: 1. Create new VM with IDE disk, verify it starts 2. Add second IDE disk 3. Turn off bootable flag from 1st disk, make 2nd disk bootable 4. Start the VM The root cause of this issue is that we save the device address of the disk, but we changed the order of the disks. This will cause a mismatch between the address and the name of the disk. In order to fix this issue, the address will be cleared for IDE disks if the 'bootable' attribute changed. Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Bug-Url: https://bugzilla.redhat.com/1186817 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/63726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: replace null valued ipv6_boot_protocol with 'NONE'
by masayag＠redhat.com 18 Sep '16

18 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: core: replace null valued ipv6_boot_protocol with 'NONE' ...................................................................... core: replace null valued ipv6_boot_protocol with 'NONE' update script fixes issue which exist due to problems on all 3 layers. Ipv6BootProtocol should be nonnull(which is not), and this column on dal layer controls creation of IpV6Address(which probably should not be there), and because of that null-valued IpV6Address instance arrives to UI layer, which expects only non-null values (which it should not do), and because of that UI fails on NPE. Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0300_do_not_allow_null_boot_protocol.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix pagination error when navigating the system tree
by gshereme＠redhat.com 16 Sep '16

16 Sep '16

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: fix pagination error when navigating the system tree ...................................................................... webadmin: fix pagination error when navigating the system tree Changed SearchableListModel such that the current search page is reset with every search string reset. If the currently displayed page is not tracked correctly, UX elements will misbehave. The broken behavior primarily effected table lists view on main tabs. When the tab's search is updated by either navigating the system tree or by entering search terms, its list model needs to hold the correct search page information. If not, the table view pagination controls may behave as if a different page of records is being displayed than what is actually displayed. Change-Id: I17eab7bb25cbd7aecfedf259e33975947c1df892 Bug-Url: https://bugzilla.redhat.com/1326452 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/63195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17eab7bb25cbd7aecfedf259e33975947c1df892 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: image: ask image size also when using the appliance
by sbonazzo＠redhat.com 16 Sep '16

16 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: image: ask image size also when using the appliance ...................................................................... image: ask image size also when using the appliance Ask image size also when using the appliance using the appliance disk size as a minimum value. It will let customize the disk size also on upgrades (the code was already exending the volume size if the new appliance was bigger than the initial disk). Change-Id: I7828357a8647af8c816db9d9ea9b5251a0fd2df2 Bug-Url: https://bugzilla.redhat.com/1300591 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M po/POTFILES.in M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/gr-he-common/core/remote_answerfile.py M src/plugins/gr-he-common/vm/Makefile.am M src/plugins/gr-he-common/vm/__init__.py M src/plugins/gr-he-common/vm/boot_disk.py R src/plugins/gr-he-common/vm/image.py M src/plugins/gr-he-setup/storage/storage.py M src/plugins/gr-he-setup/vm/Makefile.am M src/plugins/gr-he-setup/vm/__init__.py M src/plugins/gr-he-upgradeappliance/engine/misc.py 12 files changed, 89 insertions(+), 23 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7828357a8647af8c816db9d9ea9b5251a0fd2df2 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: python: cleanup import lines using isort
by sbonazzo＠redhat.com 16 Sep '16

16 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: python: cleanup import lines using isort ...................................................................... python: cleanup import lines using isort Ran isort on all the python files included in the project with the following configuration. $ cat ~/.isort.cfg [settings] line_length=79 known_standard_library=configparser,Cheetah.Template force_single_line=True default_section=FIRSTPARTY known_otopi=otopi known_host_deploy=ovirt_host_deploy known_ovirt_engine=ovirt_engine known_ovirt_engine_setup=ovirt_engine_setup known_ovirt_setup_lib=ovirt_setup_lib known_vdsm=vdsm known_ovirt_hosted_engine_setup=ovirt_hosted_engine_setup sections=FUTURE,STDLIB,FIRSTPARTY,OTOPI,VDSM,HOST_DEPLOY,OVIRT_ENGINE,OVIRT_ENGINE_SETUP,OVIRT_SETUP_LIB,OVIRT_HOSTED_ENGINE_SETUP,THIRDPARTY,LOCALFOLDER lines_between_types=2 Change-Id: I090e04f0523b6084b6e429825fff9237473a87a5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A .isort.cfg M build/python.inc M configure.ac M po/pt_BR.po M src/ovirt_hosted_engine_setup/check_liveliness.py M src/ovirt_hosted_engine_setup/connect_storage_server.py M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/domains.py M src/ovirt_hosted_engine_setup/engineapi.py M src/ovirt_hosted_engine_setup/mixins.py M src/ovirt_hosted_engine_setup/ohttpshandler.py M src/ovirt_hosted_engine_setup/ovf/ovfenvelope.py M src/ovirt_hosted_engine_setup/pkissh.py M src/ovirt_hosted_engine_setup/reinitialize_lockspace.py M src/ovirt_hosted_engine_setup/set_maintenance.py M src/ovirt_hosted_engine_setup/tasks.py M src/ovirt_hosted_engine_setup/util.py M src/ovirt_hosted_engine_setup/vm_status.py M src/plugins/gr-he-common/core/misc.py M src/plugins/gr-he-common/core/offlinepackager.py M src/plugins/gr-he-common/core/remote_answerfile.py M src/plugins/gr-he-common/core/vdsmconf.py M src/plugins/gr-he-common/engine/__init__.py M src/plugins/gr-he-common/engine/ca.py M src/plugins/gr-he-common/engine/health.py M src/plugins/gr-he-common/network/__init__.py M src/plugins/gr-he-common/network/bridge.py M src/plugins/gr-he-common/sanlock/__init__.py M src/plugins/gr-he-common/sanlock/lockspace.py M src/plugins/gr-he-common/vm/boot_disk.py M src/plugins/gr-he-common/vm/cloud_init.py M src/plugins/gr-he-common/vm/misc.py M src/plugins/gr-he-rollbackupgrade/core/__init__.py M src/plugins/gr-he-rollbackupgrade/core/misc.py M src/plugins/gr-he-setup/core/answerfile.py M src/plugins/gr-he-setup/core/conf.py M src/plugins/gr-he-setup/core/misc.py M src/plugins/gr-he-setup/core/preview.py M src/plugins/gr-he-setup/core/shell.py M src/plugins/gr-he-setup/core/titles.py M src/plugins/gr-he-setup/engine/add_host.py M src/plugins/gr-he-setup/engine/fqdn.py M src/plugins/gr-he-setup/engine/os_install.py M src/plugins/gr-he-setup/ha/__init__.py M src/plugins/gr-he-setup/ha/ha_notifications.py M src/plugins/gr-he-setup/ha/ha_services.py M src/plugins/gr-he-setup/libvirt/__init__.py M src/plugins/gr-he-setup/libvirt/configureqemu.py M src/plugins/gr-he-setup/network/__init__.py M src/plugins/gr-he-setup/network/firewall.py M src/plugins/gr-he-setup/network/firewall_manager.py M src/plugins/gr-he-setup/network/gateway.py M src/plugins/gr-he-setup/network/iptables.py M src/plugins/gr-he-setup/pki/__init__.py M src/plugins/gr-he-setup/pki/vdsmpki.py M src/plugins/gr-he-setup/storage/__init__.py M src/plugins/gr-he-setup/storage/blockd.py M src/plugins/gr-he-setup/storage/heconf.py M src/plugins/gr-he-setup/storage/nfs.py M src/plugins/gr-he-setup/storage/storage.py M src/plugins/gr-he-setup/system/__init__.py M src/plugins/gr-he-setup/system/packages.py M src/plugins/gr-he-setup/system/sshd.py M src/plugins/gr-he-setup/system/vdsmenv.py M src/plugins/gr-he-setup/vdsmd/__init__.py M src/plugins/gr-he-setup/vdsmd/cpu.py M src/plugins/gr-he-setup/vdsmd/vdsmconf.py M src/plugins/gr-he-setup/vm/boot_cdrom.py M src/plugins/gr-he-setup/vm/configurevm.py M src/plugins/gr-he-setup/vm/cpu.py M src/plugins/gr-he-setup/vm/image.py M src/plugins/gr-he-setup/vm/mac.py M src/plugins/gr-he-setup/vm/machine.py M src/plugins/gr-he-setup/vm/memory.py M src/plugins/gr-he-setup/vm/runvm.py M src/plugins/gr-he-upgradeappliance/core/__init__.py M src/plugins/gr-he-upgradeappliance/core/misc.py M src/plugins/gr-he-upgradeappliance/engine/__init__.py M src/plugins/gr-he-upgradeappliance/engine/misc.py M src/plugins/gr-he-upgradeappliance/vm/__init__.py M src/plugins/gr-he-upgradeappliance/vm/configurevm.py M src/plugins/gr-he-upgradeappliance/vm/runvm.py M src/vdsm_hooks/hostedengine.py 83 files changed, 1,135 insertions(+), 884 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I090e04f0523b6084b6e429825fff9237473a87a5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: python: Apply isort also to __init__.py files
by sbonazzo＠redhat.com 16 Sep '16

16 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: python: Apply isort also to __init__.py files ...................................................................... python: Apply isort also to __init__.py files Change-Id: I494b535ddd06c099d956d04a64b01a47797b5204 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .isort.cfg M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py M packaging/setup/plugins/ovirt-engine-common/base/dialog/__init__.py M packaging/setup/plugins/ovirt-engine-common/base/network/__init__.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/__init__.py M packaging/setup/plugins/ovirt-engine-common/base/system/__init__.py M packaging/setup/plugins/ovirt-engine-common/dockerc/__init__.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/config/__init__.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/__init__.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/provisioning/__init__.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/__init__.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/__init__.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/__init__.py M packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/__init__.py M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/__init__.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/__init__.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/provisioning/__init__.py M packaging/setup/plugins/ovirt-engine-remove/base/core/__init__.py M packaging/setup/plugins/ovirt-engine-remove/base/files/__init__.py M packaging/setup/plugins/ovirt-engine-remove/base/network/__init__.py M packaging/setup/plugins/ovirt-engine-remove/dockerc/__init__.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-common/system/__init__.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/__init__.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/__init__.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/__init__.py M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/__init__.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/__init__.py M packaging/setup/plugins/ovirt-engine-rename/vmconsole_proxy_helper/__init__.py M packaging/setup/plugins/ovirt-engine-setup/base/core/__init__.py M packaging/setup/plugins/ovirt-engine-setup/base/dialog/__init__.py M packaging/setup/plugins/ovirt-engine-setup/base/network/__init__.py M packaging/setup/plugins/ovirt-engine-setup/base/system/__init__.py M packaging/setup/plugins/ovirt-engine-setup/dockerc/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/__init__.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/__init__.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/__init__.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/__init__.py 51 files changed, 28 insertions(+), 71 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I494b535ddd06c099d956d04a64b01a47797b5204 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Setup: remove the host label dialog question
by stirabos＠redhat.com 16 Sep '16

16 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: Setup: remove the host label dialog question ...................................................................... Setup: remove the host label dialog question Host label at the web interface will be machine's hostname by default Change-Id: Ie94b899ec66fc7a04aaf735e42c6102aced9c413 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1313916 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M src/plugins/gr-he-setup/engine/add_host.py 1 file changed, 4 insertions(+), 37 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62944 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie94b899ec66fc7a04aaf735e42c6102aced9c413 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: Fix location for OPENSTACK_NEUTRON_OPENVSWITCH_CONFIG
by sbonazzo＠redhat.com 16 Sep '16

16 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix location for OPENSTACK_NEUTRON_OPENVSWITCH_CONFIG ...................................................................... Fix location for OPENSTACK_NEUTRON_OPENVSWITCH_CONFIG With the release of OpenStack Liberty the Open vSwitch agent ini file location has changed. Includes logic to use OLD path if running OpenStack Kilo or older. OLD: /etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini NEW: /etc/neutron/plugins/ml2/openvswitch_agent.ini Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373968 Change-Id: I6adf1078442693410d3435616e4dafb5600a77fb Signed-off-by: Tony James <tony(a)anthonyjames.org> --- M src/ovirt_host_deploy/constants.py 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Tony James: Verified -- To view, visit https://gerrit.ovirt.org/63707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6adf1078442693410d3435616e4dafb5600a77fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Tony James <tony(a)anthonyjames.org> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marina Kalinin <mku(a)redhat.com> Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tony James <tony(a)anthonyjames.org> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use default when getting properties
by amureini＠redhat.com 16 Sep '16

16 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use default when getting properties ...................................................................... core: Use default when getting properties Remove unneeded boilerplate by using a default value to System.getProperty. Change-Id: If7397fbd037189c711a807c4e7bbc3131f8ece1a Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7397fbd037189c711a807c4e7bbc3131f8ece1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0