- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.4]: core: replace null valued ipv6_boot_protocol with 'NONE'
by oourfali＠redhat.com 19 Sep '16

19 Sep '16

Oved Ourfali has submitted this change and it was merged. Change subject: core: replace null valued ipv6_boot_protocol with 'NONE' ...................................................................... core: replace null valued ipv6_boot_protocol with 'NONE' update script fixes issue which exist due to problems on all 3 layers. Ipv6BootProtocol should be nonnull(which is not), and this column on dal layer controls creation of IpV6Address(which probably should not be there), and because of that null-valued IpV6Address instance arrives to UI layer, which expects only non-null values (which it should not do), and because of that UI fails on NPE. Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0910_do_not_allow_null_boot_protocol.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: replace null valued ipv6_boot_protocol with 'NONE'
by oourfali＠redhat.com 19 Sep '16

19 Sep '16

Oved Ourfali has submitted this change and it was merged. Change subject: core: replace null valued ipv6_boot_protocol with 'NONE' ...................................................................... core: replace null valued ipv6_boot_protocol with 'NONE' update script fixes issue which exist due to problems on all 3 layers. Ipv6BootProtocol should be nonnull(which is not), and this column on dal layer controls creation of IpV6Address(which probably should not be there), and because of that null-valued IpV6Address instance arrives to UI layer, which expects only non-null values (which it should not do), and because of that UI fails on NPE. Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0910_do_not_allow_null_boot_protocol.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Moti Asayag: Looks good to me, approved Oved Ourfali: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: spec: Add rsyslog requirement
by dougsland＠redhat.com 18 Sep '16

18 Sep '16

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: Add rsyslog requirement ...................................................................... spec: Add rsyslog requirement The auto-registration works in EL6 and EL7 which requires rsyslog to analyze the kargs used during the boot. Change-Id: I18c7c75a8236f12c2ff8e94370f84b6188a2dfcd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1377073 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/64103 (cherry picked from commit 48896d1f7f24fc81776bb790f904aa7476870346) Reviewed-on: https://gerrit.ovirt.org/64104 --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c7c75a8236f12c2ff8e94370f84b6188a2dfcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[master]: spec: Add rsyslog requirement
by dougsland＠redhat.com 18 Sep '16

18 Sep '16

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: Add rsyslog requirement ...................................................................... spec: Add rsyslog requirement The auto-registration works in EL6 and EL7 which requires rsyslog to analyze the kargs used during the boot. Change-Id: I18c7c75a8236f12c2ff8e94370f84b6188a2dfcd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1377073 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/64103 --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c7c75a8236f12c2ff8e94370f84b6188a2dfcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Clear IDE disk address on bootable change
by tnisan＠redhat.com 18 Sep '16

18 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Clear IDE disk address on bootable change ...................................................................... engine: Clear IDE disk address on bootable change In the following scenario, the VM will fail to start: 1. Create new VM with IDE disk, verify it starts 2. Add second IDE disk 3. Turn off bootable flag from 1st disk, make 2nd disk bootable 4. Start the VM The root cause of this issue is that we save the device address of the disk, but we changed the order of the disks. This will cause a mismatch between the address and the name of the disk. In order to fix this issue, the address will be cleared for IDE disks if the 'bootable' attribute changed. Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Bug-Url: https://bugzilla.redhat.com/1186817 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/64101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract disk statistics from vm-dynamic
by ahadas＠redhat.com 18 Sep '16

18 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract disk statistics from vm-dynamic ...................................................................... core: extract disk statistics from vm-dynamic This is quite an absurd that VmDynamic#disks was set with @UnchangeableByVdsm although it is reported only by VDSM. This might be an indication of a problem with the design - it represents disk statistics and thus should not be part of VmDynamic: 1. It is not supposed to be compared with value from the database (hence why it is set with @UnchangeableByVdsm) 2. It is not supposed to be sent for each VM that is being queried, including search queries. Therefore, this patch extracts this data from VmDynamic to VdsmVm that contains similar type of statistics. Change-Id: I4139db014d4663c1ee1eff5037939db628b2f53e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java 6 files changed, 46 insertions(+), 63 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4139db014d4663c1ee1eff5037939db628b2f53e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: engine fail to activate host on unknown RNG source
by shavivi＠redhat.com 18 Sep '16

18 Sep '16

Shahar Havivi has submitted this change and it was merged. Change subject: core: engine fail to activate host on unknown RNG source ...................................................................... core: engine fail to activate host on unknown RNG source Unknown RNG source doesn't need to prevent host from loading. Change-Id: I99fab20589f2866932269fc63e0bb9051b3ddbac Bug-Url: https://bugzilla.redhat.com/1374216 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99fab20589f2866932269fc63e0bb9051b3ddbac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tests: refactor SyncLunsInfoForBlockStorageDomainCommandTest
by derez＠redhat.com 18 Sep '16

18 Sep '16

Daniel Erez has submitted this change and it was merged. Change subject: tests: refactor SyncLunsInfoForBlockStorageDomainCommandTest ...................................................................... tests: refactor SyncLunsInfoForBlockStorageDomainCommandTest This patch changes SyncLunsInfoForBlockStorageDomainCommandTest to use two LUNs object members instead of recreating them in each test case. Change-Id: Ic8b41699a69379443bb84fef017532bb74de80b0 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java 1 file changed, 33 insertions(+), 33 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/64008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b41699a69379443bb84fef017532bb74de80b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: setup: Configure scale only on new database
by Shirly Radco 18 Sep '16

18 Sep '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Configure scale only on new database ...................................................................... packaging: setup: Configure scale only on new database Change-Id: If4b1adb6556aff015a4d774f8707ccd3e96ba445 Bug-Url: https://bugzilla.redhat.com/1365427 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/scale.py 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b1adb6556aff015a4d774f8707ccd3e96ba445 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core, webadmin: Support upgrade for V4
by mlipchuk＠redhat.com 18 Sep '16

18 Sep '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core, webadmin: Support upgrade for V4 ...................................................................... core, webadmin: Support upgrade for V4 Support storage domain's upgrade to V4. Also, remove a redundant test of validateSucceedsPoolNotSpecified since ensureStorageFormatInitialized in AddStorageDomainCommand insures that the storage domain will always be initialized with a storage format. Change-Id: I5139b85cefdb9c7223fb19e0cb6c0e9278d062d4 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommonTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageFormatType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 6 files changed, 12 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/63637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5139b85cefdb9c7223fb19e0cb6c0e9278d062d4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0