- Engine-commits - oVirt List Archives

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: packaging: setup: Configure scale only on new database
by Shirly Radco 19 Sep '16

19 Sep '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Configure scale only on new database ...................................................................... packaging: setup: Configure scale only on new database Change-Id: If4b1adb6556aff015a4d774f8707ccd3e96ba445 Bug-Url: https://bugzilla.redhat.com/1365427 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/scale.py 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b1adb6556aff015a4d774f8707ccd3e96ba445 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: disallow boot protocol to be null
by masayag＠redhat.com 19 Sep '16

19 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: core: disallow boot protocol to be null ...................................................................... core: disallow boot protocol to be null in response to bug 1371119 we should not allow null values in boot protocol columns any more. Change-Id: I535b0945b00b5462cd8a7158f22d63b94f531cd2 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/04_01_0310_disallow_boot_protocol_to_be_null.sql 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I535b0945b00b5462cd8a7158f22d63b94f531cd2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix retrival of vm's pid
by ahadas＠redhat.com 19 Sep '16

19 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix retrival of vm's pid ...................................................................... core: fix retrival of vm's pid The process identifier (PID) of a VM is reported correctly by VDSM but due to incorrect handling in the engine it is not set in VmDynamic#vmPid. This patch fixes that handling so the PID is correctly saved to the database. Further usages of this field need to be considered separately. Change-Id: I83820d8181ee382c720510b3cb51d110cf8bee40 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 3 files changed, 5 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83820d8181ee382c720510b3cb51d110cf8bee40 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: packaging: setup: postgres applyEnvironment: Allow missing keys
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: postgres applyEnvironment: Allow missing keys ...................................................................... packaging: setup: postgres applyEnvironment: Allow missing keys This allows not calling setdefault for each key separately. Bug-Url: https://bugzilla.redhat.com/1369757 Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/postgres.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/64134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: setup: postgres applyEnvironment: Allow missing keys
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: postgres applyEnvironment: Allow missing keys ...................................................................... packaging: setup: postgres applyEnvironment: Allow missing keys This allows not calling setdefault for each key separately. Bug-Url: https://bugzilla.redhat.com/1369757 Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/postgres.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/64133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Build correctly creation status links
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Build correctly creation status links ...................................................................... restapi: Build correctly creation status links The code that builds the links returned by the creation status resource doesn't build correctly the links, because it doesn't take into account the source of the API version. As a result the links contain always the version prefix. For example: <creation href="/ovirt-engine/api/v4/vms/..." id="..."> <status>complete</status> </creation> Note the '/v4' suffix, it should be there only if it is included in the request URI, but it is currently always present, even when the version is selected using the 'Version' header. This patch fixes the creation status resource so that it builds the link taking into account where the version has been specified. Change-Id: I9cc0f7f03d2dd5ece00ed0081a7fb058cd5b7a27 Related-To: https://bugzilla.redhat.com/1359139 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit df4292de31b3a2ca3bd030da85e8e70086331c7c) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAsyncStatusResource.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cc0f7f03d2dd5ece00ed0081a7fb058cd5b7a27 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: standard printing of vm configuration
by ahadas＠redhat.com 19 Sep '16

19 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: standard printing of vm configuration ...................................................................... core: standard printing of vm configuration We currently print the configuration of a VM we are going to run with custom code. This patch replaces this part with a call to Java's AbstractMap#toString. Change-Id: I25db0be4a103d4e25842c3b7475db62c480878c8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java 1 file changed, 1 insertion(+), 19 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25db0be4a103d4e25842c3b7475db62c480878c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Build correctly creation status links
by juan.hernandez＠redhat.com 19 Sep '16

19 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Build correctly creation status links ...................................................................... restapi: Build correctly creation status links The code that builds the links returned by the creation status resource doesn't build correctly the links, because it doesn't take into account the source of the API version. As a result the links contain always the version prefix. For example: <creation href="/ovirt-engine/api/v4/vms/..." id="..."> <status>complete</status> </creation> Note the '/v4' suffix, it should be there only if it is included in the request URI, but it is currently always present, even when the version is selected using the 'Version' header. This patch fixes the creation status resource so that it builds the link taking into account where the version has been specified. Change-Id: I9cc0f7f03d2dd5ece00ed0081a7fb058cd5b7a27 Related-To: https://bugzilla.redhat.com/1359139 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAsyncStatusResource.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cc0f7f03d2dd5ece00ed0081a7fb058cd5b7a27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Require WildFly 10.1.0
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Require WildFly 10.1.0 ...................................................................... core: Require WildFly 10.1.0 Adds requirement on WildFly 10.1.0 Change-Id: Iddb5203893e1d3d694b2199d70757c46b941bc52 Bug-Url: https://bugzilla.redhat.com/1368985 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddb5203893e1d3d694b2199d70757c46b941bc52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: Fix disk profile matching by storage domain
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix disk profile matching by storage domain ...................................................................... core: Fix disk profile matching by storage domain Disk profile matching by storage domain was done incorrectly Taking under account only the storage domain default disk profile. Matching a disk profile by storage domain is now done against all disk profiles of that storage domain. In addition added correct syntax in errors messages. Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> (cherry picked from commit e20ff86) Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 5 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0