- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: Remove usage of extraneous lock objects
by mbetak＠redhat.com 15 Sep '16

15 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: backend: Remove usage of extraneous lock objects ...................................................................... backend: Remove usage of extraneous lock objects When assuring mutual exclusion on instance or class level, extra monitor objects are unnecessary and can be replaced with standard java usage of: synchronized (this) { ... } or synchronized (MyClass.class) { ... } Replaced all such occurrences. Change-Id: I8dcb82ac09f494e731b86813b10b8772659e389b Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 3 files changed, 6 insertions(+), 12 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dcb82ac09f494e731b86813b10b8772659e389b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Determine the necessary space from the sparse size of the image
by stirabos＠redhat.com 15 Sep '16

15 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: Determine the necessary space from the sparse size of the image ...................................................................... Determine the necessary space from the sparse size of the image Instead of relying on the OVF metadata (which is the raw size), use the sparse size to determine local storage requirements, so we don't need 50Gb of space in /var/tmp for a ~3.5GB qcow before we copy it over to shared storage. Change-Id: I14bc33573a1b26e929cd96081a1083023d6b2a9c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1347340 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-common/vm/boot_disk.py 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Ryan Barry: Verified -- To view, visit https://gerrit.ovirt.org/57904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14bc33573a1b26e929cd96081a1083023d6b2a9c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.0.z]: automation: drop suffix on manual builds
by sbonazzo＠redhat.com 15 Sep '16

15 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: drop suffix on manual builds ...................................................................... automation: drop suffix on manual builds Change-Id: If7fc4bd53fd70b125dcd25110c2ac3bc9e0b691d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 069b625928c18cc7771c3397e35c3a2d48f5ba81) --- M automation/build-artifacts-manual.sh 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7fc4bd53fd70b125dcd25110c2ac3bc9e0b691d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.0.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: automation: drop suffix on manual builds
by sbonazzo＠redhat.com 15 Sep '16

15 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: drop suffix on manual builds ...................................................................... automation: drop suffix on manual builds Change-Id: If7fc4bd53fd70b125dcd25110c2ac3bc9e0b691d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts-manual.sh 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7fc4bd53fd70b125dcd25110c2ac3bc9e0b691d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: upgrade: add an info message about ssh keys
by stirabos＠redhat.com 15 Sep '16

15 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: add an info message about ssh keys ...................................................................... upgrade: add an info message about ssh keys The new appliance comes with new ssh keys; add a notice to inform the user. Change-Id: Idaf9b42c9f7b546211648d5948f2bd3198fd1d78 Bug-Url: https://bugzilla.redhat.com/1343451 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 9540c880d9ff836deb52e855a18704878d454560) --- M src/plugins/gr-he-common/core/misc.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63976 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaf9b42c9f7b546211648d5948f2bd3198fd1d78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: upgrade: add an info message about ssh keys
by stirabos＠redhat.com 15 Sep '16

15 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: add an info message about ssh keys ...................................................................... upgrade: add an info message about ssh keys The new appliance comes with new ssh keys; add a notice to inform the user. https://bugzilla.redhat.com/1343451 Change-Id: Idaf9b42c9f7b546211648d5948f2bd3198fd1d78 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-common/core/misc.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Ido Rosenzwig: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaf9b42c9f7b546211648d5948f2bd3198fd1d78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Graphics devices sorted for VM creation
by ahadas＠redhat.com 15 Sep '16

15 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Graphics devices sorted for VM creation ...................................................................... core: Graphics devices sorted for VM creation We currently support two concurrent graphics protocols: SPICE+VNC. However qemu can have only one sound driver and thus only one protocol can get the sound. Libvirt sets audio driver (QEMU_AUDIO_DRV variable) according to the last graphics device in domain xml. Until now the order of graphics device have depended on database result ordering (i.e. has been random). This patch puts SPICE at the end so if SPICE+VNC is selected, SPICE always gets the sound. Change-Id: I93a8c597355e27235e528d1a9cb28d893a1f219f Bug-Url: https://bugzilla.redhat.com/1371243 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/ComparatorUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 2 files changed, 62 insertions(+), 4 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93a8c597355e27235e528d1a9cb28d893a1f219f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Imports of spice-html5 fixed
by mbetak＠redhat.com 14 Sep '16

14 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: core: Imports of spice-html5 fixed ...................................................................... core: Imports of spice-html5 fixed Previously not all files of spice-html5 library were included (using <script> tag) and it seemed to work ok up to v0.1.6. In v0.1.7 it started to throw "ReferenceError: GAP_DETECTION_THRESHOLD is not defined". This patch imports all yet not imported *.js files from spice-html5 distribution and thus eliminating the error. Change-Id: Idadaeffd4c8ce97d4a54de97b65709e9f60cc145 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/spicehtml5-main.jsp 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idadaeffd4c8ce97d4a54de97b65709e9f60cc145 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move usages of disk images filter from ImagesHandler t...
by tnisan＠redhat.com 14 Sep '16

14 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Move usages of disk images filter from ImagesHandler to DisksFilter ...................................................................... core: Move usages of disk images filter from ImagesHandler to DisksFilter Change-Id: I65ae3fcf539f9bc3ec42b11d7d42f5ca46212a9e Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfUpdateProcessHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandlerTest.java 32 files changed, 178 insertions(+), 112 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65ae3fcf539f9bc3ec42b11d7d42f5ca46212a9e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introducing DisksFilter.filterImageDisks
by tnisan＠redhat.com 14 Sep '16

14 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Introducing DisksFilter.filterImageDisks ...................................................................... core: Introducing DisksFilter.filterImageDisks Introducing the DisksFilter class which currently holds filterImageDisks with Java 8 predicates implemenations and comes to replace ImagesHandler::filterImageDisks The motivations behind that change: - Using filterImageDisks(disk, true, false, true) is barely readable, replacing it with filterImageDisks(disk. SNAPABLE_DISKS_ONLY) makes it way more clear what exactly are we filtering - Higher usability as those predicates can be used in other filtering methods instead of repeating an endless unreadable series of ifs - It's optional to add specific predicates to the filtering method by writing a Predicate function on the fly - Slight performance improvement as most of the usages in the code are filtering 1-2 conditions so we save redundant checks of the parameters Change-Id: I452385410fcefcc8a786235117608674ec933c50 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/DisksFilter.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/DisksFilterTest.java 2 files changed, 155 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I452385410fcefcc8a786235117608674ec933c50 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0