- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: Use pooling http client
by omachace＠redhat.com 15 Sep '16

15 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Use pooling http client ...................................................................... Use pooling http client To be able to use connection from multiple threads, we can't use BasicHttpClientConnectionManager, because it doesn't allow it. So this patch changes to using of PoolingHttpClientConnectionManager, which supports using of multiple threads. Change-Id: Ia0188394b9f2ff647a6fb03ddb5814d51c485c48 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1376402 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder42.java M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder45.java M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java 3 files changed, 28 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0188394b9f2ff647a6fb03ddb5814d51c485c48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Unused ConsoleOptions.guestHostName removed
by mbetak＠redhat.com 15 Sep '16

15 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Unused ConsoleOptions.guestHostName removed ...................................................................... webadmin: Unused ConsoleOptions.guestHostName removed Change-Id: I789b0b7ef67408f771879f3d3ece78d95bbf656e Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java 2 files changed, 0 insertions(+), 10 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I789b0b7ef67408f771879f3d3ece78d95bbf656e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Unused ActiveX console menu code removed
by mbetak＠redhat.com 15 Sep '16

15 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Unused ActiveX console menu code removed ...................................................................... webadmin: Unused ActiveX console menu code removed * ConsoleOptions.menu removed * Menu creation and action handling code removed * Loading list of CDs that could be changed from menu, SpiceConsoleModel.executeQuery() merged with SpiceConsoleModel.invokeClient(). Change-Id: I07d2a624394fb9c5f9bb6c01a7d46a1e8ead5f32 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 4 files changed, 6 insertions(+), 164 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07d2a624394fb9c5f9bb6c01a7d46a1e8ead5f32 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core, webadmin: [ovirt] vv file section
by tjelinek＠redhat.com 15 Sep '16

15 Sep '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core, webadmin: [ovirt] vv file section ...................................................................... core, webadmin: [ovirt] vv file section Generation of [ovirt] *.vv file section moved from frontend to backend allowing the same code to be used for both frontend and REST. This allows to use Change CD remote-viewer menu for vv files from all sources (i.e. spice, vnc; web, REST) Engine host name for REST change CD requests is no longer derived from browser's `window.location` but uses EngineLocalConfig class. vv file '[ovirt] admin' option is now purely based on parameters.isFiltered. Change-Id: I36d6c329c78536a48b3becd618068a45879a9081 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1310553 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleDescriptorGenerator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 8 files changed, 140 insertions(+), 74 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d6c329c78536a48b3becd618068a45879a9081 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: revert incorrect set of network for display/migration
by emesika＠redhat.com 15 Sep '16

15 Sep '16

Eli Mesika has submitted this change and it was merged. Change subject: core: revert incorrect set of network for display/migration ...................................................................... core: revert incorrect set of network for display/migration This script is commented out since any network can be the management network from 4.0 and the logic should be : If a display network is not set by any network, set it to the management network If a migration network is not set by any network, set it to the management network Change-Id: Icc1efbf0b9fa9ce632488dbe33a556b6f9b00f6a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372955 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/04_01_0280_display_migration_cluster_network.sql 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved; Passed CI tests Martin Mucha: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc1efbf0b9fa9ce632488dbe33a556b6f9b00f6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Add JSON-RPC hypervisor interface for VDSM
by msivak＠redhat.com 15 Sep '16

15 Sep '16

Martin Sivák has submitted this change and it was merged. Change subject: Add JSON-RPC hypervisor interface for VDSM ...................................................................... Add JSON-RPC hypervisor interface for VDSM This patch adds a JSON-RPC hypervisor interface plus a supporting Optional class to make the code nice and tidy. Change-Id: Ib8bf5e9392195dbfc4c3677c9b674905cafa9e67 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/60648 Continuous-Integration: Jenkins CI Tested-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M mom/HypervisorInterfaces/Makefile.am A mom/HypervisorInterfaces/vdsmjsonrpcInterface.py M mom/Makefile.am A mom/optional.py A tests/OptionalTests.py 5 files changed, 339 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/60648 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8bf5e9392195dbfc4c3677c9b674905cafa9e67 Gerrit-PatchSet: 17 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Make black/white list filters more understandable
by rgolan＠redhat.com 15 Sep '16

15 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Make black/white list filters more understandable ...................................................................... scheduling: Make black/white list filters more understandable Change-Id: I195ebf281e33bb127fe9b85d5a70aa1707e6b257 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 42 insertions(+), 13 deletions(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I195ebf281e33bb127fe9b85d5a70aa1707e6b257 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Remove nulls from weighting step
by rgolan＠redhat.com 15 Sep '16

15 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Remove nulls from weighting step ...................................................................... scheduling: Remove nulls from weighting step Change-Id: I8268348cb8cbc610ac7c196594beb6b0b30beaf7 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/BasicWeightSelectorPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/RankSelectorPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/selector/SelectorInstance.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/BasicWeightSelectorPolicyUnitTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/RankSelectorPolicyUnitTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/ClusterPolicy.java 9 files changed, 67 insertions(+), 63 deletions(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8268348cb8cbc610ac7c196594beb6b0b30beaf7 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Additional @NotNull and Java 8 improvements
by rgolan＠redhat.com 15 Sep '16

15 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Additional @NotNull and Java 8 improvements ...................................................................... scheduling: Additional @NotNull and Java 8 improvements Change-Id: Ib3570764b1c235190d4b67fa70f3d831b2860eaa Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 48 insertions(+), 43 deletions(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3570764b1c235190d4b67fa70f3d831b2860eaa Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: Determine the necessary space from the sparse size of the image
by stirabos＠redhat.com 15 Sep '16

15 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: Determine the necessary space from the sparse size of the image ...................................................................... Determine the necessary space from the sparse size of the image Instead of relying on the OVF metadata (which is the raw size), use the sparse size to determine local storage requirements, so we don't need 50Gb of space in /var/tmp for a ~3.5GB qcow before we copy it over to shared storage. Change-Id: I14bc33573a1b26e929cd96081a1083023d6b2a9c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1347340 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-common/vm/boot_disk.py 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14bc33573a1b26e929cd96081a1083023d6b2a9c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0