- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: ShellLikeConfdTest printing
by amureini＠redhat.com 16 Sep '16

16 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ShellLikeConfdTest printing ...................................................................... core: ShellLikeConfdTest printing Removed useless printing to System.out from the test - tests should automatically verify results, not visually. Change-Id: Id74df2d8df7a88861c9d8757e784f8f9116c112c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/config/ShellLikeConfdTest.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id74df2d8df7a88861c9d8757e784f8f9116c112c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ShellLikeConfdTest try-with-resource
by amureini＠redhat.com 16 Sep '16

16 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ShellLikeConfdTest try-with-resource ...................................................................... core: ShellLikeConfdTest try-with-resource Clean up the code by using the try-with-resource syntax introduced in Java 7. Change-Id: I43bd24670d1e9068519807daa8fea23e54b9a319 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/config/ShellLikeConfdTest.java 1 file changed, 3 insertions(+), 10 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43bd24670d1e9068519807daa8fea23e54b9a319 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ToStringBuilderTest printing
by amureini＠redhat.com 16 Sep '16

16 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ToStringBuilderTest printing ...................................................................... core: ToStringBuilderTest printing Removed useless printing to System.out from the test - tests should automatically verify results, not visually. Change-Id: Idc21f085a1198f4e753f0ba466d669b811dc216e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ToStringBuilderTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc21f085a1198f4e753f0ba466d669b811dc216e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: build: Use newer python-windows and pywin32
by vfeenstr＠redhat.com 16 Sep '16

16 Sep '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: build: Use newer python-windows and pywin32 ...................................................................... build: Use newer python-windows and pywin32 Change-Id: Id286c81e671fc6a5ad6c34e14f3516a7cff1b7f8 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-guest-agent-windows.spec 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id286c81e671fc6a5ad6c34e14f3516a7cff1b7f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use nop-logger for tests
by amureini＠redhat.com 15 Sep '16

15 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Use nop-logger for tests ...................................................................... engine: Use nop-logger for tests Printing out the logging information during unit tests isn't very interesting on the one hand, and on the other it slows down the build dramatically. Changing the slf4j implementation from the jdk logger to the nop logger improved build time by more than 10% on my machine (from ~7:20 minutes to ~6:10 minutes). Change-Id: Ife3b11a439d2f51a12db85eb66dfc8c87862e496 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/test/resources/logging.properties D backend/manager/modules/dal/src/test/resources/logging.properties D backend/manager/tools/src/test/resources/logging.properties M pom.xml 4 files changed, 1 insertion(+), 61 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife3b11a439d2f51a12db85eb66dfc8c87862e496 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Streamline slf4j dependency
by amureini＠redhat.com 15 Sep '16

15 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Streamline slf4j dependency ...................................................................... core: Streamline slf4j dependency Streamline the slf4j configuration so slf4j-jdk14 is defined only once and reused by all modules. Change-Id: I16c631757224f502514a45e3e043ae4656655dd8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/extensions-tool/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/pom.xml M backend/manager/tools/pom.xml M pom.xml 6 files changed, 6 insertions(+), 36 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16c631757224f502514a45e3e043ae4656655dd8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove UncommentedMain checkstyle
by amureini＠redhat.com 15 Sep '16

15 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove UncommentedMain checkstyle ...................................................................... engine: Remove UncommentedMain checkstyle This checkstyle rule is violated by virtually all the main methods we have. Instead of having it and suppressing it for all its occurances, it makes more sense to simply drop it. Change-Id: I4123e09bf17853745edc1269839af1dcb31acca0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/pom.xml M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 3 files changed, 0 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63944 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4123e09bf17853745edc1269839af1dcb31acca0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: HasForeignMenuData removed
by mbetak＠redhat.com 15 Sep '16

15 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: HasForeignMenuData removed ...................................................................... webadmin: HasForeignMenuData removed The interface is not used any more since *.vv files are fully generated on backend. Change-Id: I5d5529211d8f317941b364a867ff05a68c53689a Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractVnc.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpiceNative.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVncNative.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/restapi/HasForeignMenuData.java 10 files changed, 7 insertions(+), 108 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d5529211d8f317941b364a867ff05a68c53689a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Interface IVnc and ISpice removed
by mbetak＠redhat.com 15 Sep '16

15 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Interface IVnc and ISpice removed ...................................................................... webadmin: Interface IVnc and ISpice removed ... since both were practically empty and redundant. ISpice contained connected and disconnected events but these were never actually fired. Change-Id: I23e0b0897a3278cf17a0289d59940c2aeaed7dee Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/INoVnc.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpiceHtml5.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpiceNative.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVnc.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVncNative.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 17 files changed, 65 insertions(+), 158 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23e0b0897a3278cf17a0289d59940c2aeaed7dee Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Use pooling http client
by omachace＠redhat.com 15 Sep '16

15 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Use pooling http client ...................................................................... Use pooling http client To be able to use connection from multiple threads, we can't use BasicHttpClientConnectionManager, because it doesn't allow it. So this patch changes to using of PoolingHttpClientConnectionManager, which supports using of multiple threads. Change-Id: Ia0188394b9f2ff647a6fb03ddb5814d51c485c48 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1376402 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder42.java M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder45.java M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java 3 files changed, 28 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0188394b9f2ff647a6fb03ddb5814d51c485c48 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0