- Engine-commits - oVirt List Archives

Change in jenkins[master]: Add ovirt-host-deploy build-artifacts-manual jobs
by eedri＠redhat.com 06 Sep '16

06 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Add ovirt-host-deploy build-artifacts-manual jobs ...................................................................... Add ovirt-host-deploy build-artifacts-manual jobs Change-Id: I909df1dc35fe117bd668c9078b501eb4b3aaa37b Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_standard.yaml 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Sharon Naftaly: Verified Eyal Edri: Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/63431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I909df1dc35fe117bd668c9078b501eb4b3aaa37b Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Small changes in the build-artifacts-manual job template
by eedri＠redhat.com 06 Sep '16

06 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Small changes in the build-artifacts-manual job template ...................................................................... Small changes in the build-artifacts-manual job template Change-Id: I9e16c180b4232de5c39c0cdc55297648827964d4 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/yaml/templates/build-artifacts-manual-any_template.yaml M jobs/confs/yaml/triggers/standard.yaml 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sharon Naftaly: Verified; Ready for review Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e16c180b4232de5c39c0cdc55297648827964d4 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix race cond for NextRun and HA VM
by ahadas＠redhat.com 06 Sep '16

06 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Fix race cond for NextRun and HA VM ...................................................................... core: Fix race cond for NextRun and HA VM The RunVm command needs to wait on the NextRun application by ProcessDownVm. Fixes race condition after cluster version change in following scenario: - old cluster, running HA VM - cluster upgrade, so NextRun config is created - crash of the HA VM (like kill -9 [qemu_process)] - AutoStartVmsRunner can't be executed before ProcessDownVm finishes Change-Id: Ib6ee47d4557badefe9c79106a43b648645177050 Bug-Url: https://bugzilla.redhat.com/1369521 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 4 files changed, 61 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6ee47d4557badefe9c79106a43b648645177050 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.1.12
by juan.hernandez＠redhat.com 06 Sep '16

06 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.12 ...................................................................... restapi: Update to model 4.1.12 The more relevant changes included in the new version of the model are the following: * Add services to support disk attachments of virtual machines available for import from storage domains. Change-Id: Ida9987d556b30d3b9e8d0e20bca3e0297b720ec0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java M pom.xml 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida9987d556b30d3b9e8d0e20bca3e0297b720ec0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Revert "mock_runner.sh: Fix yum.conf location"
by eedri＠redhat.com 06 Sep '16

06 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Revert "mock_runner.sh: Fix yum.conf location" ...................................................................... Revert "mock_runner.sh: Fix yum.conf location" This patch empties the dnf.conf/yum.conf when ran on fedora, needs more investigating for a proper fix. This reverts commit e1c6f78868f03def709cb1f6d05c5cbd9b39bdb8. Change-Id: Ia57af84e42911f1df21da45d144a3ed1411973c4 Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Nadav Goldin: Ready for review Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Yedidyah Bar David: Looks good to me -- To view, visit https://gerrit.ovirt.org/63405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia57af84e42911f1df21da45d144a3ed1411973c4 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Release 4.0.1
by omachace＠redhat.com 06 Sep '16

06 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Release 4.0.1 ...................................................................... Release 4.0.1 Change-Id: I8111fd25a292f2f0ff9a0eba35b012dad5460014 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M packaging/build.sh M pom.xml A sdk/CHANGES.adoc M sdk/lib/ovirtsdk4/version.py M sdk/pom.xml M sdk/setup.py 7 files changed, 40 insertions(+), 7 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8111fd25a292f2f0ff9a0eba35b012dad5460014 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use only vm dynamic data when intialization vm-jobs mo...
by ahadas＠redhat.com 06 Sep '16

06 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use only vm dynamic data when intialization vm-jobs monitoring ...................................................................... core: use only vm dynamic data when intialization vm-jobs monitoring Change-Id: I717f13aef53a8d07fb1aa00ca118976c90c1c6be Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I717f13aef53a8d07fb1aa00ca118976c90c1c6be Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Improve type checking
by omachace＠redhat.com 06 Sep '16

06 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Improve type checking ...................................................................... Improve type checking Currently the types of the parameters passed to service methods aren't checked. As a result when there are errors they are detected too late, and the error messages aren't clear. To avoid that this patch changes the SDK so that the types of these parameters are checked inmediately, and so that the error messages are explicit. For example, if the user tries to start a virtual machine with wrong parameters like this: vm_service.start( use_cloud_init='true', vm=types.Disk( ... ) ) The SDK will inmediately raise a 'TypeError' exception with the following error message: The 'use_cloud_init' parameter should be of type 'bool', but it is of type 'str'. The 'vm' parameter should be of type 'Vm', but it is of type 'Disk'. The type check is performed by the new 'Service._check_types' function. The calls to this function are added to the beginning of each service method. For example, for the 'VmService.start' method: # Check the types of the parameters: Service._check_types([ ('async', async, bool), ('filter', filter, bool), ('pause', pause, bool), ('use_cloud_init', use_cloud_init, bool), ('use_sysprep', use_sysprep, bool), ('vm', vm, types.Vm), ]) Change-Id: Icb77aa4327dfff0ee0ea9bf8d2a1cf0b70c1ec90 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit ca085e490a59eb469c54299a5e3ff0561e6a96db) --- M generator/src/main/java/org/ovirt/sdk/python/PythonBuffer.java M generator/src/main/java/org/ovirt/sdk/python/PythonNames.java A generator/src/main/java/org/ovirt/sdk/python/PythonTypeReference.java M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java M generator/src/main/java/org/ovirt/sdk/python/TypesGenerator.java M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java M sdk/lib/ovirtsdk4/service.py A sdk/tests/test_check_types.py 9 files changed, 379 insertions(+), 88 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb77aa4327dfff0ee0ea9bf8d2a1cf0b70c1ec90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Improve type checking
by omachace＠redhat.com 06 Sep '16

06 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Improve type checking ...................................................................... Improve type checking Currently the types of the parameters passed to service methods aren't checked. As a result when there are errors they are detected too late, and the error messages aren't clear. To avoid that this patch changes the SDK so that the types of these parameters are checked inmediately, and so that the error messages are explicit. For example, if the user tries to start a virtual machine with wrong parameters like this: vm_service.start( use_cloud_init='true', vm=types.Disk( ... ) ) The SDK will inmediately raise a 'TypeError' exception with the following error message: The 'use_cloud_init' parameter should be of type 'bool', but it is of type 'str'. The 'vm' parameter should be of type 'Vm', but it is of type 'Disk'. The type check is performed by the new 'Service._check_types' function. The calls to this function are added to the beginning of each service method. For example, for the 'VmService.start' method: # Check the types of the parameters: Service._check_types([ ('async', async, bool), ('filter', filter, bool), ('pause', pause, bool), ('use_cloud_init', use_cloud_init, bool), ('use_sysprep', use_sysprep, bool), ('vm', vm, types.Vm), ]) Change-Id: Icb77aa4327dfff0ee0ea9bf8d2a1cf0b70c1ec90 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/PythonBuffer.java M generator/src/main/java/org/ovirt/sdk/python/PythonNames.java A generator/src/main/java/org/ovirt/sdk/python/PythonTypeReference.java M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java M generator/src/main/java/org/ovirt/sdk/python/TypesGenerator.java M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java M sdk/lib/ovirtsdk4/service.py A sdk/tests/test_check_types.py 9 files changed, 379 insertions(+), 88 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb77aa4327dfff0ee0ea9bf8d2a1cf0b70c1ec90 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use only vm dynamic data when initializing resource ma...
by ahadas＠redhat.com 06 Sep '16

06 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use only vm dynamic data when initializing resource manager ...................................................................... core: use only vm dynamic data when initializing resource manager Change-Id: I153941dc643d63123d02ecd796d2fb74bb92dce8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M packaging/dbscripts/vms_sp.sql 3 files changed, 16 insertions(+), 10 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I153941dc643d63123d02ecd796d2fb74bb92dce8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0