- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: Add test for iSCSI discover
by omachace＠redhat.com 06 Sep '16

06 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add test for iSCSI discover ...................................................................... Add test for iSCSI discover This patch adds a test to verify that the host 'iscsi_discover' method generates the correct response body, as this worked incorrectly in the past. Change-Id: I62a5348babf0db1e7419122ceb2d4a2389345d21 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/tests/test_iscsi_discover.py 1 file changed, 60 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62a5348babf0db1e7419122ceb2d4a2389345d21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: webadmin: infinite loop in new VM/pool dialog
by tnisan＠redhat.com 06 Sep '16

06 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: infinite loop in new VM/pool dialog ...................................................................... webadmin: infinite loop in new VM/pool dialog Open new VM/pool dialog and pick a template which had non-null custom compatibility version, the dialog ends up in infinite refresh loop. The reason was that the CoreVmBaseToUnitBuilder.postBuild called the model.getCustomCompatibilityVersion().setSelectedItem(vm.getCustomCompatibilityVersion()); all the time regardless of the fact it changed or not. This change leads to a full refresh of the whole dialog, including this builder. Fixed by setting this value only if changed. Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922 Bug-Url: https://bugzilla.redhat.com/1373204 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> (cherry picked from commit a453c83060eba01a630ab7fcdff5645e168ceed8) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: query only dynamic data of migrating vms
by ahadas＠redhat.com 06 Sep '16

06 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: query only dynamic data of migrating vms ...................................................................... core: query only dynamic data of migrating vms The query for VM that are being migrated is used in 2 places that do not actually need the whole VM data but only the one inside VmDynamic so can use a cheaper query. Change-Id: Ib72949de53af0adea9da8477b7a01590533298af Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M packaging/dbscripts/vms_sp.sql 7 files changed, 23 insertions(+), 27 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib72949de53af0adea9da8477b7a01590533298af Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by juan.hernandez＠redhat.com 06 Sep '16

06 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: I5de78ec6b9d5ae4b6476808c6f6e6a6ee14a1aa5 --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5de78ec6b9d5ae4b6476808c6f6e6a6ee14a1aa5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: restapi: Update to model 4.0.33
by juan.hernandez＠redhat.com 06 Sep '16

06 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.33 ...................................................................... restapi: Update to model 4.0.33 The more relevant changes included in the new version of the model are the following: * Add the `custom_scheduling_policy_properties` attribute to the `Cluster` type. * Add services and types to support transfer of images. * Remove the `add` and `remove` operations of virtual machine CDROMs. * Fix the type of the `usages` attribute of the `Network` type, it should be a list of values of the `NetworkUsage` enum, not a list of strings. Change-Id: I2dd1175dca29c58e519f0f8c47379d5a5154b7db Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dd1175dca29c58e519f0f8c47379d5a5154b7db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare release 4.0.1
by juan.hernandez＠redhat.com 06 Sep '16

06 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.0.1 ...................................................................... [maven-release-plugin] prepare release 4.0.1 Change-Id: I5a78df248351ab05dab3ba701b1c00543f17c796 --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a78df248351ab05dab3ba701b1c00543f17c796 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Update CHANGES.adoc for release 4.0.1
by juan.hernandez＠redhat.com 06 Sep '16

06 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update CHANGES.adoc for release 4.0.1 ...................................................................... Update CHANGES.adoc for release 4.0.1 This patch updates the CHANGES.adoc file, documenting the relevant changes in release 4.0.1. Change-Id: Ic2e70d31b501b55504ebfe4645c8543505f64e52 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/CHANGES.adoc 1 file changed, 33 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2e70d31b501b55504ebfe4645c8543505f64e52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Fix reading of lists of elements
by omachace＠redhat.com 06 Sep '16

06 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Fix reading of lists of elements ...................................................................... Fix reading of lists of elements Currently the method that read lists of elements doesn't handle correctly empty elements without close tags. For example, when reading the following cluster: <cluster> ... <required_rng_sources/> <switch_type>legacy</switch_type> </cluster> The 'legacy' value of the 'switch_type' element is interpreted as one of the values of the previous 'required_rng_sources' list. This patch fixes the method and introduces two tests to verify that it works correctly. Change-Id: I76c3625719c5e2ef327fcee7cec974d740d5f655 Bug-Url: https://bugzilla.redhat.com/1373431 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 576f99f2223d816450bfd05d594873213ece463a) --- M sdk/ext/ov_xml_reader.c A sdk/tests/test_cluster_reader.py M sdk/tests/test_xml_reader.py 3 files changed, 101 insertions(+), 10 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c3625719c5e2ef327fcee7cec974d740d5f655 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: restapi: Update to model 4.0.33
by tnisan＠redhat.com 06 Sep '16

06 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.33 ...................................................................... restapi: Update to model 4.0.33 The more relevant changes included in the new version of the model are the following: * Add the `custom_scheduling_policy_properties` attribute to the `Cluster` type. * Add services and types to support transfer of images. * Remove the `add` and `remove` operations of virtual machine CDROMs. * Fix the type of the `usages` attribute of the `Network` type, it should be a list of values of the `NetworkUsage` enum, not a list of strings. Change-Id: I934f27cbb78fa73fe06df85b1673a94d2880b896 Related-To: https://bugzilla.redhat.com/1351576 Related-To: https://bugzilla.redhat.com/1337077 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 6985b51966c29d9ed0e9b6718ae1d28ddbec076c) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3NetworkOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmCdromServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmCdromsServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java D backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkUsage.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkMapperTest.java M pom.xml 12 files changed, 50 insertions(+), 49 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63319 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I934f27cbb78fa73fe06df85b1673a94d2880b896 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: infinite loop in new VM/pool dialog
by tnisan＠redhat.com 06 Sep '16

06 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: infinite loop in new VM/pool dialog ...................................................................... webadmin: infinite loop in new VM/pool dialog Open new VM/pool dialog and pick a template which had non-null custom compatibility version, the dialog ends up in infinite refresh loop. The reason was that the CoreVmBaseToUnitBuilder.postBuild called the model.getCustomCompatibilityVersion().setSelectedItem(vm.getCustomCompatibilityVersion()); all the time regardless of the fact it changed or not. This change leads to a full refresh of the whole dialog, including this builder. Fixed by setting this value only if changed. Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922 Bug-Url: https://bugzilla.redhat.com/1373204 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> (cherry picked from commit a453c83060eba01a630ab7fcdff5645e168ceed8) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0