- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Added scheduling properties to cluster
by tnisan＠redhat.com 06 Sep '16

06 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Added scheduling properties to cluster ...................................................................... restapi: Added scheduling properties to cluster Custom scheduling policy properties added to cluster in order to support update/add/get operations of these properties and store them correctly at the back end. See examples below: GET /clusters/{cluster:id} : <cluster> <custom_scheduling_policy_properties/> <property> <name>{name}</name> <value>{value}</value> </property> ... <custom_scheduling_policy_properties/> </cluster> PUT /clusters/{cluster:id} <cluster> <custom_scheduling_policy_properties/> <property> <name>{name}</name> <value>{value}</value> </property> ... </custom_scheduling_policy_properties> </cluster> Change-Id: Ib1f3fad300e9fc79690b15159ca780ba7f97449a Bug-Url: https://bugzilla.redhat.com/1351576 Signed-off-by: yquinn <yquinn(a)redhat.com> (cherry picked from commit f4154ca) Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1f3fad300e9fc79690b15159ca780ba7f97449a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Fix reading of lists of elements
by juan.hernandez＠redhat.com 06 Sep '16

06 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix reading of lists of elements ...................................................................... Fix reading of lists of elements Currently the method that read lists of elements doesn't handle correctly empty elements without close tags. For example, when reading the following cluster: <cluster> ... <required_rng_sources/> <switch_type>legacy</switch_type> </cluster> The 'legacy' value of the 'switch_type' element is interpreted as one of the values of the previous 'required_rng_sources' list. This patch fixes the method and introduces two tests to verify that it works correctly. Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e Bug-Url: https://bugzilla.redhat.com/1373436 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ext/ovirtsdk4c/ov_xml_reader.c A sdk/spec/cluster_reader_spec.rb M sdk/spec/xml_reader_spec.rb 3 files changed, 79 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Fix reading of lists of elements
by juan.hernandez＠redhat.com 06 Sep '16

06 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix reading of lists of elements ...................................................................... Fix reading of lists of elements Currently the method that read lists of elements doesn't handle correctly empty elements without close tags. For example, when reading the following cluster: <cluster> ... <required_rng_sources/> <switch_type>legacy</switch_type> </cluster> The 'legacy' value of the 'switch_type' element is interpreted as one of the values of the previous 'required_rng_sources' list. This patch fixes the method and introduces two tests to verify that it works correctly. Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e Bug-Url: https://bugzilla.redhat.com/1373436 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ext/ovirtsdk4c/ov_xml_reader.c A sdk/spec/cluster_reader_spec.rb M sdk/spec/xml_reader_spec.rb 3 files changed, 79 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1495e873642aadd09ba3dd578077346f17e873e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add tests for some recent fixes
by omachace＠redhat.com 06 Sep '16

06 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add tests for some recent fixes ...................................................................... Add tests for some recent fixes This patch adds tests for some fixes which was recently fixed: * Fix tag names of action parameters * Don't return null from send method in case of failure * Avoid of reading fault response in case response body is empty This patch also adds test for proper reading of Cluster object. Change-Id: I6d38c4c4085a874ea288e014d1a9e60164f15b23 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/ClusterReaderTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/IscsiDiscoverTest.java M sdk/src/test/java/org/ovirt/engine/sdk4/VmsServiceTest.java 3 files changed, 138 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d38c4c4085a874ea288e014d1a9e60164f15b23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.9]: core: Allow null cpu_profile_id in the DB
by tnisan＠redhat.com 06 Sep '16

06 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Allow null cpu_profile_id in the DB ...................................................................... core: Allow null cpu_profile_id in the DB Will not throw NPE if VM has null cpu_profile_id in the DB. Change-Id: Iad6281415ab0e9637bc12ecc0b9a9cfe8529f93e Bug-Url: https://bugzilla.redhat.com/1373090 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java 4 files changed, 30 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/63382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad6281415ab0e9637bc12ecc0b9a9cfe8529f93e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.9 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.9]: core: Support migrating the HE VM out of cluster
by tnisan＠redhat.com 06 Sep '16

06 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Support migrating the HE VM out of cluster ...................................................................... core: Support migrating the HE VM out of cluster This would allow migrating the hosted engine VM out of the cluster. This is specifically needed in case where we want to migrate old cluster version to a new cluster, with new version. Change-Id: Ia49024fb7a6d9558e28c0da5465aff2118f7bbe8 Bug-Url: https://bugzilla.redhat.com/1356127 Signed-off-by: Roy Golan <rgolan(a)redhat.com> (cherry picked from commit 40fbe22c1816b24c746402814121772a5a0f6f97) --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ChangeVMClusterCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java 2 files changed, 44 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified Andrej Krejcir: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia49024fb7a6d9558e28c0da5465aff2118f7bbe8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.9 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Fix reading of lists of elements
by omachace＠redhat.com 06 Sep '16

06 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Fix reading of lists of elements ...................................................................... Fix reading of lists of elements Currently the method that read lists of elements doesn't handle correctly empty elements without close tags. For example, when reading the following cluster: <cluster> ... <required_rng_sources/> <switch_type>legacy</switch_type> </cluster> The 'legacy' value of the 'switch_type' element is interpreted as one of the values of the previous 'required_rng_sources' list. This patch fixes the method and introduces two tests to verify that it works correctly. Change-Id: I76c3625719c5e2ef327fcee7cec974d740d5f655 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ext/ov_xml_reader.c A sdk/tests/test_cluster_reader.py M sdk/tests/test_xml_reader.py 3 files changed, 101 insertions(+), 10 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76c3625719c5e2ef327fcee7cec974d740d5f655 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: infinite loop in new VM/pool dialog
by tjelinek＠redhat.com 06 Sep '16

06 Sep '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: infinite loop in new VM/pool dialog ...................................................................... webadmin: infinite loop in new VM/pool dialog Open new VM/pool dialog and pick a template which had non-null custom compatibility version, the dialog ends up in infinite refresh loop. The reason was that the CoreVmBaseToUnitBuilder.postBuild called the model.getCustomCompatibilityVersion().setSelectedItem(vm.getCustomCompatibilityVersion()); all the time regardless of the fact it changed or not. This change leads to a full refresh of the whole dialog, including this builder. Fixed by setting this value only if changed. Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922 Bug-Url: https://bugzilla.redhat.com/1373204 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c2e24faf1793f9de0e973ee41425f7cd32ea922 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Look for sound device by general type
by tnisan＠redhat.com 06 Sep '16

06 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Look for sound device by general type ...................................................................... webadmin: Look for sound device by general type The sound device in the managed device map of a VM must be located by VmDeviceGeneralType.SOUND, not by VmDeviceType.SOUND. The code that was fixed in InstanceTypeManager.postDoUpdateManagedFieldsFrom(VmBase) is called when user edits a VM and NEXT_RUN snapshot exists. After getting the information about NEXT_RUN snapshot, UI controls in the dialog are updated accordingly. The "Sound card" checkbox is always unchecked, because the code looks for a sound device incorrectly and cannot find it. When user clicks "OK" in the dialog, the difference between actual sound device configuration and the checkbox state is detected and confirmation dialog is displayed. Change-Id: I179bb4623815a90b5468e25e3432351e5458e04a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356568 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I179bb4623815a90b5468e25e3432351e5458e04a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Refactor loading of Backend Services
by rgolan＠redhat.com 06 Sep '16

06 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: backend: Refactor loading of Backend Services ...................................................................... backend: Refactor loading of Backend Services Backend services (classes implementing the BackendService marker interface) were loaded from 2 different places (Backend, InitServicesOnStartupBean) using CDI instance lookup. This duplicate logic was extracted into newly created ServiceLoader whose sole purpose is to provide a simple and uniform mechanism for loading of services. Change-Id: I5454be63f248f110f7ebf333e3876332f171da19 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ServiceLoader.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/BackendService.java 4 files changed, 48 insertions(+), 14 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5454be63f248f110f7ebf333e3876332f171da19 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0