- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: Ie4084a13829055765f9d10469839b7a56d6f00d3 --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4084a13829055765f9d10469839b7a56d6f00d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare release 4.0.0.alpha20
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.0.0.alpha20 ...................................................................... [maven-release-plugin] prepare release 4.0.0.alpha20 Change-Id: I4ba65a4e4a65117d8fcd0dae1f312db90198824d --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ba65a4e4a65117d8fcd0dae1f312db90198824d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Name plular element tag same as the member
by omachace＠redhat.com 18 Aug '16

18 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Name plular element tag same as the member ...................................................................... Name plular element tag same as the member Previously when we send action and contruct XML with list of the entity we named tags by the entity. This patch changes the behavior, so we name it by the member which is written. For example if we want to create bonds, we will send following xml: <action> <modified_bonds> <host_nic> <bonding> <options>...</options> <slaves> <host_nic> <name>eth0</name> </host_nic> <host_nic> <name>eth1</name> </host_nic> </slaves> </bonding> <name>bond0</name> </host_nic> </modified_bonds> </action> Previously we sent <host_nics> instead of <modified_bonds>. Change-Id: Ibc390782659effbfb1d70421da9e5e9d45129ede Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit d02068fa1c10ee25476037d6ed371d5f7ca25e0d) --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/SetupNetworksTest.java 3 files changed, 138 insertions(+), 18 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc390782659effbfb1d70421da9e5e9d45129ede Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Send query parameters with Add/Update actions
by omachace＠redhat.com 18 Aug '16

18 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Send query parameters with Add/Update actions ...................................................................... Send query parameters with Add/Update actions There are use cases where user can sent query parameters, along with creating/updating entity action. For example when creating virtual machine he can also copy permissions from template to new virtual machine. This patch add the support so the SDK sends the query parameters, supported by backend. Change-Id: Icaee85b912f575a911f2e618b910b7f6f52dfd71 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1366546 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit db8923e300ad4c6dfdc118efca837b40e38da6b9) --- M .gitignore M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java A sdk/src/test/java/org/ovirt/engine/sdk4/SecondaryParametersTest.java M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddIndependentVm.java 5 files changed, 206 insertions(+), 53 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaee85b912f575a911f2e618b910b7f6f52dfd71 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Update to model 4.0.32 and metamodel 1.0.17
by omachace＠redhat.com 18 Aug '16

18 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.0.32 and metamodel 1.0.17 ...................................................................... Update to model 4.0.32 and metamodel 1.0.17 The more relevant changes in this new version of the model are the following: * Add the `clone_permissions` parameter to the operations that add virtual machines and templates. * Add the `clone` parameter to the operation that adds a new * virtual machine. * Add the `ad_partner_mac` attribute to the bonding type. * Add the `ad_aggregator_id` attribute to the host NIC type. * Add the `upgradecheck` action to the host service. * Add the `ExternalVmImportsService` and related types. The more relevant changes in this new version of the metamodel are the following: * Name element tag by the enitity, which is written * Improve name parser * Report correctly incorrect operators * Use dash as section id separator Change-Id: I44b2139c22f51ef7482ce5d0204bfe50740e953a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java M pom.xml 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62556 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44b2139c22f51ef7482ce5d0204bfe50740e953a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Name plular element tag same as the member
by omachace＠redhat.com 18 Aug '16

18 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Name plular element tag same as the member ...................................................................... Name plular element tag same as the member Previously when we send action and contruct XML with list of the entity we named tags by the entity. This patch changes the behavior, so we name it by the member which is written. For example if we want to create bonds, we will send following xml: <action> <modified_bonds> <host_nic> <bonding> <options>...</options> <slaves> <host_nic> <name>eth0</name> </host_nic> <host_nic> <name>eth1</name> </host_nic> </slaves> </bonding> <name>bond0</name> </host_nic> </modified_bonds> </action> Previously we sent <host_nics> instead of <modified_bonds>. Change-Id: Ibc390782659effbfb1d70421da9e5e9d45129ede Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java A sdk/src/test/java/org/ovirt/engine/sdk4/SetupNetworksTest.java 3 files changed, 138 insertions(+), 18 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc390782659effbfb1d70421da9e5e9d45129ede Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Name element tag by the enitity, which is written
by omachace＠redhat.com 18 Aug '16

18 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Name element tag by the enitity, which is written ...................................................................... Name element tag by the enitity, which is written When writing XML, we always written XML element same as member, which we wanted to write. This patch changes it, so we name the singular element tag same as entity we write, not the member. For example if we want to create bonds, we will send following xml: <action> <modified_bonds> <host_nic> <bonding> <options>...</options> <slaves> <host_nic> <name>eth0</name> </host_nic> <host_nic> <name>eth1</name> </host_nic> </slaves> </bonding> <name>bond0</name> </host_nic> </modified_bonds> </action> Previously we sent <slave> instead of <host_nic> in <slaves> element. Change-Id: I277bc4678ab8d6da3d640a3863c6341b6e7a62ea Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 589062f52360a519298bfa6dc7737f4daf736452) --- M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java M sdk/tests/test_setupnetworks.py 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I277bc4678ab8d6da3d640a3863c6341b6e7a62ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Bump RPM release number
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Bump RPM release number ...................................................................... Bump RPM release number In previous versions of the SDK the RPM release number used to be extracted from the version qualifier. For example, if when the version qualifier was "alpha13" the RPM release was "0.13.alpha13". This isn't correct, as it complicates bumping the RPM release number when modifications to the .spec are needed without changes to the SDK. The ideal solution to this would be to have the .spec files in a different repository, and update them manually. As that isn't possible the automation scripts have been changed to automatically generate the RPM release number, but they don't do this icorrect handling of the release number, instead they take it directly from the .spec file templates. A side effect of this is that the RPMs generated by the automation scripts since the change was introduced look older than previous ones. For example, the RPM for version "alpha19" looks newer than the RPM for version "alpha13": 0.1.alpha19 < 0.13.alpha13 To avoid this issue this patch changes the .spec file templates so that the release number is greater than the last RPM generated using the previous approach. This change will we reverted when there is a change to the SDK major, minor or fix number. For example, when 4.0.1 is released, the RPM release number will go back to 0.1. Change-Id: Iff8ae2e6be1268c01f1a1deb033d9722b91a4cdb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff8ae2e6be1268c01f1a1deb033d9722b91a4cdb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add support for secondary parameters
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support for secondary parameters ...................................................................... Add support for secondary parameters The "add" and "update" methods support one primary parameter that corresponds to the HTTP request body, and multiple secondary parameters that correspond to URL query parameters. For example, the method to add a virtual machine looks has the primary "vm" parameter, and also the "clone" secondary parameters. Currently secondary parameters aren't supported by the SDK, they are just ignored. This patch adds support for those parameters. Change-Id: I24188c5107950c29467d31b81337f9703a0c2e46 Bug-Url: https://bugzilla.redhat.com/1366548 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java A sdk/examples/add_independent_vm.rb M sdk/spec/spec_helper.rb M sdk/spec/vms_service_spec.rb 4 files changed, 230 insertions(+), 62 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24188c5107950c29467d31b81337f9703a0c2e46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Improve support for Yard tags
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Improve support for Yard tags ...................................................................... Improve support for Yard tags This patch adds a new "addYardTag" method to the Ruby buffer class to simplify the generation of Yard tags that contain multiple lines. Change-Id: I9b94c93114840b7371401d2d9b9a9f97412c5c24 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/RubyBuffer.java M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/VersionGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java 6 files changed, 142 insertions(+), 70 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b94c93114840b7371401d2d9b9a9f97412c5c24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0